From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C52D7C4345F for ; Wed, 17 Apr 2024 16:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GP7DFantIEl94aEpxitrdRUm4NtXa3UnetHvu5hIk+o=; b=zugXfFS3S8aO/J apQBEnbINeskhmlgSTggvibr+hSgREp31DEXsKmP97uLPYHeq0vtBz+RRylIokK+M0U3NpiLEGyo0 C6YQ/XMKpdy64M4KBZrOO6vcoUwbytEMtWsw9ZIIF7MDiwWr08eknIPjRo18IaT7d9Ss34ukozTs3 VukERVhWy4TPgcvaKIIEEbInkQAQZnq9OfrwP5qxJwDYxTdmmYIA8sadowCi9U0xsXlft6u7Kzp2B RNIvB97CNql6om7x3S2S8ugJSYSa5ltPQH8+lFXyUHbZu++QSrBGtMmP4o9nkP6PZFUrt3ZTpSXHJ 8YS/iqBO3DSio0IC4DRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7wj-0000000Gluq-2WTY; Wed, 17 Apr 2024 16:15:41 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7wh-0000000Glu6-1KT2 for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 16:15:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 21EA360B9E; Wed, 17 Apr 2024 16:15:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FDA6C072AA; Wed, 17 Apr 2024 16:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713370536; bh=FTzmG7MPyh44PqEdk5C7BCbIh1HKSVVdYFoDXul9zXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K4yCazdGVtfBCjw8wIQJhHOx9X8gjbUTqm4NTsff6F+5rsMIhth6BK/sGLfu43Gk6 lJ011ARgfnxYojR/y86+K0q05tGYTGvUV2KyMQWP00Lnu4pNKcbrdYJPWTC6/QUyE0 xtdA/vyTDZ9R7jnEZL61wfx8UStwZwWr/WIadeC4hon79+bkk8BcYq+N46YVyXIheW +Qm92vbyG2duolQ9RIHp0rr/fGDEjAvTK7jHUHfEtYj2wrg9r4tkhj0gVFeYGjtolr 3Heyb9pFOU7Xf9RtmyTpM6ut68keRoVigGHBUvd0hWw9MOzxApzWf4TdNxloGW5Edc XPFe0g7i9LAvg== Date: Wed, 17 Apr 2024 13:15:33 -0300 From: Arnaldo Carvalho de Melo To: Anshuman Khandual Cc: James Clark , linux-perf-users@vger.kernel.org, Mike Leach , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf test: Increase buffer size for Coresight basic tests Message-ID: References: <20240326113749.257250-1-james.clark@arm.com> <5a4023aa-af9b-48d2-84f3-a0b9b30dc54e@arm.com> <7f5c32dd-edc6-4b53-9cdd-780756f5536c@arm.com> <369b29bf-66d8-4876-ae0c-a35f3c46973e@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <369b29bf-66d8-4876-ae0c-a35f3c46973e@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_091539_400055_624D09E1 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 01:55:25PM +0530, Anshuman Khandual wrote: > > > On 4/12/24 13:52, James Clark wrote: > > > > > > On 12/04/2024 08:04, Anshuman Khandual wrote: > >> > >> > >> On 3/26/24 17:07, James Clark wrote: > >>> These tests record in a mode that includes kernel trace but look for > >>> samples of a userspace process. This makes them sensitive to any kernel > >>> compilation options that increase the amount of time spent in the > >>> kernel. If the trace buffer is completely filled before userspace is > >>> reached then the test will fail. Double the buffer size to fix this. > >> > >> This is a valid concern to address, but just wondering how did we arrive > >> at the conclusion that doubling the buffer size i.e making that 8M will > >> solve the problem positively for vast number of kerne build scenarios ? > >> > > > > Nobody else has reported anything yet, if it happens again we can always > > increase it again if that is what the issue is. I had most of the kernel > > debugging stuff turned on like memory debugging etc, which is probably > > why I ran into it and 8MB fixed it for me. So I'm not sure if there is > > much more that could be added. > > Makes sense, > > Reviewed-by: Anshuman Khandual Thanks, applied to perf-tools-next, - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel