From: Cristian Marussi <cristian.marussi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
f.fainelli@gmail.com, vincent.guittot@linaro.org,
peng.fan@oss.nxp.com, michal.simek@amd.com,
quic_sibis@quicinc.com, konrad.dybcio@linaro.org,
souvik.chakravarty@arm.com
Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: Add dedicated vendor protocols submenu
Date: Wed, 17 Apr 2024 13:54:00 +0100 [thread overview]
Message-ID: <Zh_GaLMJdf7wv2sp@pluto> (raw)
In-Reply-To: <20240417120945.jjcpfwknj5urb6bk@bogus>
On Wed, Apr 17, 2024 at 01:09:45PM +0100, Sudeep Holla wrote:
> On Mon, Apr 08, 2024 at 10:30:52AM +0100, Cristian Marussi wrote:
> > Add a dedicated Kconfig submenu and directory where to collect SCMI vendor
> > protocols implementations.
> >
>
> This looks fine. But I would wait until the first vendor protocol is
> ready to be merged to merge this as baseline. Hope that's OK.
>
Absolutely, I think some vendor protocols currently on the list (beside
their ready-to-merge status) will rebase on this once this is in -next.
What remain to discuss really, it is, as I mentioned offline, if we want
to also group the vendor protocols headers (the one containing the
public protocol ops) somewhere...I think now they are just placed on top
level include/ named like
/vendor1_scmi_something.h
/scmi_vendor2_something_else.h
..or (as I now remembered you mentioned offline) just leave as it is for
now and then post a patch on top to shuffle around the headers into some
common include/scmi/ top dir...not sure anyway if it worth...maybe some
header name convention is fine (but I ignore if there are rules about
polluting more or less the top level /include/ dir :D)
I assume also that this mechanism is fine for vendors at this point, since
all the feedback we've got from them till now was on specific (and very
much welcome) code-reviewed stuff...
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-04-17 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 9:30 [PATCH v2 0/2] SCMI multiple vendor protocol support Cristian Marussi
2024-04-08 9:30 ` [PATCH v2 1/2] firmware: arm_scmi: Add support for multiple vendors custom protocols Cristian Marussi
2024-04-17 12:32 ` Sudeep Holla
2024-04-17 12:42 ` Cristian Marussi
2024-04-17 13:20 ` Sudeep Holla
2024-04-08 9:30 ` [PATCH v2 2/2] firmware: arm_scmi: Add dedicated vendor protocols submenu Cristian Marussi
2024-04-17 12:09 ` Sudeep Holla
2024-04-17 12:54 ` Cristian Marussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh_GaLMJdf7wv2sp@pluto \
--to=cristian.marussi@arm.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=peng.fan@oss.nxp.com \
--cc=quic_sibis@quicinc.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).