From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C369C4345F for ; Wed, 17 Apr 2024 15:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P/NGQMyyIsIxGwRICI3NqTa2yXaUSY1PFIMm9UaKBr0=; b=kDBZTghjsqjZ7T GNsVFQ6tbSqoe+g7G+5U36gVSgSn7nKihP1Zi8hQYTe6TiB3CtW8U4MBkazKoOyAeItfOG1GGTCxr KT0HUr0rpsjdkW9zmeEMYMbQqzMVs6FSuCAWBuA3VkTOs1iVaM3FrecYgZTnkbL1XUWdODOElrnZf OvFOxZ+1JJPgEgr4/X+Az1eVlnCs/SeU4QmTZFKCr1qhlGWucnKx8V2Sf5uVfLxKxtcO/NAmT8nW4 pNQTZ+DkDwm1pN2ODgDz47a/+5ep61VvG9mH4xGqWh/CVPq+f9QfQj1QvE46f1jubYB2+zvv6dLM6 TNbLMtGqr1lG+MEIUrjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7Zk-0000000GgW9-19Ht; Wed, 17 Apr 2024 15:51:56 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7Zg-0000000GgTE-2Rb3 for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 15:51:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 58BC5CE13D4; Wed, 17 Apr 2024 15:51:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AF1FC072AA; Wed, 17 Apr 2024 15:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713369108; bh=WLarpyYIWWkkchcEU9ZfUR3cQ8pEaw4tJ/8AER+TFKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X8956/kWgEy3matkA3uhP5tLIBv/of2FydJ4VmB+tierc5whIG7Oqb4ZHSb3jiu8j Ag7bo6Fumapa1dMDJdWiZpoUmdF/Le46cewurhe3QgMnGsxbOF23lDEYecDp7wNxQe ptZfPNxcR6yBm7Aq7oyCK/tLT62TUupFkYgPaiYW1bDe/FnFAk/sRE7Cafe0mkhrYb 7LEkgwmhQsO41Y3o8zyCQJDDhZVKG5GkSyWk5d+VL5oqUgdQqjKYQOhqYDu0h+P0Vk nbqazQrKW+CB+/eBjA554zLLXTHe4ZLVHVeRk8JmVxcZ31NTEq08LxCHOB7WWEkuQH MM6fhU3TGfqEQ== Date: Wed, 17 Apr 2024 12:51:45 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Ilkka Koskinen , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry , Mike Leach , Leo Yan , Namhyung Kim , Ian Rogers Subject: Re: [PATCH] perf vendor events arm64: AmpereOne/AmpereOneX: Mark L1D_CACHE_INVAL impacted by errata Message-ID: References: <20240408214022.541839-1-ilkka@os.amperecomputing.com> <3df74a0a-6778-43c4-a8c2-70d71c324f6a@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3df74a0a-6778-43c4-a8c2-70d71c324f6a@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_085152_990202_3F9AF259 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 09, 2024 at 02:33:18PM +0100, James Clark wrote: > On 08/04/2024 22:40, Ilkka Koskinen wrote: > > L1D_CACHE_INVAL overcounts in certain situations. See AC03_CPU_41 and > > AC04_CPU_1 for more details. Mark the event impacted by the errata. > > > > Signed-off-by: Ilkka Koskinen > > --- > > tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 4 +++- > > tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json | 4 +++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > index 7a2b7b200f14..ac75f12e27bf 100644 > > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > @@ -9,7 +9,9 @@ > > "ArchStdEvent": "L1D_CACHE_REFILL_RD" > > }, > > { > > - "ArchStdEvent": "L1D_CACHE_INVAL" > > + "ArchStdEvent": "L1D_CACHE_INVAL", > > + "Errata": "Errata AC03_CPU_41", > > + "BriefDescription": "L1D cache invalidate. Impacted by errata -" > > }, > > { > > "ArchStdEvent": "L1D_TLB_REFILL_RD" > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json > > index c50d8e930b05..f4bfe7083a6b 100644 > > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json > > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/cache.json > > @@ -9,7 +9,9 @@ > > "ArchStdEvent": "L1D_CACHE_REFILL_RD" > > }, > > { > > - "ArchStdEvent": "L1D_CACHE_INVAL" > > + "ArchStdEvent": "L1D_CACHE_INVAL", > > + "Errata": "Errata AC04_CPU_1", > > + "BriefDescription": "L1D cache invalidate. Impacted by errata -" > > }, > > { > > "ArchStdEvent": "L1D_TLB_REFILL_RD" > Reviewed-by: James Clark Thanks, applied to perf-tools-next, - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel