From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43DFDC00A94 for ; Fri, 12 Apr 2024 11:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=31yd5xJ6o6oupxmfXbf3g1XRQN0zohugMZ3sOv+z8f4=; b=ArBEe0sq1ZAmwF Hk+HuS2oqftsE5jvpW7YOJvCK9S1ISR4WOdZiOqsSg/0Hee83JKEf8WrHuwasAFOoVvfZ+ZmdR8bV Tg30gAJ4/VDLK5xnIlqjMKMK+gQl5X94aPgKHTvYJdikh2ifwzQb12seiex5/O+gc1tT9aJFTrxli KZFFCNQHcwLbuTTLMk2gvZDOyMfsoLz2N19Fjr4mWbG+vBtGmS085ZVvz2VrtE/jJdYmmRlSuBbva 0QhCXRvW+VQl6ug1NKgQcY+W322E2UfO8mPEknm+Ys77XIT4CSsDD05ig7H0pLlD69Y6DYabLAmD7 ni3RQ1f7Jw447L//OAqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvEi2-0000000Gq9T-3sTQ; Fri, 12 Apr 2024 11:04:42 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvEhw-0000000Gq6Q-1GvJ for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 11:04:41 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a51b008b3aeso89743266b.3 for ; Fri, 12 Apr 2024 04:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712919872; x=1713524672; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5ZWeBFh7QACCuutiiPpJmVZ9uLRO6+K6nohTcAyDGFE=; b=egAaYXw+0mYHTxtmm8bzDNSgb7tLMHB/iFZmV3J9ekzMUB7SegO6UC83VWOntYnjoZ 2MDWNts395T3AFuFXuMNTVI6sbciWqPUaCK2gcxcKA7BEpXihyjYfCIGoSrUmW3Og73y K5fEspUDTnwfkBfYWi6/3d10pqinOJWGed/BPzWx+nFXjAoGyr3vey/XBgzCApt8bANj B2YfgTTTJ/D7YN+2t59BF1mc3BGKicmorDAFW7eAm714sU6C1TjsW0Ujn1FjCe+Ob0mG sA+iY5iWh7FyhTam/J6QouCfAyPI+mXCZIKmLOdWd7nWU7Zpywvfzl7YTo2QkPeEBcyW QYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712919872; x=1713524672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ZWeBFh7QACCuutiiPpJmVZ9uLRO6+K6nohTcAyDGFE=; b=YHL0+8pSET8YU2mX/lqwzD+/v6aPOA5KSCwQ/WdX+mz2dLaTocW4Ttu/ddqehpMQNc fzG9u/40nM+uQ4KNwhu7//VwOwVMWn40fYmPqnB0lRHsCD3A04nK9VO8GgHz0gzJHOhv m9k7AlpDOGDC/1JJn2wL8W2VCO8LEQXm2vydcWKlOwThpzQNX1zA1PcOr/1B7HaZyDgI K0ZhTdCzeYf/HKCBI73GUlXgb3BHlhd115NEyXc5/k+lmA+X440C5i7nM5XjT0hU33Xp 12PJRADBtXTbflY/nqFxjeA2HapzmqjVh9Erk2IkV7nZRgsr2PAfe4rDn+eo8Xleh/R1 VAng== X-Forwarded-Encrypted: i=1; AJvYcCWE/4wDb1ZC+bdyve+DL6Yp4d2FERieCmeSl+8XmHd9vKHo6YRMJ0mT5kMgooUBN4dGEuoAOCjpIC2dBJIvhVN+aMjTcmxMOKX72YqIfPK8BmMauBU= X-Gm-Message-State: AOJu0YxMH6mCCIBrdJrpXxbMiQOSOVdlmqqtFVaM7xDyy/gQ+vOa+bbN tw4GhU269/dorAhqkxC12C/XpcOMNEGNNtpbafGFUMXZmjbt3MPOt432qwK4f5c= X-Google-Smtp-Source: AGHT+IH4VUAKHBWqRNJzHGdIvq8PGL5V48yPws8cK6i36baicRTB+rSLgHyFIHK+0WrfBeufEQueFw== X-Received: by 2002:a17:906:11ce:b0:a51:bca7:3a96 with SMTP id o14-20020a17090611ce00b00a51bca73a96mr1624173eja.72.1712919871946; Fri, 12 Apr 2024 04:04:31 -0700 (PDT) Received: from linaro.org ([79.114.172.194]) by smtp.gmail.com with ESMTPSA id dm11-20020a170907948b00b00a51eed4f0d7sm1684736ejc.130.2024.04.12.04.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 04:04:31 -0700 (PDT) Date: Fri, 12 Apr 2024 14:04:29 +0300 From: Abel Vesa To: Krzysztof Kozlowski Cc: Bjorn Andersson , Krzysztof Kozlowski , Stephen Boyd , Matthias Brugger , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong , AngeloGioacchino Del Regno , Rob Herring , Conor Dooley , Srini Kandagatla , Johan Hovold , David Collins , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v9 1/7] dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema Message-ID: References: <20240407-spmi-multi-master-support-v9-0-fa151c1391f3@linaro.org> <20240407-spmi-multi-master-support-v9-1-fa151c1391f3@linaro.org> <920d797f-0e1a-458a-9924-1f299a8752d3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <920d797f-0e1a-458a-9924-1f299a8752d3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_040436_389499_AE3BC4E5 X-CRM114-Status: GOOD ( 34.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-04-08 08:30:56, Krzysztof Kozlowski wrote: > On 08/04/2024 08:04, Abel Vesa wrote: > > On 24-04-07 19:07:03, Bjorn Andersson wrote: > >> On Sun, Apr 07, 2024 at 07:23:21PM +0300, Abel Vesa wrote: > >>> Add dedicated schema for X1E80100 PMIC ARB (v7) as it allows multiple > >>> buses by declaring them as child nodes. > >>> > >> > >> But is this really a "dedicated schema for X1E80100"? Isn't it "the > >> schema for all multi-bus controllers"? > >> > >> I.e. isn't this a "dedicated schema for all platforms starting with > >> SM8450"? > > > > Suggestion was from Krzysztof to add platform specific comaptible (and > > therefore schema). Since the first platform that will support in > > upstream proper multi bus is the x1e80100, the schema needs to bear the > > same name as the compatible. When support for multi bus will be added to > > the other platforms (including the SM8450), they will use the fallback > > compatible of the x1e80100 and will be documented in this newly added > > schema. We did the same thing with some PHYs drivers, IIRC. > > > >> > >> Can you please use the commit message to document the actual reason why > >> you choose to create a dedicated schema for this? Is it simply to avoid > >> having to schema with either pmics or multiple buses as children? > > > > I can re-send the patchset with such a phrase in commit message. > > > > One of the early versions of this patchset was actually submitting a > > generic compatible for multi bus, but I remember that there was a > > request for following the platform dedicated approach. > > > > Krzysztof, can you please provide here the argument for why that is > > preferred? > > I could not find such suggestions from my side in the archives, except: > https://lore.kernel.org/all/dd86117e-0196-499b-b8b3-efe4013cbc07@linaro.org/ > > where I want SoC specific compatibles to be used, not versions. > > Now about this binding, it is not a schema for all platforms starting > with sm8450, but only for x1e. I do not understand why this would be a > problem? > I agree, I don't think there is a problem with that. At some point, all platforms starting with sm8450 will be added and then we can even make the sm8450 compatible as the fallback comaptible. > If you ask why this is not a schema for all platforms, then because: > 1. maybe no one tested other SoCs? > 2. maybe no one cares? > 3. maybe other boards need some quirks, so this would be applicable but > not fully? > > I don't know... since when do we add "generic schemas"? > The focus of this patchset is support on X Elite which implicitly needs multi bus support. Again, we can do the other ones later on. I don't think we should extend the focus of this patchset more that it already is. > However maybe the question is different: why other devices are not > described here, while they should? Then probably Abel can answer what he > wants and what he does not want to describe. There is no requirement to > model all possible hardware in a binding, but instead describe one > hardware, so x1e, fully. > I'll switch the older platforms as well in a separate patchset, I promise. But let's not delay this any longer. > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel