From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67769C4345F for ; Mon, 29 Apr 2024 13:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wfZkLlCUO6WbRZq0qHCkK7HrlW/22Lp0oOslvnO9AbU=; b=3F0JeT61KvmFX4 Tu0wluIzWl9ycfbWG68QdsWHMIgpkbMwAXtLJ6+18q+Fo7kuLsxNZ4JwDc02f6L/aDlQ0hbjA4hX5 ybC5EYShNlKb8yoRsymtkQXg6Lm4Zi5TFfiWcaYV1mRrynl2W0Z2IZTbW55K2I2JFWxCNAKbJdSfM WugbsUzPJlMbLHpKYWC0eyJC/KJeOt0uBaIQWZIY7KY2rc3sEKfOlnRB8Vh10CXgW9JThfPpSzMgp FpIXXR4tuCExNGglbd90hOpQpCuAtzzzpZgXmJ3DlJ0rkNz6sCUr9WWHN1J3aRS9vpTGFf3vpLl21 5qAtrbggegtqeJo2Gx5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Qu4-00000002u1J-1hjV; Mon, 29 Apr 2024 13:18:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1Qu1-00000002u01-3qtD for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2024 13:18:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ukVgE4qDqlBDH2cqXY2lOwS2mKM9ytx95cPwf5PU+G8=; b=S8PNixbPxQeQKPGe0J0f5+P+68 Zsu5gpzvVxXg0r9x9Zf+DgStHc1+Hd8T9+khCI/LMaLF/8Yyp4fggUmjhx2ZDiQOvGLjpWVnHi6+Q DUOYLTYQ+ixmoLiP5livYM8AOL5tHJBC6ViWzU/GlSaMFndcBcB/8dnvFASoan5QI/G65GHsnfvau KfGwX4PrsgcwKH2PB+CNpElOzjVKX3sZahzu4xzh4ZaGilatFTPjROvPMaVdupzHMC8TxiJwBgr5a YkoBCBg+/W583xm52lGiaeaIaOmQDNgXn1rNi8YVOUPm1GS8ZoeYwA9P7k0emi0dp5DOKyEvZX6g9 VB7GpWhg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56856) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s1Qtp-0003E1-1Z; Mon, 29 Apr 2024 14:18:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s1Qtp-0000sO-2Z; Mon, 29 Apr 2024 14:18:29 +0100 Date: Mon, 29 Apr 2024 14:18:28 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: Sami Tolvanen , Kees Cook , Nathan Chancellor , Nick Desaulniers , Ard Biesheuvel , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH v5 04/10] ARM: mm: Type-annotate all cache assembly routines Message-ID: References: <20240415-arm32-cfi-v5-0-ff11093eeccc@linaro.org> <20240415-arm32-cfi-v5-4-ff11093eeccc@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240415-arm32-cfi-v5-4-ff11093eeccc@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240429_061842_002280_6FF4F9B0 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 03:43:23PM +0200, Linus Walleij wrote: > -ENTRY(fa_flush_user_cache_all) > - /* FALLTHROUGH */ > +SYM_TYPED_FUNC_START(fa_flush_user_cache_all) > + b fa_flush_kern_cache_all > +SYM_FUNC_END(fa_flush_user_cache_all) The thing I don't like about this is that it makes these functions less efficient - the early CPUs do _not_ have branch predictors, and they flush the pipeline on branches, so rather than just dropping rough, this kind of thing introduces pointless multi-cycle delays for functionality just to keep CFI happy. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel