From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81ECFC4345F for ; Mon, 29 Apr 2024 04:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Y6KT21sGndZko6M5DOCUJ6B+tYcgsCfECm+yKn1NdA=; b=PuR6SONNXkGVbt 0koo15+MOaXeZLcQXt211cCsZn0bvo98nLJjfdY1mn/aB5A7ZFBU/hl8P1g3q3Eq1GV+BOYqBFwn0 1X9oF6esWXZf/M6v3dVrPKIaqdunVkusu223La+T0iCCSVN4wEsCrM6Aqf16qvCQ8OrrFm8QQZcQ7 8gUynM0oUcIGjboSQKyA80T3oFTUjshz/kre5ba6PyTJCCpKVQfvZh9hH6pnYf1dVc1AE/DAmet63 fSOW1dxErYJ5jAGjBnnCSzTyVMidf3rYr+H+ICRYz9CjWdpXMOa4I3RMeRrCh40HvwRTqcjStWg1K 7h2vVUmTmXUD28efYhJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1IlS-00000001QgG-1jd6; Mon, 29 Apr 2024 04:37:18 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1IlQ-00000001Qfn-0JWj; Mon, 29 Apr 2024 04:37:16 +0000 Date: Sun, 28 Apr 2024 21:37:16 -0700 From: Christoph Hellwig To: Chen Ni Cc: vkoul@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: bcm2835-dma: Add check for dma_set_max_seg_size Message-ID: References: <20240429041312.2150441-1-nichen@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240429041312.2150441-1-nichen@iscas.ac.cn> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2024 at 12:13:12PM +0800, Chen Ni wrote: > Add check for the return value of dma_set_max_seg_size() and return > the error if it fails in order to catch the error. Ok. this looks like you're looking t all dma_set_max_seg_size callers? If so mybe just work on removing the return value instead.. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel