From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DE14C4345F for ; Thu, 18 Apr 2024 07:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=95O7ib2g25Cp/pEExJYYwp0TX3TJyCaWZwlgDHXSi98=; b=WlFPuYRylr8gmZ /b7hTrrHGkU6yUt9h17bYfySMOACmQn7ZpF/bOF8roObpndXKJgUrDfKtQs/CZTUx3XRwo+cHfHRa kDLCF5aE6WQ0aGAczpVw4cnJC3V+q5mcs3WfvgL0ny0Bq+iieL8KhSfwf+/ToRPlCxO7WhazDsgnD Fb6Cl4nZ/UFSodi8mRYqscDBn0WCL8g8g+xFVgpdwOxaM2EA+O8gxzD4xT4DSabBcd50PrMekAKNB l3h9RyuESk15pdGaZ3x+Ejgrm/BnoFvqn8YU0BwN8yIRis/aK6wuFIALrvU9i8iP1ZsKOrjWi/dKo 0zz4NPjE445jmqCxzWvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxMBw-00000001GZe-3Oye; Thu, 18 Apr 2024 07:28:20 +0000 Received: from smtpcmd14162.aruba.it ([62.149.156.162]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxMBt-00000001GZA-1GFu for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 07:28:18 +0000 Received: from engicam ([146.241.28.123]) by Aruba Outgoing Smtp with ESMTPSA id xMBpr2JFzjEwexMBqrCMpp; Thu, 18 Apr 2024 09:28:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1713425295; bh=/D7loSoJ8LTuZFSDTmGdK+mo8Ji5LnnuBOROJJyE4rY=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=U1tzA1E4DcLAj/KgA3NwRvty/MP3y1sdyO95Qk+bPG7EtxNfh3K6HzmV7bfGip5w8 pyr3GytQicCeaDLF1GqbqtVQyYYeXPesTUxazjbUbOMKLqFwIXx9C6x3wli2Le1rou NNZjSbgRvOMlSNYmp1LaAWJi2hcr5SGWtD8hGhRmY2JLyuSlhOOjqUzne7zgFZWqgb gxmzFgWsXwOp+GXU1+BfcmsXP+MXH5DGbbraQMCxVGK7RIeKbjbrO+C4b3D2uvVpSf 0hDybEJidTM68sU7AuTEjicW7t/no38M3twffTYcjZVGef8uUenkQuiLWjZ6ZVieVt o5sv6+Ey1JrUw== Date: Thu, 18 Apr 2024 09:28:13 +0200 From: Fabio Aiuto To: Krzysztof Kozlowski Cc: Shawn Guo , Sascha Hauer , Rob Herring , Conor Dooley , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Matteo Lisi , Mirko Ardinghi Subject: Re: [PATCH 4/4] arm64: dts: imx93: Add Engicam i.Core MX93 EDIMM 2.0 Starter Kit Message-ID: References: <20240417153528.7838-1-fabio.aiuto@engicam.com> <20240417153528.7838-5-fabio.aiuto@engicam.com> <41a1ca01-384a-40ca-a5f6-6205bb43825b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41a1ca01-384a-40ca-a5f6-6205bb43825b@kernel.org> X-CMAE-Envelope: MS4xfIqOolBh5THzUaCAYTNotxuYXn9r+bHpV5qiOjW+r+LG0RRPRAuuhMJP3GdpT68KtsTYjnbSJjA2+B/dCIdYpLrAFzxPmzu+hBEbVQxIZrOY7UQ30p+Q gw3/qYokJYm74WgWpoTFvFE5IpQYBT0ZII3yTf1zNeDC9QX5Vd58gCB8+h7GJI5BabYj13u2HajQXqhCLHI336qT5/bOP8qzPAVl9lbsAfD0KTJkiNRiezuI Rr1FQrl+wFvvZCqKSU8jqgBabiy6w0XdD2+Pp7aI/hFIfXQyYcTvE4vleTgKlPdueCT2HWmMqWMc3EO99Pz2kEtd5zcJM9srfj5H5/T7st5iDf11g1Pg+9SG GNxeZpPrx5NGgOjSKqzjHD1cjMjzIqznEalKYS3ERV2jFuxqvhRkwv6PnBSg4Pef+jTTgLmV6RKShJoEtLcf7R6ZKDqwgdPWpKWhGIFGsOHMWO4HNDjE7+7p MiPfX4EI1D6kkypVa+IDiLyFohlqBnWNwJ3J3hBCGoxuw9nc9p7LMpsOSVFBJEbHH8qZl01ld+JrbuzNH3ANce4ucFtVSIXqJ7wGCocJ8ELj1X3J+GiJC2v3 NGrFtucMcI9X89RnRSKp52cW X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_002817_534455_1E9BD728 X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Krzysztof, Il Wed, Apr 17, 2024 at 07:08:00PM +0200, Krzysztof Kozlowski ha scritto: > On 17/04/2024 17:35, Fabio Aiuto wrote: > > i.Core MX93 is a NXP i.MX93 based SoM by Enigcam which > > needs to be mounted on top of Engicam baseboards. > > > > Add support for EDIMM 2.0 Starter Kit hosting > > i.Core MX93. > > > > Starter Kit main features: > > > > 2x LVDS interfaces > > HDMI output > > Audio out > > Mic in > > Micro SD card slot > > USB 3.0 A port > > 3x USB 2.0 A port > > Gb Ethernet > > 2x CAN bus, 3x UART interfaces > > SIM card slot > > M.2 KEY_B slot > > > > Cc: Matteo Lisi > > Cc: Mirko Ardinghi > > Signed-off-by: Fabio Aiuto > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx93-icore-mx93-edimm2.dts | 356 ++++++++++++++++++ > > 2 files changed, 357 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 045250d0a040..d26c0a458a44 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -226,6 +226,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx93-icore-mx93-edimm2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts b/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > > new file mode 100644 > > index 000000000000..75cac97d919c > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > > @@ -0,0 +1,356 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2022 NXP > > + * Copyright 2024 Engicam s.r.l. > > + */ > > + > > +/dts-v1/; > > + > > +#include > > +#include "imx93-icore-mx93.dtsi" > > + > > +/ { > > + model = "Engicam i.Core MX93 - EDIMM 2 Starterkit"; > > + compatible = "engicam,icore-mx93-edimm2", "engicam,icore-mx93", > > + "fsl,imx93"; > > + > > + aliases { > > + rtc1= &bbnsm_rtc; > > Missing pace before = > > > + }; > > + > > + bt_reg_on: regulator-btregon { > > + compatible = "regulator-gpio"; > > + regulator-name = "BT_REG_ON"; > > + pinctrl-names = "default"; > > + regulator-min-microvolt = <100000>; > > + regulator-max-microvolt = <3300000>; > > + states = <3300000 0x1>, > > + <100000 0x0>; > > Misaligned indentation > > > + gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>; > > + regulator-always-on; > > + }; > > + > > + chosen { > > + stdout-path = &lpuart1; > > + }; > > + > > + reg_1v8_sgtl: reg_1v8_sgtl_regulator { > > Do not use underscores in node names. I am pretty sure you got this > comment before. > > Also, you have confusing naming scheme - sometimes prefix reg, sometimes > regulator. Keep nodes ordered. thanks, will submit a v2 patchset kr, fabio > > > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel