[arm:zii 20/80] drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used

[arm:zii 20/80] drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used

[kernel test robot]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm.git zii
head:   151b88b21c8ef27598749fb5f240a15a32bef669
commit: 055235891082f2adc943a9f7abfdd4931b6a1911 [20/80] net: dsa: xrs700x: provide own phylink MAC operations
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240418/202404180634.GZNTrBPU-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180634.GZNTrBPU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404180634.GZNTrBPU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
     714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~


vim +/xrs700x_phylink_mac_ops +714 drivers/net/dsa/xrs700x/xrs700x.c

   713	
 > 714	static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
   715		.mac_config		= xrs700x_mac_config,
   716		.mac_link_down		= xrs700x_mac_link_down,
   717		.mac_link_up		= xrs700x_mac_link_up,
   718	};
   719	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [arm:zii 20/80] drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used

[Russell King (Oracle)]

On Thu, Apr 18, 2024 at 06:26:42AM +0800, kernel test robot wrote:
> All warnings (new ones prefixed by >>):
> 
> >> drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
>      714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~

My testing did not produce this warning, so I'm guessing that by default
the kernel does not build with this warning enabled - which seems to be
completely mad. This is not the first time that this has happened... and
it will not be the last while the kernel adopts this policy.

Your follow-up email shows that there are other warnings which will be
spat out with W=1 which will make spotting one new warning difficult,
so this isn't the answer either.

I guess we are now completely reliant on the 0-day robot finding these
cases... which sucks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [arm:zii 20/80] drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used

[Russell King (Oracle)]

On Thu, Apr 18, 2024 at 09:20:42AM +0100, Russell King (Oracle) wrote:
> On Thu, Apr 18, 2024 at 06:26:42AM +0800, kernel test robot wrote:
> > All warnings (new ones prefixed by >>):
> > 
> > >> drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
> >      714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
> >          |                                     ^~~~~~~~~~~~~~~~~~~~~~~
> 
> My testing did not produce this warning, so I'm guessing that by default
> the kernel does not build with this warning enabled - which seems to be
> completely mad. This is not the first time that this has happened... and
> it will not be the last while the kernel adopts this policy.
> 
> Your follow-up email shows that there are other warnings which will be
> spat out with W=1 which will make spotting one new warning difficult,
> so this isn't the answer either.
> 
> I guess we are now completely reliant on the 0-day robot finding these
> cases... which sucks.

Double-checking, yes, the build is clean and does not spit out the above
warning. However, building with W=1 spits out around 5.3k of warnings,
so needle in a haystack, especially for a subsystem maintainer who may
have to touch a lot of drivers (like I'm doing.)

I guess we just have to accept that mistakes will happen, and there's
no good way to do a build-test to pick up on this kind of issue, and
just generate fixes as and when the 0-day kernel builder finds them.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel