[PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

Remove it to fix the following dt-schema warning:

ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
index b11d694b98e1..d241db3743a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
@@ -144,7 +144,6 @@ &eqos {
 	pinctrl-0 = <&pinctrl_eqos>;
 	nvmem-cells = <&ethmac1>;
 	nvmem-cell-names = "mac-address";
-	phy-supply = <&reg_baseboard_vdd3v3>;
 	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-id";
 	status = "okay";
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[Laurent Pinchart]

I don't have a SoM so I can't test this. Paul, Umang, Kieran, could one
of you review this patch ?

On Wed, Apr 03, 2024 at 11:08:31PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.
> 
> Remove it to fix the following dt-schema warning:
> 
> ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> index b11d694b98e1..d241db3743a9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> @@ -144,7 +144,6 @@ &eqos {
>  	pinctrl-0 = <&pinctrl_eqos>;
>  	nvmem-cells = <&ethmac1>;
>  	nvmem-cell-names = "mac-address";
> -	phy-supply = <&reg_baseboard_vdd3v3>;
>  	phy-handle = <&ethphy0>;
>  	phy-mode = "rgmii-id";
>  	status = "okay";

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[Umang Jain]

Hello,

On 04/04/24 8:51 am, Laurent Pinchart wrote:
> I don't have a SoM so I can't test this. Paul, Umang, Kieran, could one
> of you review this patch ?
>
> On Wed, Apr 03, 2024 at 11:08:31PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@denx.de>
>>
>> Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.
>>
>> Remove it to fix the following dt-schema warning:
>>
>> ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#
>>
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
>> index b11d694b98e1..d241db3743a9 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
>> @@ -144,7 +144,6 @@ &eqos {
>>   	pinctrl-0 = <&pinctrl_eqos>;
>>   	nvmem-cells = <&ethmac1>;
>>   	nvmem-cell-names = "mac-address";
>> -	phy-supply = <&reg_baseboard_vdd3v3>;

Is this also applicable for &fec ethernet node  (since debix-som-a has 
two ethernet ports) ?

As far as this patch goes,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

Tested-by: Umang Jain <umang.jain@ideasonboard.com>




>>   	phy-handle = <&ethphy0>;
>>   	phy-mode = "rgmii-id";
>>   	status = "okay";


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[Fabio Estevam]

Hi Umang,

On Thu, Apr 4, 2024 at 3:19 AM Umang Jain <umang.jain@ideasonboard.com> wrote:

> Is this also applicable for &fec ethernet node  (since debix-som-a has
> two ethernet ports) ?

The fec node can accept 'phy-supply'.

> As far as this patch goes,
>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>
> Tested-by: Umang Jain <umang.jain@ideasonboard.com>

Thanks for testing it!

Cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

[Shawn Guo]

On Wed, Apr 03, 2024 at 11:08:31PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.
> 
> Remove it to fix the following dt-schema warning:
> 
> ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel