From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE099C4345F for ; Wed, 24 Apr 2024 15:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Ye9IvCoMTAU9GOX71movSJtF+bGsQIQq9k14DbxoWo=; b=3iYhmMUiUshXsv /hgPn2kMZupdKB94hYLOG3fCdD+/zrpUvwNhtKwLnzYqjqC9pLwOrCQtjRohiJ7PRAjRHBYleFJnh D2RcCzQyJnUJ35z0IR5rgU27H47sm1FLpQHNEo+6RnL/E51+qCD0UM+uJkLNVb3ETmYN/AXmli/Xv YiRJZPcClJItbt6jLvX6LKIMxURF8Mfi/jnuxjLdj4fK1Zlsnq3+ZOvwr7UsDQgTsmFLkvVWl7hYH 14RTy6zM2BvZ54xCanFK6+4qIZVuwSQbd6FAwckQ7wJ+CauAtE5hr8ptS5Ii+o6QrUrW3wduuSJb0 HixsOFj2pdIyJY/lVeuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzevF-00000004pQE-1HuE; Wed, 24 Apr 2024 15:52:37 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzevC-00000004pOk-0I6G for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 15:52:35 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5e4f79007ffso4634296a12.2 for ; Wed, 24 Apr 2024 08:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713973952; x=1714578752; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rrg8wwpA92kjivH0TKg4TZtfTIvVrn3ddePAYWoa0qw=; b=TDcUQmYbprhcB6A8cg9MPn0gdAVVWh8H2ZYKbb1KZOs3z00/T2Tyj8ON1qxL5AvP3L DMd/QXnC8/HDpk11K8jN2rGWHG8WWhCZNPq7n1ro3eMQnocpTNqVvTpT5pboUyMqg1dh Cal7v4tvHF5CY4YMiylOI2PDsv52jLzETzRY5FC8ortXDhXRbXrf8/F46xq051mci2Lm pTLeT14teTVQqoduV0GQfbdhNfvB4OBTKnMhDiAxWn1P1UsaX4c7YZxIsFBGGW1Z4N7e hyd6Vs8loumQ/YPRq1901JbNfDCnHQoelUrvEkv9xr47DIpn5rmsxyo+tQf3uw42buz9 B1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713973952; x=1714578752; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rrg8wwpA92kjivH0TKg4TZtfTIvVrn3ddePAYWoa0qw=; b=LJ48EHGx88ooRbiWcvg8ejo20OxcGJCEXXpySMadzzxcAJ7zYoa6stB0sl5ofwdAMy HvKomZMeUHVMpnWUG/r7icM3CiDJBnBew4t/EnB+0CXgvM2MotH9VqRcJRhXin8JfHHj QaNCDEiABxkT5dmB6EaQRxGJkKGGmGNwVZupfsQV7PrMSYJn8Eqh9KJN1SKE+5fmkV0R 5cmSdxwbMUF92IYaXcqGPchsqihVXVUc1p4Z4b/Rcjrq5XhrNgTvuxvgrCjemBghkoAP dGz3X7H5jQlb4H7tK7ZyD4ecVlmrGu4OG95PK1p78QFDDhBd/nvr7cC7nmlhX9CtZL2O HFXQ== X-Forwarded-Encrypted: i=1; AJvYcCWVtafamjY96d4ylkyFfTD0JNxW5Flqu5GJR0R4wxMNtSCJl4dRVKN3ZRprMHWuSpP6A06h5NrtT4hiSLtIMxxCqWA/9oTSMXghKChWgIu2YAdSYpM= X-Gm-Message-State: AOJu0Yzmzas2oJeuaIPlh5tjeezYQonVP/z7nxhtmFwlpU8nDLLw/SFX 5yaMp9s/iHTtuSAkzYZFQ7dmWAJ7kVKtrpFQin+SYM/dNR+7ug56X19D4+PyR94= X-Google-Smtp-Source: AGHT+IFJz2davFxl/umAykqWCqyRrrGNTJwfxgAOiKqEZ16/Hd7Gt5Q+2HCcbgUlPTtL3ULXGxROYQ== X-Received: by 2002:a05:6a21:33a0:b0:1aa:6167:b6d6 with SMTP id yy32-20020a056a2133a000b001aa6167b6d6mr3249147pzb.42.1713973951946; Wed, 24 Apr 2024 08:52:31 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:e523:8f5:a4a3:fdaf]) by smtp.gmail.com with ESMTPSA id v22-20020aa78516000000b006f03a06314esm11614021pfn.195.2024.04.24.08.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:52:31 -0700 (PDT) Date: Wed, 24 Apr 2024 09:52:28 -0600 From: Mathieu Poirier To: AngeloGioacchino Del Regno Cc: Olivia Wen , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Tinghan Shen , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jason-ch.chen@mediatek.com, yaya.chang@mediatek.com, teddy.chen@mediatek.com Subject: Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing Message-ID: References: <20240424030351.5294-1-olivia.wen@mediatek.com> <20240424030351.5294-5-olivia.wen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_085234_187416_71980A05 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 24, 2024 at 12:04:54PM +0200, AngeloGioacchino Del Regno wrote: > Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto: > > Il 24/04/24 05:03, Olivia Wen ha scritto: > > > Integrate the imgsys core architecture driver for image processing on > > > the MT8188 platform. > > > = > > > Signed-off-by: Olivia Wen > > = > > This should be reordered before introducing the 8188 scp core 1 support= commit, > > but let's check with Mathieu before sending a v4. > > = I don't have a strong preference. > > With that reordered, > > = > > Reviewed-by: AngeloGioacchino Del Regno > = > Wait, no. Sorry. I just noticed that the commit message is totally wrong. > = > This is not a media commit, but remoteproc, and you're not adding support= for > image processing with this commit - not in media at least. > Also, you're not adding any imgsys core architecture driver. > = > Please fix both commit description and title. > = I agree. > Regards, > Angelo > = > > = > > > --- > > > =A0 include/linux/remoteproc/mtk_scp.h | 1 + > > > =A0 1 file changed, 1 insertion(+) > > > = > > > diff --git a/include/linux/remoteproc/mtk_scp.h b/include/linux/remot= eproc/mtk_scp.h > > > index 7c2b7cc9..344ff41 100644 > > > --- a/include/linux/remoteproc/mtk_scp.h > > > +++ b/include/linux/remoteproc/mtk_scp.h > > > @@ -43,6 +43,7 @@ enum scp_ipi_id { > > > =A0=A0=A0=A0=A0 SCP_IPI_CROS_HOST_CMD, > > > =A0=A0=A0=A0=A0 SCP_IPI_VDEC_LAT, > > > =A0=A0=A0=A0=A0 SCP_IPI_VDEC_CORE, > > > +=A0=A0=A0 SCP_IPI_IMGSYS_CMD, > > > =A0=A0=A0=A0=A0 SCP_IPI_NS_SERVICE =3D 0xFF, > > > =A0=A0=A0=A0=A0 SCP_IPI_MAX =3D 0x100, > > > =A0 }; > > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel