From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09569C4345F for ; Thu, 25 Apr 2024 09:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oIzfu1lW4dFBQ6aSCfENflkv1XzNmcNTkTZ0LLPgXIE=; b=B+tPZdRG3RXtj3 InD7XPbx7/+KlG4RjwIA6B4m7laoWUkeZn7p9xJcS9uE5BJO71GJVYS4rW8or4Il1/MaH7ftJtrF3 O+bfTfun9pKpFAanLzgiqv2UAKwwSf9sBV5glmBKF0u8YHgkOBJFqTMfvgh9HHI+jaqpawGKgKuua tJTJWoYNdTSaneEmWAwRAVzK9x2Acl4HsJPOQHq0qyzYPAKXjjFSsti45bqfqkqWkPpVY4W8/GCPH 7ose16V0o/PB7ZmFwScAG3U1ZfU4aM8scw+2PrjR8pWQeXFrpuv8Ex/rH88qXpWL1mwUTcjbo6NOI tLqBfhsT6MGsUVHYbbJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv1l-00000007Wo1-3NAW; Thu, 25 Apr 2024 09:04:25 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv1j-00000007Wmq-0DZm for linux-arm-kernel@lists.infradead.org; Thu, 25 Apr 2024 09:04:24 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 62DE161DC7; Thu, 25 Apr 2024 09:04:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A146C113CC; Thu, 25 Apr 2024 09:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714035858; bh=shrNbSpov1s6eEL8cOPectBeWnoWaBh+qGBrCjqo5T4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p8GF5ar9yLaskEOKuKkE9poD8VEe36ZHkjTlVnVHgaSkz7DvZcjv6zethmaP06dSV 6rBbkug81eIUCaB4yWzW02AZcrc5H5nEmFxszUNbpXodSB0G2EH2e6Qw4IecPeGcgz M6he4/IjFg8e9cVcbOa9kiIHrjBQU+zNPO5qcYNsnZMA/wHeJlscTozVjdyj6m60qa epETuoI1JvN/ZP8ouMkEqQMhu36MwX+7WVeJKhvT7pMnBnczcRGysJAshhqbaT9kLt 43FxupTvq16/kb7R67H6yqVftzmfYUnmrC8Q44z8LZhGWQ7IUkXJAAAYrjqt5odxUw lqB6qrNODZfRg== Date: Thu, 25 Apr 2024 14:34:13 +0530 From: Vinod Koul To: Frank Li Cc: Ma Ke , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dmaengine@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: mxs-dma: Add check for dma_set_max_seg_size() Message-ID: References: <20240423143205.1420976-1-make_ruc2021@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_020423_151381_38A4BB65 X-CRM114-Status: GOOD ( 11.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-04-24, 00:07, Frank Li wrote: > On Tue, Apr 23, 2024 at 10:32:05PM +0800, Ma Ke wrote: > > - dma_set_max_seg_size(mxs_dma->dma_device.dev, MAX_XFER_BYTES); > > + ret = dma_set_max_seg_size(mxs_dma->dma_device.dev, MAX_XFER_BYTES); > > + if (ret) > > + return ret; > > How error happen? > > static inline int dma_set_max_seg_size(struct device *dev, unsigned int size) > { > if (dev->dma_parms) { > dev->dma_parms->max_segment_size = size; > return 0; > } > return -EIO; > } > > Only possible dev->dma_parms is null. but mxs-dma is platform device, it > point to platform's dma_parms field. Look like impossible it is null. Yep, checking for the sake of checking is bad. It needs to be logical -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel