From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2839CC4345F for ; Tue, 30 Apr 2024 11:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+fs+oyuBo0B86BsKYhrgGJQdp8jn6QBdcm69G3thOyI=; b=Bj4mvvhEBlTEb5 mXr5vICpzgG3qgFWR1YTdc8uhqHDoNgbEcb8nVdoaxCOIGsU4VwQBdMftJgG6RE0p48HvdAUMl3lf M6uWPe0n9CnnM2x3qlv57oCjzyI5FTMW/v95Klm6q+jY6z39vwi8lys+F6JHzr64AdMtZLBYCa0sn MaXjBMU3Fh6A7JnWfEY2/JGQ7knL204dO0/aa2wCwGrDXGH/kcj4vqwK6yDs5OGvkzkx1mZvbd1Z/ bB2f1WisXEmWERTTfOTmmILLDqhoZxiLhL/lizcC88pHHr+bBP08gJGUn+vfeBzF7hPNbq9iq87fN a6ZH69jJnnSaMUcds9kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lZZ-00000006AJi-1n4X; Tue, 30 Apr 2024 11:22:57 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lZV-00000006AIw-401w for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 11:22:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B98A6CE0FF0; Tue, 30 Apr 2024 11:22:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8F41C4AF1B; Tue, 30 Apr 2024 11:22:49 +0000 (UTC) Date: Tue, 30 Apr 2024 12:22:47 +0100 From: Catalin Marinas To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Dmitry Baryshkov Subject: Re: [PATCH] arm64: Properly clean up iommu-dma remnants Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_042254_194198_B9180295 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 11:22:53AM +0100, Robin Murphy wrote: > Thanks to the somewhat asymmetrical nature, while removing > iommu_setup_dma_ops() from the arch_setup_dma_ops() flow, I managed to > forget that arm64's teardown path was also specific to iommu-dma. Clean > that up to match, otherwise probe deferral will lead to the arch code > erroneously removing DMA ops set elsewhere. > > Reported-by: Dmitry Baryshkov > Link: https://lore.kernel.org/linux-iommu/Zi_LV28TR-P-PzXi@eriador.lumag.spb.ru/ > Fixes: b67483b3c44e ("iommu/dma: Centralise iommu_setup_dma_ops()") > Signed-off-by: Robin Murphy Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel