From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF792C10F16 for ; Tue, 30 Apr 2024 15:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U6MCFjctoXFc+QvYtrIafOLxb/WzywB1PVUESiG1pBQ=; b=UINwtIjrtTyQGq kZ2vSPt4JCVLbQXfm0uS0RJIYjiGQ7Iqn5rbXtm02i+UG3a52i8iP3FotLL/ZAhaTIeej4n0wwV48 Oa0dAGTWgcRr+7Kd/leq0tnKMHeR8ZdRsBjEd7Yq2lcgiDf2jNxX8pkavQsI094JA1EOhV0zUDX+8 laT6Uz4CPmMD8fUpfOapn6XmGpA0fbbL30qwM37pEpxBI1qGyAZ9VVJ8r8GM0IBfCwOqQizpjEmAc QxLYAqKRER4A7JNdhyfCwr+TYiWfXqISlk8eWi1Dn74ECHpaFTbkiQ0N8+4E/cTq7S9uvErJy18Sk RVuNPYTIhT0MteI+SU0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1pjS-000000076lM-1N8X; Tue, 30 Apr 2024 15:49:26 +0000 Received: from mail-bn8nam12on20600.outbound.protection.outlook.com ([2a01:111:f403:2418::600] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1pjP-000000076jS-28Wp for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 15:49:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YG4lvQSGzQB0jSxfC3NalDnkbYROHYI7EROJzeiik1AO3AJHrwEMBzAoobs93C+d2047sWnMr8MK1pE5MIFqnwiTCgwGQWugUeQ2cFhvf4Hz2XbSbAkxsEMUA16/CU6rQ8fuczzGt493IakTp0cmwHBi2h7ea4nmttc2SuxrykTmn9Ion/e4CFdweHyq8mCOwnoH6gz2IYkJCgVbvIvBs2DEZZwD0KEHkZgFtava/K8hvzpZeFDZ+UyLeTuynhBUGKKf7jI1h2lzl649j4DGtBH/MzrsPR79548IPjhY/MKDE0Ap1b7578BfFJ3Ysb2WLGrEm9vjm8MfiwdxxcpCEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4qZJ3Mrwc+J32LU/rdosoEocgWE64O/Tq+9iq8Z4vf4=; b=CN1cejdQp3GtsATMIi1Ct+jaYkxsjBy+a2Mf6u2akPkz6VGlS2JF0qkcHipgMmGHQnuCslN5AGRO/XXhzXuGRaEw05DeY747RNgHlg7gqzqLnI6/5wLrmmYxPqPAmb4Gg1HusonXCuLv9+ZAFv3e5TiR7JCtzmghY2gvBol+ty8dV1hSvLdWwI/ri/HL/hFH+PiaTs9p+t8P1LhGO5VpQMmOMWi78jKM/LUFIVzHTJrBV2qiICac+TDMHj27YQpB9HAnmViaPLKumggASj7yJMVsZgz+LSczj38a9geffiLFBGXHvYqoJmvCDgzfvfOpe97455MnTFBS7Iv/70cpBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4qZJ3Mrwc+J32LU/rdosoEocgWE64O/Tq+9iq8Z4vf4=; b=R06xfWjQOxGGgPZljtq142Jny/HKgfX6mgydBvW8Hn5RXb9TF1sUOn2TKMOUm4yeWcVFkXza8RhLdBo+O+20nuaU9gDXoSVoiOKG3j92/DLJt3I8XLQzICcsKzQXZsQZlFkKKp1Q6dKZ9TWOeCO+D6HijAQKq5ZBT9Li4ZNy4jF2mhEgGql5v8BZgK0ZfasP+O3foU4QLWovfo6zgVttyRHeUMgQfCpnK1ZEvlSCLhIQO5IQVd03U1GcFO2L66LThV3eV8UYawdbXT0FOuNWLICLx9GQNuyZ08wbEk72HCVui7HN0MpmHDrKs11LhBI3f3EFVUtcjZROmlgwcHzioA== Received: from BN0PR08CA0023.namprd08.prod.outlook.com (2603:10b6:408:142::17) by IA1PR12MB8467.namprd12.prod.outlook.com (2603:10b6:208:448::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Tue, 30 Apr 2024 15:49:01 +0000 Received: from BN2PEPF000044AC.namprd04.prod.outlook.com (2603:10b6:408:142:cafe::26) by BN0PR08CA0023.outlook.office365.com (2603:10b6:408:142::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.27 via Frontend Transport; Tue, 30 Apr 2024 15:49:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN2PEPF000044AC.mail.protection.outlook.com (10.167.243.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Tue, 30 Apr 2024 15:49:00 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 30 Apr 2024 08:48:46 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 30 Apr 2024 08:48:46 -0700 Received: from Asurada-Nvidia (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Tue, 30 Apr 2024 08:48:45 -0700 Date: Tue, 30 Apr 2024 08:48:44 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , Subject: Re: [PATCH v6 4/6] iommu/arm-smmu-v3: Make __arm_smmu_cmdq_skip_err reusable Message-ID: References: <25150aec77edf5590bca81f4a418ef1ee7b21952.1714451595.git.nicolinc@nvidia.com> <20240430140600.GP941030@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430140600.GP941030@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044AC:EE_|IA1PR12MB8467:EE_ X-MS-Office365-Filtering-Correlation-Id: 99d2ee3f-5587-4f9c-f74f-08dc692d0dd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|82310400014|36860700004|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4TR8MlcGn+Q/USl73llWMwl2VHNAdlhdQnm0kDXETPckmzyRS1tDAhFjBQNB?= =?us-ascii?Q?sBg/WeqxvH3RGu5lvFPjx0COseNJitc62lnb4TpnrvB603+hjlaCxfnscski?= =?us-ascii?Q?qbTn/o72AeOCfkXVQ5xAj4uj9K1gDfAperwJbNwHcfewhIicdePnOjJ+lSAV?= =?us-ascii?Q?XppavcjH6x3gV8amtxoRhYzZyfdShL/30eq+BioVhNFJdJYxUnm7K8IDZ3fR?= =?us-ascii?Q?45Dwt1z+rwqsATr+JPHK1Uh9OvTVMk26glt9ttx7E235lej2OYgeAcAUffUc?= =?us-ascii?Q?N68KAJwGsxQV6+ntoERt3wfYahgr/vMUU/CBsKZrnX7dlX3Yux5QQSqUd6Wp?= =?us-ascii?Q?l0bwDKNKmuyLgJipYvTRf3lxJCZCEaOILLykedtqtmhNksRs1vZbnQEWpXUC?= =?us-ascii?Q?XFb+6T8FdCriKh/7KR9dNQPTJfcoh4jakLb/H8gLItbECsfxaHTpeXLoA9ba?= =?us-ascii?Q?Yx/4GBQv+cjy9wUhMjKojsIDvCdBNJqqmVKz6TbzslldgXTzcdQPucWkH6O4?= =?us-ascii?Q?OZcESBFqgSAVPZa9KofQ7xmVXrR7OOtU1D+wQMG6Tgqi8fnc1RKXm3JZ9OBV?= =?us-ascii?Q?K4Zpbrhixov2G0Xl1l9Q5cTjK1LAlqLUOOIAQ6aawyDUIP+F4YSzoXvc6L5c?= =?us-ascii?Q?z+Zw/dEsASfLjeFAA3G4Nk5vEmIcIPVmXMOb4AoZrfKjvzYHiR7KV1F1zSwU?= =?us-ascii?Q?oiDQW82jtiOgYE/kgFvwFLhiejFaM1e5mEFRgKYRBUtUqNzob5BPFHdKmjld?= =?us-ascii?Q?a72gaSmFFQt69hRTGSUG/kkRTynNGcpyosMkoGbCUqqot+FOAeczYfJe23dl?= =?us-ascii?Q?RoWQkCPYa3D/Vsnx59fYjzuNzAAy8YP+2lah/fFNcyeKpYqMzIrC3j+NAeuh?= =?us-ascii?Q?1quvUIyuENtm5W0Eoeg3lIfaqxjYZBJ0taq4DGx3Q73aNxFQF2ZhXu8wyS8e?= =?us-ascii?Q?BZzMI9ECDFuicC5acK8cBwfMRTckx906ZfQuBjH4YPmjWh3RGQfqzHmqdtGS?= =?us-ascii?Q?L9XKkPA+fSPWannVOyjCUy53frgjaElqLm0apCzwgcJpjlXw2cgcjuIc0JNj?= =?us-ascii?Q?LqGNVnVFg8jGjsGbikSSqefhY9WRTwaBBsk5lJiFtBOH2NbT64woeT/BNZnY?= =?us-ascii?Q?mPa1mS5H3aZy2nfdiOyoyCrQ2FSe2ngajZIKH4CR8rwObe6p/x0pTZbzQ6gf?= =?us-ascii?Q?jNORhwVlobEedZS5FiYGWH48A3c/F9An05rhch0YfscRTT8pKx+KKf3YJnXl?= =?us-ascii?Q?6JqkQwTQ2FcxyPf8A+29YM6IhP31+iOBleg335aoog5Y5TvtyFhf0QUS5zBW?= =?us-ascii?Q?Tn3BZZkWNbar2uVapppVB3vcTozXsdPrmtXOsGB+Z3D7eCUA7VJPyjbjDqq8?= =?us-ascii?Q?QYS9F7bKRiIXAT7peQhrQEpiedg5?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 15:49:00.4176 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99d2ee3f-5587-4f9c-f74f-08dc692d0dd3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044AC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8467 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_084923_579510_5F5F296F X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 11:06:00AM -0300, Jason Gunthorpe wrote: > On Mon, Apr 29, 2024 at 09:43:47PM -0700, Nicolin Chen wrote: > > Allow __arm_smmu_cmdq_skip_err function to be reused by NVIDIA Tegra241 > > CMDQV unit since it will use the same data structure for q. And include > > the CMDQ_QUIRK_SYNC_CS_NONE_ONLY quirk when inserting a CMD_SYNC. > > > > Signed-off-by: Nicolin Chen > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 +++++-- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 2 ++ > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > index 538850059bdd..5111859347d5 100644 > > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > > @@ -379,8 +379,8 @@ static void arm_smmu_cmdq_build_sync_cmd(u64 *cmd, struct arm_smmu_device *smmu, > > arm_smmu_cmdq_build_cmd(cmd, &ent); > > } > > > > -static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > > - struct arm_smmu_queue *q) > > +void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > > + struct arm_smmu_queue *q) > > { > > static const char * const cerror_str[] = { > > [CMDQ_ERR_CERROR_NONE_IDX] = "No error", > > @@ -428,6 +428,9 @@ static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu, > > for (i = 0; i < ARRAY_SIZE(cmd); ++i) > > dev_err(smmu->dev, "\t0x%016llx\n", (unsigned long long)cmd[i]); > > > > + if (q->quirks & CMDQ_QUIRK_SYNC_CS_NONE_ONLY) > > + cmd_sync.sync.cs_none = true; > > This hunk should be in "iommu/arm-smmu-v3: Add CS_NONE quirk" ? Oh, yea. Will move it. Thanks! Nicolin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel