From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F367AC4345F for ; Tue, 30 Apr 2024 15:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V2ystT3JuY45ZTy9tn77p0J+EbkhOD1yyFCy8g2FhRI=; b=cKsZ9hn7bNNtjp nMQFhxJmASFRF1RBYPOYRQgCOG/ISHMFaRSRVXJs4OzhdCH/JwxZO9rT9QuOcCGeU2DevT9HufyAQ EJc82hFx7S6c0QZmCPAgWHQ+SH6TEugs/iHZFo7gGx1ytfpHFS1r3ZZVnlXIyOHrJFUcboFpPu2pm F6vE/L4Gb8vN0qPwapeQPl9UdkKgBnKieANCPOXNn6ft2Ry9LVPOssz2yV1KDgKJc0d1RRN0xnZ91 8yTr4+9EQjTFIMokOVmjvMfQ9v63LGtx03YLqod4VKklW7usnCbQ2Q+9B6aMII8NP+ENpRw1BCZci RMUsWDdxySifGmTRX0cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1plX-000000077Je-2yFE; Tue, 30 Apr 2024 15:51:35 +0000 Received: from mail-bn8nam12on20601.outbound.protection.outlook.com ([2a01:111:f403:2418::601] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1plU-000000077GP-1tG2 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 15:51:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyCzK7+N8ovX5oUCNXSxxFfP5cYSj3//HIXLtP/Fg0v4PDrEfIM7ZQpn9IFGZIPl1EmhSeWygW6T5WCjlL2biIEMVKQffcivN7ob9l/u3zqO518B77SWfoWXYW5KF3RgYeLIF71h6vTgI1WVmho2NrA6bZoUV1BGDBC3hRQHENNY8rvX1P3Xht8pbU+4EriJL/GceZKo21Wsb67CaVD/Jqd+fnaPq1cmb+Df4avVlAbBY4vnakIsrUEypHsh90Qk5TTMloKSItFf9e2GfVwAZG4jfFmPFkWwPvvpvJUiuriiRxwT6lEacDvnGWuj0hy/gJzThTK8C4Zr1YcZcWYihw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YcTCn8yUypxOhtpAqrSckzopxqTmDsIOOh8CyAUFtmc=; b=JRvzIPm9EmwI+64fhfZTbV82gfzIpJlVtMg7fZmk7/7MWCxnMfMQkYei+Y5w+bK/fqbappB4iPxRviS++QUpfsBTJKblfEFP6mT3Z2R0I8VZsTTedcbY8DTgimrhmopXIHwUNBC+BnjiHPJHB8AqTH/0ENWgGzPaHxx4r0o39QPFNP12CIcp9u30bhC1dLGtAsJvV7x6MxYcxxX/ryiDPAy63kPy0VMu6IuVQiMESA/+JZJ8QNJoyxkkYjJUXXe3oPxRg4K0UBi+EI2u6HowcgHWqLKdOLw6gION/TWgWMbwDActl0wbh8UjV3QLjju6/YwIQY/oUBZo1SxOv2NyUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YcTCn8yUypxOhtpAqrSckzopxqTmDsIOOh8CyAUFtmc=; b=kF0d8B9b8ISdXHkGPLLiRoM3/ty/LFWW84c+XKm/ApOiAyd1M6161c93rDIEZCyHDtLRem3n+t9vNZb95/Ch48kbYdggdvY+ep/ZVIepyjqOKOsZxNR+75cxA6AkbUj2bNzacSfluxW/uq9HRpjHqtMlFjJNUfMuistqP0YFeKFVn2T7Gd+mNG7vc3OE/TsLfsUkOxlJiL0YsvbmjBp/1LhaeyJiOCrXHelR/4yG+5IPZkDQ15jp4wWvjgUOet5HhN3QJUUytnxd6QGR88aK1r0jxtAHgZYxureZS0dU5LxpTj/KIzF2iE2pdo95knNKDeeJvm0E5BZNEtd/L6KHZQ== Received: from PH7P220CA0103.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32d::29) by DM4PR12MB6566.namprd12.prod.outlook.com (2603:10b6:8:8d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Tue, 30 Apr 2024 15:51:17 +0000 Received: from SN1PEPF0002BA4D.namprd03.prod.outlook.com (2603:10b6:510:32d:cafe::e4) by PH7P220CA0103.outlook.office365.com (2603:10b6:510:32d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35 via Frontend Transport; Tue, 30 Apr 2024 15:51:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF0002BA4D.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Tue, 30 Apr 2024 15:51:16 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 30 Apr 2024 08:50:56 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 30 Apr 2024 08:50:56 -0700 Received: from Asurada-Nvidia (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Tue, 30 Apr 2024 08:50:55 -0700 Date: Tue, 30 Apr 2024 08:50:54 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , Subject: Re: [PATCH v6 3/6] iommu/arm-smmu-v3: Make arm_smmu_cmdq_init reusable Message-ID: References: <47a2ec844ec42694872d3c3b1a09f1b870712f78.1714451595.git.nicolinc@nvidia.com> <20240430142408.GR941030@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240430142408.GR941030@nvidia.com> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4D:EE_|DM4PR12MB6566:EE_ X-MS-Office365-Filtering-Correlation-Id: 51c59e82-024c-4651-7989-08dc692d5eab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|82310400014|36860700004|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?s9KXutjuBu8TIxSQRd9XuStoSzOCxLdn5OclUxRaJsZCx5gfN52gSPpsNC1y?= =?us-ascii?Q?du60YQH30o0wDoMi/9fJXhYzVyBADY62/KkzO7HQUaODcZTuTFybNi//1XIJ?= =?us-ascii?Q?t0Vyh8hdYbQ7iBExith8hPaQ1Jnxl4ZBLeDlUv23pl+YeSSxJ/gEgsM4M6fi?= =?us-ascii?Q?pQDlBYVT1MrgrntkOHhke4Na1Xdm8h1ePJcgaXard82fPgpUREfmzf46AnTl?= =?us-ascii?Q?16RmjeZlG17w3n/INpnADx4IY5eC/rYUotsA5LVV1i88sS7MYU2U/g1H0JBZ?= =?us-ascii?Q?ZjgYjlwPazI4VbWUmuJvRQgLNgoFJ0+G2jgZKizosAxtT6bpZqoM24aYFmzF?= =?us-ascii?Q?jB7VBU/oP+3yFailkE8navCZDs+AW60T9SniyZCYbPgo3VmPmutYJljZbLoI?= =?us-ascii?Q?fk94bMKJmRZuTOctKtvJutdzHwHPf7wvd5IVY26bDMXXmoIaoaUxx/ZRIP97?= =?us-ascii?Q?EfLQFi1PlB5GiJmrDGy7XdjkhOYq3v97wOZGAFctCWi1R3gHPAvOtPO1d2EK?= =?us-ascii?Q?4mTM6952IYQiirYi1cZRt4Jd2xsHGI5kyiA3VmtB8PYjQmdccudAmBLHzHNu?= =?us-ascii?Q?4wQ8TYIaAd41jn3ZdFXFQUOnMxbnI0mm/NBnxbAIobM7Vb9SLKDj6z8X/av6?= =?us-ascii?Q?1a+G6+tcklmRijX7inH/o/wM+/rPuWTpoN8caBECnIv5J5UFabOnogSiMi19?= =?us-ascii?Q?/lj1V+iRInpCWO+DCuQ1d5gVHeXneOBFt+H3rHAMWkbPzxujpxnBWMEEMUhE?= =?us-ascii?Q?8W1/6Rgj2IXT/7eSzbSdoqIqBoicWqhqd8qQYo/uHRvJ1/Oh+AmlrmJhcLPN?= =?us-ascii?Q?VQB5OOXHG2u4fl8XiK08k3TtoSAZmMWnYHTJ0TL5aynz/rwEJAZE1R1V+vhh?= =?us-ascii?Q?vEHEVHD8NsiL4+WJ4ka0LDWJtGoXfu85xQontIhsUQzG52Nx3Vcd+E8jaEGR?= =?us-ascii?Q?a/xRXkI0GPe5PQmuHbKkRRHMLnwCP5imKvxnAirDMCgB5dnnYl5sYDq4jX63?= =?us-ascii?Q?/W9RQQ6CAh4X/YkUKnFuRf3VpvuKBdbhBU6dnQMDqcEa5Vnu63EjKXTIRp1+?= =?us-ascii?Q?aF976UQYKzCI+SPf9pTZif8WtMg/dtnKchg1LjRWYy7YCVd46tPaAcrJq4CG?= =?us-ascii?Q?MwysqRestWXn/PuDsdZn4FFZz1+9RUgvRB5y4ejMT75r9HLEr/FAsD1ZjBsA?= =?us-ascii?Q?UQ0UGulT+LVT19i2iXXaX5zJsJCkDoWXPRfSpis8Lp1RPySYuGkh8l6EICxJ?= =?us-ascii?Q?BRYBMA/nIOyUAwIE5urJMx140tD3Ws6cL0ABpIF63xRpUGFOa7dLvfVUXM6n?= =?us-ascii?Q?GoXL6z1kun+oANFySroy4DYpcOYsoQWgOhoz5Sedtlm6D2Z2yGFoTZE/7Jb7?= =?us-ascii?Q?H1tQlqe6iwWEduONuXpeBfIHadHH?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230031)(1800799015)(82310400014)(36860700004)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 15:51:16.1258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51c59e82-024c-4651-7989-08dc692d5eab X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6566 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_085132_757192_E23D3816 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 11:24:08AM -0300, Jason Gunthorpe wrote: > On Mon, Apr 29, 2024 at 09:43:46PM -0700, Nicolin Chen wrote: > > The CMDQV extension in NVIDIA Tegra241 SoC resues the arm_smmu_cmdq > > structure while the queue location isn't same as smmu->cmdq. > > > > Add a cmdq argument to arm_smmu_cmdq_init() function and shares its > > define in the header for CMDQV driver to use. > > > > Signed-off-by: Nicolin Chen > > --- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 6 +++--- > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 3 +++ > > 2 files changed, 6 insertions(+), 3 deletions(-) > > I would squash this patch and the next together: > > iommu/arm-smm-v3: Make symbols public > > The symbols arm_smmu_cmdq_init() and __arm_smmu_cmdq_skip_err() need > to be used by the tegra241-cmdqv.c compilation unit in the next > patch. Remove the static and put prototypes in the header. > > But the code is fine > > Reviewed-by: Jason Gunthorpe Then, arm_smmu_init_one_queue could be moved to this patch too. Thanks Nicolin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel