From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D94FFC4345F for ; Wed, 1 May 2024 07:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hD/GNEyVgJmtKq08Lz+qEKYSLdu6ot5SiSImdzAoZfA=; b=D0IrcbHdH+nuOb SdRBklBOKnYOl4R1zbkrhtZ+5UiSPNQ5sykd1Jr7cU9TLanXfYjpiL2YJ+P9lvbD0e3fol89MWCqp cHhwCa2u7e4DecL49DlQy58CuOOh/9x0memz1a6i6KKvS1Njp3lUAYKb5mLEgDF05aueJMyU/kScm vjOUweBIJPpslUzGyZSVERHDFZJMwmWsH5k+IQgp7yeTvObj2S6oZv6onjomY0AE8G6aZA2krqyzg TpgRoXTwugNU+4PTQ0VQPzgsJEz/Y1y2SNaA9nv7LM7GXrW/dp2zzDwE2BuHOWsdt2Vb5DCTigBu4 MUyl0nwM5C30kmkEJgSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s24RS-00000008kig-0Fhd; Wed, 01 May 2024 07:31:50 +0000 Received: from out-185.mta0.migadu.com ([2001:41d0:1004:224b::b9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s24RM-00000008khg-1d6x for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2024 07:31:48 +0000 Date: Wed, 1 May 2024 07:31:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714548700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sl6DYhZs4KcDMj2OuFfOTtj126Sqpmu4poaggNg8mUs=; b=WFVem5/Ci1b7QI5aBq7JA9nVh9Oa+2Qf1y8HBiBhp2DxvffdPV8c0K9PR6OoZ9s6Dcu0QW +koQu0s5YUjjMxQXskwVCqRmvnsfEfbtGD0NEhLT6xVaW5LfH2869kG3HQu0QZb/AUXbFz 02fgtQhtXJQMxLWYmLFu/2tVJ7iPmqI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Sebastian Ott Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Zyngier , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon Subject: Re: [PATCH v2 5/6] KVM: arm64: show writable masks for feature registers Message-ID: References: <20240426104950.7382-1-sebott@redhat.com> <20240426104950.7382-6-sebott@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240426104950.7382-6-sebott@redhat.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_003144_719101_22A216CA X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 26, 2024 at 12:49:49PM +0200, Sebastian Ott wrote: > Instead of using ~0UL provide the actual writable mask for > non-id feature registers in the output of the > KVM_ARM_GET_REG_WRITABLE_MASKS ioctl. Urgh, yeah in retrospect I think we should've constrained this to the registers KVM considers "id regs" (the space occupied by known registers or otherwise RAZ). > Explicitely set the mask for CLIDR_EL1 to make sure we present > the same value to userspace than before. typo: explicitly Also, we know the set of mutable bits for CLIDR_EL1 as it is handled in set_clidr(). The mask really should match that, since the UAPI is documented as "allowing userspace to know what fields can be changed for the system register" -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel