From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B147FC4345F for ; Wed, 1 May 2024 13:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=im04vVvqVMVQrl8xt/6EWMjUHHNr8HTICIjgZr7UstE=; b=lZ6+Tf5MdQ/tOL gz4mE+9RceccHqyNufro/srR7fyDvMUO6MTErqRAG3Ll2YHTOCHuLL3lkeqsXQsY93yRB2Bkdae1F MBKXEBPvrf9OvOz42fBd+klLORrYYkMg+kcaRO+hKxzhcg2p0MYORWA8V9A6wKruRRpxIzjzAvrzm Fgf3zvQiF2Uf+CJkeXnJ9wIT0Y17iCYmobHE5iu/va0CpHjcwrzGJiz3uxoKnm1mITwogiAuPWDGJ 98zczS1pAy/dZjRSLvYF99AwwxgRAAlNdOxZEyxvUsBwwfuRWltlBIsJuAHZ/u3a7tGsAfvrthITd asrxUjho2Zh79ymw/B3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2A8i-00000009h8c-1yiB; Wed, 01 May 2024 13:36:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2A8e-00000009h8D-3ruy for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2024 13:36:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E10912F4; Wed, 1 May 2024 06:37:13 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBB9F3F73F; Wed, 1 May 2024 06:36:46 -0700 (PDT) Date: Wed, 1 May 2024 14:36:44 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V2] firmware: arm_scmi: power_control: support suspend command Message-ID: References: <20240428075105.2187837-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240428075105.2187837-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_063649_031799_0F1613EA X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 28, 2024 at 03:51:05PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support System suspend notification. Using a work struct to call > pm_suspend. There is no way to pass suspend level to pm_suspend, > so use MEM as of now. > > - The choice of S2R(MEM) by default. The userspace can configure whatever > default behaviour expected as S2R, if issuing suspend from userspace. > > - The userspace needs to keep the wakeup source enabled, otherwise the > system may never resume back. > > Signed-off-by: Peng Fan > --- Have you tried triggering a suspend with this on your setup ? Anyway, LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel