From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63D20C4345F for ; Wed, 1 May 2024 16:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LPKCm4qvkZXJxyT97ScG7dmuqY7oMizUU+/38FC8ZLg=; b=b8l4DMm8Fw70ee RNxqeRDEwFCVB6SdRAN+fPWQ3edCQ8aM6PY/JTrlVU2kmg47fUBKCsEjWrTgxjH/F+Pc+gbbfPYqp FjD7KHZvTpqXX4sZ4+jg4CHp9LXmF08S0Wx6KCa8xk6hHb1gkhexWDoEOWK8Y4hKQolgoWSHBe0ap pN+EPh8jomfwsGs02JN3N5HR5GV1XvNbL3dFNsUdm1puwOw7DCcN39dldIJdhbQPdebxXbApq6vkO ZuSs9LTEkfVQELambO4wrxeNflpdn7RY6bbwAlmxVP1JFu/SDVWkC6ii57VagZ4A7FzgvLJX+Pg2V pWHoZjoWYApXdjMqDROA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2D9a-0000000ADNS-3amQ; Wed, 01 May 2024 16:49:58 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2D9Y-0000000ADMo-2x3l for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2024 16:49:57 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ec76185c0fso2195ad.1 for ; Wed, 01 May 2024 09:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714582194; x=1715186994; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cepHyqKwqWvx30NtahhDLdkap0UgBbDdcS3cIZcnbio=; b=erCz8ECohE3mGWkH+czBc8lFLqDb26HDsS3Ct2LF7gttto9RukDUjsjTzace1k7JRi 2GsZDg1VAO65xcVWj+9YfFZswG4jR3m5A8hLmpRsYcadrgjQZRoMa/mcxtEJJw206TSU 3Gl76yIIuNSb2qlOhfEdUxvLmqDplzSmht43JCdWxLc8Q5JS1WxoNWxt0RZWNsD4GpK6 28VwgE3B3qVg1RPYjeLLgb6WpIjcjbXl2Oka42y7vNNtZKeGUpmCKJdM0wH/94ozn75U 3JNvDl94E0DT4O7xm2m+6jkVBa+cQMmoP573UVm+iswxInqLmy2Ty2uRIG4/hMJvqH+v 3OKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714582194; x=1715186994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cepHyqKwqWvx30NtahhDLdkap0UgBbDdcS3cIZcnbio=; b=DI3s9tXzuK46+EWc5CBFQ/vM+8OEZfi3Hj+t4VNBPNqU6SXvDHx+BZX/NqWyNtEHyR /G5HDCRJuTj9gSO4PxKvidijirfNTeX8Dh7+6iRTYcqRt27YRtwm8FYyVLFdbXoGH9UC ZXztXSSsk/nkvdzvjl8spglj7NwRCLeWask+mjl+rOxNPEPv9d1oN+NAlcieZsv7I8tD 9ALe8ffbYAnwNAT3d7xjnqZLDvUH4LffJapO3gg1HNhozxQ1vO/BzVLRWjvLERYzLmlH txiG0NIOY1Xaec7nM0MtEv4If72Dm1Waf0ir45Cx9bVj/2lLqsZZ3Rx0V/Sm9NIHSTey qhAQ== X-Forwarded-Encrypted: i=1; AJvYcCXK7hOXHWSy0EPt5JS4lQ7jlcb8Izxj0IFcTiFHDTWx96H8Uu3mL8tvtMvumZUx50syca3HXAAZ9Fdc6wd5q63N/sEaR5Z9gzmeczC0V73yow8Hm9g= X-Gm-Message-State: AOJu0YxQ4HPZcjnpXAa7ZfPNB9ZIaAwvxOTGhZNlDbM7o/8Rz7KoFF70 756JjcbUQzGaZVCh8MFDzQc613bTusOlut4+u3VjCo2XR/yU4C/ppf3RwTqJnA== X-Google-Smtp-Source: AGHT+IHQqhtGtE9tvxLfm8Jh6wSQPY6ndh8+WXu/q2oaOTBz/QmJS5CUhGvF7oYJsnqJUozYFMpHQw== X-Received: by 2002:a17:903:22ca:b0:1ea:2838:e599 with SMTP id y10-20020a17090322ca00b001ea2838e599mr199000plg.17.1714582193896; Wed, 01 May 2024 09:49:53 -0700 (PDT) Received: from google.com (100.22.168.34.bc.googleusercontent.com. [34.168.22.100]) by smtp.gmail.com with ESMTPSA id db5-20020a17090ad64500b002a53b33afa3sm1576661pjb.8.2024.05.01.09.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:49:53 -0700 (PDT) Date: Wed, 1 May 2024 09:49:50 -0700 From: William McVicker To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Rob Herring , David Lechner , Bjorn Andersson , Dmitry Baryshkov Subject: Re: [PATCH v2] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE Message-ID: References: <20240426092616.4187022-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240426092616.4187022-1-m.szyprowski@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_094956_800070_1DD9A99F X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/26/2024, Marek Szyprowski wrote: > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to > module driver") this driver is instantiated as MFD-cell (matched by > platform device name) not as a real platform device created by OF code. > Remove of_match_table and change related MODULE_DEVICE_TABLE to simple > MODULE_ALIAS to avoid further confusion. > > Signed-off-by: Marek Szyprowski > --- > drivers/clk/samsung/clk-exynos-clkout.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c > index 503c6f5b20d5..e2968784d307 100644 > --- a/drivers/clk/samsung/clk-exynos-clkout.c > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > @@ -75,7 +75,6 @@ static const struct of_device_id exynos_clkout_ids[] = { > .data = &exynos_clkout_exynos5, > }, { } > }; > -MODULE_DEVICE_TABLE(of, exynos_clkout_ids); > > /* > * Device will be instantiated as child of PMU device without its own > @@ -237,7 +236,6 @@ static SIMPLE_DEV_PM_OPS(exynos_clkout_pm_ops, exynos_clkout_suspend, > static struct platform_driver exynos_clkout_driver = { > .driver = { > .name = "exynos-clkout", > - .of_match_table = exynos_clkout_ids, > .pm = &exynos_clkout_pm_ops, > }, > .probe = exynos_clkout_probe, > @@ -248,4 +246,5 @@ module_platform_driver(exynos_clkout_driver); > MODULE_AUTHOR("Krzysztof Kozlowski "); > MODULE_AUTHOR("Tomasz Figa "); > MODULE_DESCRIPTION("Samsung Exynos clock output driver"); > +MODULE_ALIAS("platform:exynos-clkout"); As mentioned by Krzysztof in v1, please create a `platform_device_id` table so that this is scalable in case we need to add other aliases in the future. For example, something like this: static const struct platform_device_id exynos_clkout_platform_ids[] = { { "exynos-clkout" }, {} }; MODULE_DEVICE_TABLE(platform, exynos_clkout_platform_ids); static struct platform_driver exynos_clkout_driver = { .driver = { .name = "exynos-clkout", .pm = &exynos_clkout_pm_ops, }, .probe = exynos_clkout_probe, .id_table = exynos_clkout_platform_ids, ... Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel