From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD1D7C4345F for ; Thu, 2 May 2024 11:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Prje6ettuXAeDUaSHbCI/nM1pa93+bXdxWyFj0NIpH4=; b=aYys9jjDc7V5am Np7AeWTSuToBSCwnwegzJKuNreNIeTU9eN1FP8Bs3SsrhZNMqnujRn78bKwnr7WRxjTWxUxLRR1Sq IPDCC+5egYY4XnmPmgXR1RktdBMvtfabv0DNR/SbbrFbbdzNq85Pr1M3sCRPP3WRjX0tcqGfraitk D8kRjqenHOC9BypXphHp/3l0u3IYaR8/0i2Y7V9lJVwmq2vAjGJFIDsp7TfBNHlHb0zxanuNJiFKB WRANfzgugu5uyUo8SYFxk5NXH1mQmpRlacWGRp/2L+XHnO9iFUtC7666QLIkYEIQDdM6po2ZA/p2L dsgjN+HuuHmT4FfAg6XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UJ6-0000000CSwZ-3iN9; Thu, 02 May 2024 11:08:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UJ3-0000000CSvC-2ldS for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2024 11:08:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RixZO4UNd5X+9/Eb+rJgRIgpftzrZx704xGqdwLo84c=; b=pguM2JIlPY0Lc+2Pu/lym4sSK3 TWl5G680QXe50eULZWlN4Q1SYb/H/CHXp+OQiaYmXz66j4fyKYuc5x95eoOJvIi9BUw4R4il6T2h9 kvb4lpNtvUX8lWYwSPjAsjk67d5ilLYgRRlsuyl0svGig0+JXblFpVkw4cjkk54FRq2VO2oWeTJmV b6twrDWplwXdeDBEKrp8iDtMY8QnW6Eg/7PYh8kz3V1TpEnNwupYR7vaVgt+W6MaOQcVtwk9n+DbN 9TJJF6tp1GvFeeK98mOiUs4nUwmy6paKBOLl0o8+6khTUn4BRFuHNi4bdS9jn2E/ZCK0rRvTTvOae iOfH5XSw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58980) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2UIr-0007CJ-13; Thu, 02 May 2024 12:08:41 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s2UIo-0003bE-5n; Thu, 02 May 2024 12:08:38 +0100 Date: Thu, 2 May 2024 12:08:38 +0100 From: "Russell King (Oracle)" To: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, Duanqiang Wen , mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clkdev: report over-sized strings when creating clkdev entries Message-ID: References: <560549ed7db5da2f2727dc053a5d196d.sboyd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_040853_721167_2A3B321A X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 09:22:39AM +0100, Russell King (Oracle) wrote: > On Thu, May 02, 2024 at 09:02:16AM +0100, Russell King (Oracle) wrote: > > On Wed, May 01, 2024 at 06:02:54PM -0700, Stephen Boyd wrote: > > > Quoting Stephen Boyd (2024-05-01 17:59:16) > > > > Quoting Russell King (Oracle) (2024-03-15 04:47:55) > > > > > Report an error when an attempt to register a clkdev entry results in a > > > > > truncated string so the problem can be easily spotted. > > > > > > > > > > Reported by: Duanqiang Wen > > > > > Signed-off-by: Russell King (Oracle) > > > > > --- > > > > > > > > Applied to clk-next > > > > > > > > > > And backed out because I get a compilation failure > > > > > > drivers/clk/clkdev.c: In function 'vclkdev_alloc': > > > drivers/clk/clkdev.c:182:17: error: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format] > > > 182 | res = vsnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap); > > > | ^~~ > > > cc1: all warnings being treated as errors > > > make[5]: *** [scripts/Makefile.build:244: drivers/clk/clkdev.o] Error 1 > > > make[4]: *** [scripts/Makefile.build:485: drivers/clk] Error 2 > > > > It builds fine for me. I don't get this _error_, and it's really no > > different from what it originally was - instead of using vcsnprintf() > > we're now using vsnprintf(). That should make no difference what so > > ever. > > ... and I've just checked, and it builds entirely cleanly for me. > > I'll merge it. It should be in tonight's linux-next tree. I also note... the kernel build bot never flagged the above, not even a warning for it, and it would've built the patch as it was Cc'd to linux-kernel. So my conclusion is the error you are seeing is somehow specific to your environment. Maybe you're building with an additional set of warning flags and -Werror? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel