From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD11FC4345F for ; Thu, 2 May 2024 09:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ObZ/bLjrIug1PdiBjsvXNtYfIdzwAxcgkZty/yEq4jw=; b=sj34az2frpNZSQ 5Unq2DtXFaGmLmm2rFe8d0ud6cMnb9/MIdnVuEsBmbUDgiIyF2Ci1t5mKOdrneENi4XTAiw1O2jHD d7uNxbXDMsO/STOiuVCsuTXsf9IuJwRs+p9PbsfT+Limg39P1SXicW4voRdNZQnEPMahAE5yQdYkh wImreaMkF5c/x8AdAzH5N6LpOGLIUjkdKn6eSHVrVFyf5N/h1XeRYYraciEeaYSSlX0mNYiYu+qBT WCzcav3Psr0JyggvQpU8/1Q36weIc6IxDUAytWXJUXhonEWyjv9QTXiKroLUMXMewqD/vNQ8QXS1R WVUT+oODo1QnYzYiLfXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2SU6-0000000C6PL-1mDE; Thu, 02 May 2024 09:12:10 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2SU2-0000000C6Lx-34dR for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2024 09:12:08 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a52223e004dso822514266b.2 for ; Thu, 02 May 2024 02:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1714641123; x=1715245923; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=XKBISEz5hivbFgsL9sOrWIy+M0J+RrEQV3Dl9y05i9U=; b=WhZCnVnca6gf39S/sSyf+QiF8FRicG4wAYPLwWwg2cDekXB2iKBsCIE8mT96/4rlUc nxwGQ7zFy4fI40X59rDuZRjVdzsfxVH4X3Yt+bGPGSyZxBIm099DqlYN60D/nlro76Cw L2YFfHjN31UMJFmS7A/vwslPkeBD+7ib5MljTkLcfBg7c0OnOqY3gXDErCILxqfE6Q5v cP/opH6Bx1NWFD2EKGiEzunrqtu6cwZ92bUPch7MqCjWTz8x/O5DC2m/vOWkxrxUzwtW tSWQj1bZudXzDm/84pW6kSfJclxNjghoIou/19DQn86tuc59SZNwY7kUnd4WaDDmC72u 734A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714641123; x=1715245923; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XKBISEz5hivbFgsL9sOrWIy+M0J+RrEQV3Dl9y05i9U=; b=HRRCO8FiaBeMdCj2N2q5kHXpB9mN/FjlLlim59S17irQsmZ19FvB38XwWousRx8HTn 6C7sxTV6MkcBOc4JtT/GZAPl2W9QyZDkGY8nW6MP8xeV4MBBu4P+Daqmv5xHJT5khOVP G2nJB9Jwl7oO8VpjtoctURYvpu1gHnemmGWOEwawQ728uxVTOt2MAO6iyfGGkRa1GTyt PV0RpEl6tknjLUnB1jkxxlj5KtM1ZQJ+Aow84NPXFGd9v0w92K9O0wdOwImM+GQFUKEd NkQUgRZA9hHuyWLNJB/gyD8NRIooiHXxZ6WQtabxw2mDcRG9Hfr+acEWMoqpvPRE6TK3 nXBA== X-Forwarded-Encrypted: i=1; AJvYcCUrRAWKO0Hyp+bZ5roepZTImzgNdPi2NYFXuxT/KRo685Q14tosaaVRcWuHXAVsLRFokVBNvyS/VNvoTRRVZtk1ItsECUL8rFnGxRit/h2unRpoAqE= X-Gm-Message-State: AOJu0Yx2dA10DUAMUfPIgkHDVK9erW6tPNBko+12ltiM1r993/lDUaBO +R3UXFj76LliAojr7NjmkRq0JG7Qo4B8w8JC0zIY/R+KLiRtXzxMjo5s7RsCv8E= X-Google-Smtp-Source: AGHT+IHQ6L475JtRROpjybMx/lyDKdF98v0PWXkxGP7wEay+2VSkVed/s8BZXiNF9X43dqxWFA0H2w== X-Received: by 2002:a17:906:79c3:b0:a58:9707:685b with SMTP id m3-20020a17090679c300b00a589707685bmr1128611ejo.16.1714641122948; Thu, 02 May 2024 02:12:02 -0700 (PDT) Received: from localhost (host-87-1-234-99.retail.telecomitalia.it. [87.1.234.99]) by smtp.gmail.com with ESMTPSA id p22-20020a1709060e9600b00a5887833da8sm315074ejf.81.2024.05.02.02.12.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:12:02 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 2 May 2024 11:12:06 +0200 To: Stefan Wahren Cc: Andrea della Porta , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Adrian Hunter , Kamal Dasu , Al Cooper , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Bell , Phil Elwell Subject: Re: [PATCH 0/6] Add support for BCM2712 SD card controller Message-ID: Mail-Followup-To: Stefan Wahren , Andrea della Porta , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Adrian Hunter , Kamal Dasu , Al Cooper , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Bell , Phil Elwell References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_021206_869103_C05379C3 X-CRM114-Status: GOOD ( 29.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:07 Sun 14 Apr , Stefan Wahren wrote: > Hi Andrea, > > Am 14.04.24 um 00:14 schrieb Andrea della Porta: > > Hi, > > > > This patchset adds support for the SDHCI controller on Broadcom BCM2712 > > SoC in order to make it possible to boot (particularly) Raspberry Pi 5 > > from SD card. This work is heavily based on downstream contributions. > since your goal is minimal Raspberry Pi 5 support, i suggest to use this > as the subject for this patch. > > Patch #1 and 2: introduce the dt binding definitions for, respectively, > > the new pin cfg/mux controller and the SD host controller as a preparatory > > step for the upcoming dts. > > > > Patch #3: add a somewhat reasonable (*almost* bare-minimum) dts to be used > > to boot Rpi5 boards. Since till now there was no support at all for any > > 2712 based chipset, both the SoC and board dts plus definitions for the > > new Pin and SD host controller have been added. > The patch still seems to contain a lot unnecessary stuff (Wifi, BT, > SPI), please try to remove as much as possible for the minimal support > (just boot via debug UART & SD card) in order to make review easier. Btw > this patch must be after pinctrl & SDHCI support. > > Patch #4: the driver supporting the pin controller. Based on [1] and > > successive fix commits. > > > > Patch #5: add SDHCI support. Based on [2] and the next 2 fix commits. > > Drop the SD Express implementation for now, that will be added by patch > > #6. > > > > Patch #6: this patch offers SD Express support and can be considered totally > > optional. The callback plumbing is slightly different w.r.t. the downstream > > approach (see [3]), as explained in the patch comment. Not sure what is the best, > > any comment is highly appreciated. > I don't think this should be necessary for minimal Raspberry Pi 5 > support. Maybe this should be addressed later. Thanks for all the feedback. Just a quick note to let you know that I'm working on V2 patchset that will fix all coding-style and dts/binding issues. The new patchset will be significantly smaller and I managed to remove everything that is not strictly needed in order to be able to boot an rpi5 from sd card. Best regards, Andrea _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel