From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19513C4345F for ; Fri, 3 May 2024 15:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vOZU5MqoZRRzf8myqVv2tcUs82Sc8p2ZzsMmy7X8SSE=; b=v4Uv66lzoxObSN KX5D9xwKA0avBKAPjsOHOFsD23hDDS2qd8e5/QBDy0n3YDiSSjktaQg35Dri3tWmBHJyNhrI+C1kw pMrtHE4vZ9NL+ybHvIx8I/moUnLUWTWO0UrIcRP7MLda1h7qEdLu3Z70i4oFy5aZ4rDmyYB6SSCkO 1T0DQ7+lRFK4muJAZbcFSSp3GYxlMSYhb21OSbGJHVQVTtdaL1kRb5CmI8Rn5QlO3aTFRjTU88WWb NbOaqCVXKeHk0XToKvmoIdR2nTbefkCzosSZfPzrom/wGvnqy0yjnmndofmkVvxDmsRVwNgx3ywJd 8vDxPBQsyrqn6FfvKfcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2ucY-0000000H0mH-1xjl; Fri, 03 May 2024 15:14:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2ucU-0000000H0ki-2BAp for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 15:14:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7FA9513D5; Fri, 3 May 2024 08:15:04 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.34.156]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 08C043F73F; Fri, 3 May 2024 08:14:36 -0700 (PDT) Date: Fri, 3 May 2024 16:14:29 +0100 From: Mark Rutland To: Puranjay Mohan Cc: Catalin Marinas , Will Deacon , Sumit Garg , Stephen Boyd , Douglas Anderson , "Peter Zijlstra (Intel)" , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, puranjay12@gmail.com Subject: Re: [PATCH v2 1/2] arm64/arch_timer: include Message-ID: References: <20240502123449.2690-1-puranjay@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240502123449.2690-1-puranjay@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_081442_621541_EC7B1723 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 12:34:48PM +0000, Puranjay Mohan wrote: > arch_timer.h includes linux/smp.h to use DEFINE_PER_CPU() and it works > because smp.h includes percpu.h. The next commit will remove percpu.h > from smp.h and it will break this usage. > > Explicitly include percpu.h and remove smp.h > > Signed-off-by: Puranjay Mohan Looks like this was a thinko in commit: 6acc71ccac7187fc ("arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs") ... which, as you say, should have included rather than . This is a cleanup regardless of the next patch. Acked-by: Mark Rutland Mark. > --- > arch/arm64/include/asm/arch_timer.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h > index 934c658ee947..f5794d50f51d 100644 > --- a/arch/arm64/include/asm/arch_timer.h > +++ b/arch/arm64/include/asm/arch_timer.h > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > -- > 2.40.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel