From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64D37C10F1A for ; Thu, 9 May 2024 12:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dgxJcLnHQyqdhYhY0KSX1gyIyHBZjvBoX3mLw7ioUJg=; b=5G97QD4bZjn0DnbTLUe6QeuhNw qPySL/tUbpujDZWf6Fw356KUYYglyhAXhzOjC23BFkZ4gRK/WVTchA2uyW4z7B2IHpP/9kxv3ExB+ WQAkXumV5aFHIntuF3K+P+ml+Ue66UIEZEPZfdaDnC1BajJ7zDkv3u1IzKrrwkxHrc/PpHYEv+Sbd 9vlOFQHzNq6qzzYkudE1elNbMVysgAVrHHyM/Qrt/kMBlz+vkfRREnQiCr/HUuewI6VbNoiJlpteN xcBeb/Gps3Oj3IsNWbp2N4VoPYTsp2HZbls4/BqyO9zi3H4NwDuBtLkXiwu51ZyaE8G4ArgMzGU3u dRDgfyvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s53As-00000001TdX-45ht; Thu, 09 May 2024 12:47:02 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s53Aq-00000001TbF-04Ou; Thu, 09 May 2024 12:47:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 12B84CE1B4E; Thu, 9 May 2024 12:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09D71C116B1; Thu, 9 May 2024 12:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715258817; bh=Y1puUf3Rn4PFEIfYWjo05C5VlGgGVxqEMZoIhApAwoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AQoXxdBT+Gf6/1FnwrPKEUEL8un/LA/u/2/sGpDCC3rxgKcoqyWXiIYW010ItlUum CLW5mYm545cimXqZBYmCGhgG0TDtnkqwrORVR4iSIbEqIRhyhcrt3kwfXNkXg6K64O w/OV3lp+KVg/vrgpg6Otpk5K6rEE7UjvK0+ZQ/3ke7FMj3+1HjaVBF4DAXoz4gPzwI 0n+UHl6L4pv6WqF0RUQ69KZCeD51zRNa7aM9mIiyeZyDaYmsZpsgrROCD8g6oq1W5t bWTjyIxOyJS//5RBCY/Nlq3g0oX9RTKZSdE+TICUdGYgN2wahiJLQ61bVw8OeIOqkv DvX0r1wcBJS5w== Date: Thu, 9 May 2024 08:46:55 -0400 From: Sasha Levin To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski , Joerg Roedel , yong.wu@mediatek.com, joro@8bytes.org, will@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 4.19 7/7] iommu: mtk: fix module autoloading Message-ID: References: <20240422232040.1616527-1-sashal@kernel.org> <20240422232040.1616527-7-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240509_054700_257896_00C268A0 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2024 at 01:39:03PM +0200, Pavel Machek wrote: >Hi! > >> [ Upstream commit 7537e31df80cb58c27f3b6fef702534ea87a5957 ] >> >> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded >> based on the alias from of_device_id table. > >This patch is queued for 4.19 and 5.15, but not 5.10. I believe that's >wrong. Heh, this is funny. It fails to build on 5.10: drivers/iommu/mtk_iommu.c:872:1: warning: data definition has no type or storage class 872 | MODULE_DEVICE_TABLE(of, mtk_iommu_of_ids); | ^~~~~~~~~~~~~~~~~~~ drivers/iommu/mtk_iommu.c:872:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] drivers/iommu/mtk_iommu.c:872:1: warning: parameter names (without types) in function declaration cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:286: drivers/iommu/mtk_iommu.o] Error 1 But not on any of the older trees. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel