From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A8C1C25B77 for ; Wed, 22 May 2024 09:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LV5uyRpITHjD+1vZwalYJR4a7suoDtAgZb4QybnccY=; b=D2GpcwOinKze0O 0eITSEK4V6CSvQLN1xjIHwvcgVXmZ208ecL4ySVbhR3bZw8M6oTzG+Uus0jo5KFafXZWLFzeSP8Sj 240q2ZcdMkx6LvD2wA0TaqEiehx/vMbJ2zKZ7dGwNE/BH6XzWb6gI4P/HR+g2rUI0T+3drp8wnNrq jWzIomZCnnLV5KTqxYkOzVKpPyHI0rTQ76LMIs5BJaaYV23vPNTUTpAFE9rq4sME1MP0hllLIhqxH YvY1ZZIAtA+C22k2dD4Pq4wzbJIyAhhjJ/wrbcujT1zMHI/g4agTyTa9e0De8Wj4VMwMv3b8R2y0A VikdSbaWVvAkI0eqKUeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9iMv-00000002W0T-2bDQ; Wed, 22 May 2024 09:34:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9iMs-00000002Vzs-1w9a for linux-arm-kernel@lists.infradead.org; Wed, 22 May 2024 09:34:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ULik29NBLPRrUwg+mqBvlx8JWj5pFQ0AbuABh1uIWo=; b=fW+q7v1eKF9i86BC7a3TFCWCJS pp4J5e5sVUH2nEndz39ojCjFGaOqyLglcpN9hTCtq91H9ePbGcWtzeseRil0LY5DHYUROa1VhFa8d DtObyI7YPh6BOgsEQN05gFjRG+50l9PR4gFiA7WOtRxOoJgaReLWE0WVFgG/Z1e0eK/V1bFESl0+6 UMKE1Ns3i2VsOQsgZF69Hnj4FVMZVnPMdspK7jIZyS/L9vtXR1XPKiA/Izbb5pYuDXjZ+FdNwgChw jzjQO9nZBwlQ3GoIp0qXB8gPYFCq+ScMReSX8kdfF9KszJMKIsghuRSLiHGzNi6UrUpLPRaiZivYS N57WdbAg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45380) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s9iMd-0004o5-3B; Wed, 22 May 2024 10:34:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s9iMY-00062c-TZ; Wed, 22 May 2024 10:34:22 +0100 Date: Wed, 22 May 2024 10:34:22 +0100 From: "Russell King (Oracle)" To: Linux regressions mailing list Cc: Guenter Roeck , linux-arm-kernel@lists.infradead.org, Duanqiang Wen , mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clkdev: report over-sized strings when creating clkdev entries Message-ID: References: <7eda7621-0dde-4153-89e4-172e4c095d01@roeck-us.net> <4ea9cc83-c7ca-47b8-8d43-dab16193108f@roeck-us.net> <646bd149-f29a-4c91-ab00-4f6d2fce23fd@roeck-us.net> <44151fe7-1822-4b95-8981-9a1f1884d662@leemhuis.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <44151fe7-1822-4b95-8981-9a1f1884d662@leemhuis.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_023442_596545_35C7AA4C X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 22, 2024 at 08:53:18AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > Hmmm. Communication problem aside, this in the end seems to be a > regression that is caused by a change of yours. Maybe not a major one > that is making a fuzz about, but still one that would be good to get > fixed. So who will take care of that? I have suggested several approaches to fixing it, and each time I'm being ignored by Guenter, who seems to have some other agenda - because he seems to believe that using dev_name() when registering the clk with clkdev is wrong... despite the fact that clkdev uses dev_name(). What I am uncertain about is: 1) whether clkdev is even necessary here, or whether it is pure noise. I think it's pure noise. Why? The dev_name() that is being used# to register the clk seems to be the _source_ device of the clock, whereas the name given should be the _consumer_ of the clock (when clk_get(dev, con_id) is called, dev is the _consumer_ device, and this is the device that dev_name() is used internally with.) Thus, if _that_ device is not the same as the struct device that is being passed to dev_name() when registering the clk, the entry in clkdev is utterly useless. 2) why someone would think that using best_dev_name() to work around this would be a good idea. One might as well pass the string "hahaha" when registering the clk - because if the device name is truncated, clk_get() is not going to find it. So, by registering it with clkdev, we're just eating memory for no reason. Therefore, this change is finding bugs elsewhere. Should it cause a boot failure? No, and I'm happy to make clkdev just warn about it. However, reverting the change means we're not going to find these issues. Why was the change originally proposed (by Duanqiang Wen) ? The reason was because of this truncation causing clk_get() to fail unexpectedly. I am all for a _sensible_ discussion over this - not one that seems to have an agenda about "should dev_name() be used when registering a clk" that seems to be Guenter's approach because _that_ is not the root cause of the issue and I've already explained that _that_ is not the issue here. Yet, Guenter insists on that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel