From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33211C25B5F for ; Mon, 13 May 2024 02:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uwyvAqNA9Nh8Vn77Sj+RZyQ0gMSW08gTnmSb96N5+PA=; b=VMXuCBk8VLUDWL 3AzHZ6ZcvcTUc8BTkwPKtuFSnEqP8OpzKOK2kbEvIJ0rFJNarsqfiSc2ReJnlEeVQ12LbrabvsvYv i/B4agci+Iko4j8HcbipODI8cCFOrwYkCewzgaj/KHqaMVptrNjnRu5glR4ks4teybpbadnKN2l36 WHoyQXMoci9eXYLyxDj14+ACNQCv1Odc5rVlGXRG3pzEQbz9/1pNSxf5Fr7xby1uYoe2K1iokbjX2 uPZJc3ChBQN8U/WtTatXnKNBBKsuvEDYVqCIWgfqm4rCImmcdZOjERE/9yr1i73FNcQtlBdf0a6xn nfwCqrRDcik1QH8LAFaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6LXd-0000000BPNh-3uqL; Mon, 13 May 2024 02:35:53 +0000 Received: from mail-bn8nam04on20601.outbound.protection.outlook.com ([2a01:111:f403:2408::601] helo=NAM04-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6LXb-0000000BPMD-1rgC for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 02:35:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMnfvcSxakQ6wFhyEzmZiuhIWNgzO/IrpTk2H+B32eAUV0acTus/7LR4wgEsD/1Ne3db/D5W2+pQkZxtQ8Z7aDMIkrzuDscEsYDSkD4+B1b416KwRS872HeUWcOqwH/RUv57jwMQE+TNzJlqgBodOwgc7m4jIQ57ZihGiINxHNcmG5pZoyZQznbk8cDb/wNjWJCqcSl4bNBeQKRW/ytf9InbmbtInkI0A02PyZS+QinFGXX3Wmiib4JwxBtwBSQLyQJHOUe7yeeciS3tzL3tXLedZKvME7EUOilnR93FTMqKG+kof18WDVDXUw6jMe3QojAnbSvIVvlJ3XTGhA9qhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNfcMMV6b/5wPVBaiduOYAEKqL40c3g7wsCrg0oyEJU=; b=U5M4/YXvv+WARyn5+laxn1pFvJDW/G3Twy/YjRoMOZAgT9ZqYuhYDSoxQhq2uJXSbb+wK14BaWhxkkgCY805sReHIaJDmZ/AZxQgCRRSoYuvLavuXUFM/i0UMYdEzHxqVkdhad9DGcabKHDK1KfGSVexRi4fzIBvnxiuWaVtQvogyUStrsGF2Oi1QZ2iTAgcpHOAP1zffb1PucJiR8/9eSr0KBbIvPQK86gptrGRhbcqJtZbiRSqcshNqtl6CfgJModw+trdXZNCKBcg56EILaRJlAwwHLNndIl0L3u5yO1uNHD4AQ35jjL7xmgEfdtzN+h9rA3RxapCxbyvkFH0eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNfcMMV6b/5wPVBaiduOYAEKqL40c3g7wsCrg0oyEJU=; b=d3Dk2NXiNLAAKrWOeOCmfH6tkXjrS8kdJFrTFtXFbOS5PHm0M7sMstqtiKJQafa3sDMDV+Zsg6tRM5idRFLDg2d4SqqlsCh24VB7jd41b3ovcNujgE2FNrsS3P4bwii8zVwkfrVToond18TOF/AyqTOwPOHCpWiCO+Xljtj3BRGXoxo52jVwfj5O71JyN5wkhiSBtw2ey+NeWnvcX5K18hXce6CXq9ateGna3sAR2OIvEs2G3vWEoJpSA3SBQN5Nb4oawgOCxFhm33C9tnG3fSWEKD1CEanR9llCSjGTdG4G49XezqPtPFR9fb+JRBb6Aisw4DzFotVTH4sa35Fcww== Received: from BYAPR02CA0043.namprd02.prod.outlook.com (2603:10b6:a03:54::20) by MW3PR12MB4396.namprd12.prod.outlook.com (2603:10b6:303:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:35:41 +0000 Received: from SJ1PEPF00001CDD.namprd05.prod.outlook.com (2603:10b6:a03:54:cafe::ae) by BYAPR02CA0043.outlook.office365.com (2603:10b6:a03:54::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55 via Frontend Transport; Mon, 13 May 2024 02:35:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CDD.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.21 via Frontend Transport; Mon, 13 May 2024 02:35:41 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 12 May 2024 19:35:39 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 12 May 2024 19:35:39 -0700 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Sun, 12 May 2024 19:35:35 -0700 Date: Sun, 12 May 2024 19:35:32 -0700 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH RFCv1 03/14] iommufd: Prepare for viommu structures and functions Message-ID: References: <734ef2f4b2b3e743e276d65f775062c5996064f4.1712978212.git.nicolinc@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDD:EE_|MW3PR12MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: f60b2eaa-c33d-4a90-81b0-08dc72f56203 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|7416005|1800799015|36860700004|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?N1CGhJYZhvFrmj1OEsW11Cvhx7E+aOw2P866hiWAi73IAKPR6W/sEvXd8ZGZ?= =?us-ascii?Q?f7jaT10OwbMzGeOkiU0YqW4AlYq7rXVPuks5iIhkQjMgO/7C/NjVSizxc1Fx?= =?us-ascii?Q?vlvZS3t7t8JxxXcdphMwF1Gqye60Ck6C8YMMPOw/Sc7ZRE6NNj382Jk5AqVs?= =?us-ascii?Q?1OG0kFc6mnB57CZoksdZAmApKzgahlO4UrJZNnWY1KvsOV/3LvREImOme/BR?= =?us-ascii?Q?vlMsRkEpAyjfHMRcG9aXneOozjiL+WmH14eEinXOudkUMw+Gy1iIXazH2wsR?= =?us-ascii?Q?fb8WsUTBQ19ipp+5mv8t8wmIsRWndOyTMKRxOwU2lkOntvGqHD8wm0dpaZgy?= =?us-ascii?Q?tUPOf9EqTqWVBMdcsJ4LGYtNTwoDofk0t+Ld+kwVTACPq1pxauYpdde6RwFt?= =?us-ascii?Q?WEwJ5n9gx6ODd/NNExSZ4Str8I6zJ0edCYmz6FKO/GLWhe1Tpex1M1v/m2kD?= =?us-ascii?Q?wrkRWZY0UNzE1ixW1mVUHgpmUi7NxPhGMCpc92t1JlUNxHASBrUEfDE4TqMy?= =?us-ascii?Q?w9Orh4/tDbLGTxYDtLSG6//1GP9QSu+Ei8sDA3Bp9d4yPEsRva3cMOFEwaU8?= =?us-ascii?Q?f+7U9/pNAH6ojmXkZYiomc3+LBmo/CGw0cxX1V/GeIGqwz0pCekEf9GyDgEF?= =?us-ascii?Q?UwhkzjA3tOPIHeYkwPaqs0oel1d7TEIHkw/2Cfrm/sD3gVWaEuC1dve2aaCQ?= =?us-ascii?Q?Ho26eCtt8/RXoWLjrEXkb+Bn5T+6zF/ZCALizqWd634mv8iP9hbBSuRuZNVi?= =?us-ascii?Q?rWQDtokrA5uvfXby3RmpDWfpuU5frBMo2qoWDP285EY6JIdx5Ajwy1EoEw8q?= =?us-ascii?Q?qr7X0W71agvmqDtj4gecYCmEQ7WB44sgXvHJe/mX0h4WdjzaXxd7uO+KHPc0?= =?us-ascii?Q?N5THP/Qyx/39kAX8fbh+Guqexh8MsHMjrjl1wU98GLgXSNKMCmntOcBlLSNN?= =?us-ascii?Q?Z3HVMmsBRrEspNCiL/ntFsavSUPp0AA+8JoejecxgPSkJSlokYHg0yX1wrl9?= =?us-ascii?Q?ygE6dyXyzOM0Q0qiyy1dJ9EBpmF1HotWarVAeQeiRHysuEOddKjDK3o2Xg5z?= =?us-ascii?Q?mfl79zNp1QigsA/XiEHlbQFM0QQKv/usQZkSHjptlOA2gHvUrx6Alob5/0uu?= =?us-ascii?Q?X+whszuJ1/ci7mNtkpsbrQBTOs51abpYw0rGc9aWk/als98tRXgI5+7AzSq9?= =?us-ascii?Q?6CVRQvyAGuUn4BF8Exe2lxooEpeGLAr0PDCMGrlNkYEm3XKa4vX+NrB9PqCW?= =?us-ascii?Q?FTQE7lBIuLbamZ8tUw9Imin29OJtOAuC6dA3aWKcMnDvLL2peZFbU7Uvh3J/?= =?us-ascii?Q?IpTe2mGQvA/2kHBlHG7FWceD7tsyvjSCnOupZRI5pARQvqp+LOw+GeM/EUB0?= =?us-ascii?Q?VaPNDeE6JTB4wjUUKCpnbqWMyxNn?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(376005)(7416005)(1800799015)(36860700004)(82310400017);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 02:35:41.6093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f60b2eaa-c33d-4a90-81b0-08dc72f56203 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDD.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4396 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240512_193551_517695_1A8480E1 X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 12, 2024 at 10:42:12AM -0300, Jason Gunthorpe wrote: > On Fri, Apr 12, 2024 at 08:47:00PM -0700, Nicolin Chen wrote: > > > +static inline struct iommufd_object *___iommufd_object_alloc(size_t size) > > +{ > > + struct iommufd_object *obj; > > + > > + obj = kzalloc(size, GFP_KERNEL_ACCOUNT); > > + if (!obj) > > + return ERR_PTR(-ENOMEM); > > + > > + /* Starts out bias'd by 1 until it is removed from the xarray */ > > + refcount_set(&obj->shortterm_users, 1); > > + refcount_set(&obj->users, 1); > > + > > + /* > > + * The allocation of an obj->id needs an ictx, so it has to be done > > + * after this ___iommufd_object_alloc() callback. > > + */ > > + > > + return obj; > > +} > > It is probably cleaner to just make the existing allocation work with > a NULL ictx for this case? Then we can use the existing alloc > functions. > > > +#define viommu_struct_alloc(name) \ > > + struct iommufd_##name *_iommufd_##name##_alloc(size_t size) \ > > + { \ > > + struct iommufd_object *obj; \ > > + if (WARN_ON(size < sizeof(struct iommufd_##name))) \ > > + return NULL; \ > > Then here you'd just use the exisint container_of based flow with the > driver sub struct name passed as the 'obj' Yes. And then we can probably unwrap this macro too since it's no long that verbose to duplicate in viommu/vqueue allocators. Thanks Nicolin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel