From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45498C25B10 for ; Mon, 13 May 2024 06:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A8qIrEfqxPKSdXSRXEwQ9PVXhkD+MMV9X+RHHpZ47jY=; b=Sx9dBkCHi5UR6l thZmrpX+vqYJM7xus8BHpFtSHEPqbA1HQTShtjcDvONhe8L2Pymr0cIRdt1FJLsdxLdC0pMouPUhZ O/WnqNWuSNDKABYvSnf4NWSCpeXJmfgYXYKU6Zc5ceUDwONzL49sM90IENJra40h8gryulwNFpxrQ iWIk5AqA7ufc+/tAjUUA9DbBPyyRFCPqxed+Kw1XVH7Kdvg04r+AbqsVH/ls9B2KwPk3D1n1RWTZK /BokDY2iDwFYR0q38GB7TS180FgW0XvUPRc9WoMWawKOrxNzpNkOS3//A2VrMhUTiKZcNEZ/Rqn7a trCMCFjNdFI5h57tCy4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6PaB-0000000BvqG-41lj; Mon, 13 May 2024 06:54:47 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Pa9-0000000Bvpg-3d9h for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 06:54:47 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6Pa1-0006sF-G3; Mon, 13 May 2024 08:54:37 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s6Pa0-0017VY-7p; Mon, 13 May 2024 08:54:36 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1s6Pa0-009O7G-0S; Mon, 13 May 2024 08:54:36 +0200 Date: Mon, 13 May 2024 08:54:36 +0200 From: Sascha Hauer To: "Peng Fan (OSS)" Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , Jacky Bai , Ye Li , Dong Aisheng , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abel Vesa , Peng Fan Subject: Re: [PATCH v2 03/17] clk: imx: composite-7ulp: Check the PCC present bit Message-ID: References: <20240510-imx-clk-v2-0-c998f315d29c@nxp.com> <20240510-imx-clk-v2-3-c998f315d29c@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510-imx-clk-v2-3-c998f315d29c@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240512_235445_930641_92D7835C X-CRM114-Status: GOOD ( 23.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 05:18:58PM +0800, Peng Fan (OSS) wrote: > From: Ye Li > > When some module is disabled by fuse, its PCC PR bit is default 0 and > PCC is not operational. Any write to this PCC will cause SError. > > Fixes: b40ba8065347 ("clk: imx: Update the compsite driver to support imx8ulp") > Reviewed-by: Peng Fan > Signed-off-by: Ye Li > Signed-off-by: Peng Fan > --- > drivers/clk/imx/clk-composite-7ulp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/clk/imx/clk-composite-7ulp.c b/drivers/clk/imx/clk-composite-7ulp.c > index e208ddc51133..e70a03e7299c 100644 > --- a/drivers/clk/imx/clk-composite-7ulp.c > +++ b/drivers/clk/imx/clk-composite-7ulp.c > @@ -14,6 +14,7 @@ > #include "../clk-fractional-divider.h" > #include "clk.h" > > +#define PCG_PR_MASK BIT(31) > #define PCG_PCS_SHIFT 24 > #define PCG_PCS_MASK 0x7 > #define PCG_CGC_SHIFT 30 > @@ -78,6 +79,10 @@ static struct clk_hw *imx_ulp_clk_hw_composite(const char *name, > struct clk_hw *hw; > u32 val; > > + val = readl(reg); > + if (!(val & PCG_PR_MASK)) > + return ERR_PTR(-ENODEV); It looks like this will trigger an error message in imx_check_clk_hws() Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel