From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F6C1C25B10 for ; Mon, 13 May 2024 07:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aYNzUOSnR7Av2UGOTarusJatqISOiBq718DCnOSwtvs=; b=PLL2JD5s4ExT0d GZG0KbMFTyXrsopWkuEAHJ450KpdCrOcNLkISoAZqead7/qEodv5tYlVBhtBDG8Nevn82A6D4CEnw x4e4Ql88Oezm9IWrdKBujIg4RZ5Qg34qsD+qloWNSY/R1+UFgitnyQ9hUaos1P8SCQNvULx2DotXO JI8LbCiENkEh2UM1cK9Jj81CG67ym8OIvKIE1W0cw7L3IBFBa9AEDBnEOnOFOeN/89xRNE6gbUlXj TQ9M4hHudnWCTR/XvSEMBkSJTWS0I/cAXrYpMxnIyoWA8uvPVqRHvHlSIRW360+DIxrYq/uq9Teow uk+UOVj669uxW/tYogKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Q29-0000000Bzzt-2zYN; Mon, 13 May 2024 07:23:41 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Q25-0000000Bzy9-3BZf for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 07:23:39 +0000 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6f4f2b1c997so1114058b3a.0 for ; Mon, 13 May 2024 00:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715585016; x=1716189816; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bkxOXqnTBAhY/tIMjPE5oqoapUJpOqskDlUKhDUKdtU=; b=MRYlG4dBOdM/RfEZmiPGtI7DXG8pStJih1dx4Bk2k7h5DjqPRKhLox5KidLMY+WTSE P2JWEvXoPDKVl9+4guhj1569MfB2q7dk/oqwfZcXn8MNnb1jER+/Wq0grlzZvFD+S6N9 CvMal9FV7hpTMhjri2qyKNXFC4/p5GrZarj060EtEF/y+/wqGjO4vKf33qqQ6hQv4SdG c1Yx16i9/uSCo+IL4yoWpXy41yd3D7cJ1sL2cwPBs1ImUGHqS1fZhA+ft4xDURptEp9G wiE00QwoU2foO0t8bUbVm5r6J/VzhasoRiR+EV7FvNa2yLu3I8QvTW5S694xadnl7+XW /2Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715585016; x=1716189816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bkxOXqnTBAhY/tIMjPE5oqoapUJpOqskDlUKhDUKdtU=; b=oo7ajJL5MmHhV06IqEE8kpINQVISMax7FIaqayq5ILzWQTbiWZN+z7zi+hU0ZL1Sl6 HXemVtunyOY5BWiwzNBLhMgy4+QDQn3nH6X4/hL9ZXvP6yCwDzcPh6BsRxQsZDPnXFH3 ERGOhwrbRWgLQJehKIt01lJpXAAjorNl6rew3LibkNRH5xsTfF9g+m4b7NCfXBVfO+Au JCwMcbx5d/cfgtlAsx6PV9vfNpS1aN/IT3tl/asQE7ThvX1i2ozUpodTLkOLHyMxypZ/ T5s+nyIPIsIlCPw/9sQrGUtTGFKD/XDBIuaoIu3PzhypuTIUruCu/oKO5l0jav1AR1z/ dRZQ== X-Forwarded-Encrypted: i=1; AJvYcCX4BrkuRChRG+pfz2PfaLCSAQ4FT3511/i5L0fgpfCw4vPQwhRq6dGl5nHFHb4NTQgIxZjPFWC7UalLuhtGAl5mxB5OfoFAT4QgShVvJTb/VqYJZ2c= X-Gm-Message-State: AOJu0Yyps9ylsUvcwiC3DjhLc4qELj+p4ZRINEOPexSbhoQJ7QHARJ10 VMlXK9GYdfbg2B5/C+PKYi1gI0lQTwm/lE46cTPOwlWLjzGs++mx X-Google-Smtp-Source: AGHT+IHowW17gu11/yK0M22fhOEW8qcMNS4xoNIh9z0IjYf2fw+m2cvq0nqva4tljyfTeocrcYhpaQ== X-Received: by 2002:a05:6a00:845:b0:6ed:7684:484b with SMTP id d2e1a72fcca58-6f4e0359ecfmr9241749b3a.27.1715585014226; Mon, 13 May 2024 00:23:34 -0700 (PDT) Received: from five231003 ([2405:201:c006:312d:c30b:6348:71fc:1f89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2ae0bacsm6752159b3a.105.2024.05.13.00.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 00:23:33 -0700 (PDT) Date: Mon, 13 May 2024 12:53:27 +0530 From: Kousik Sanagavarapu To: Nathan Chancellor Cc: kernel test robot , Nishanth Menon , Santosh Shilimkar , Julia Lawall , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] soc: ti: knav_qmss_queue: do device_node auto cleanup Message-ID: References: <20240510071432.62913-3-five231003@gmail.com> <202405111846.3m9z398l-lkp@intel.com> <20240513064451.GB652533@thelio-3990X> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240513064451.GB652533@thelio-3990X> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_002337_878117_21115158 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 12, 2024 at 11:44:51PM -0700, Nathan Chancellor wrote: > On Sun, May 12, 2024 at 03:56:22PM +0530, Kousik Sanagavarapu wrote: > > On Sat, May 11, 2024 at 06:12:39PM +0800, kernel test robot wrote: > > > Hi Kousik, > > > > > > kernel test robot noticed the following build errors: > > > > > > > [...] > > > > > All errors (new ones prefixed by >>): > > > > > > >> drivers/soc/ti/knav_qmss_queue.c:1853:3: error: cannot jump from this goto statement to its label > > > goto err; > > > ^ > > > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > > > struct device_node *regions __free(device_node) = > > > ^ [...] > > Seems like gcc didn't catch this when I compiled locally. > > FWIW, you may notice this as you do more conversions. The fact that GCC > does not warn at all is a GCC bug as far as I am aware (i.e., clang's > error is correct): > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91951 > > which has come up in other places: > > https://lore.kernel.org/20240425174732.GA270911@dev-arch.thelio-3990X/ Thank you so much for these links :) All my internet searches ended up at stackoverflow posts which didn't even describe the problem correctly, which also lead me to write an email explaining a partly erroneous solution, which is sitting in my mailbox ;) Thanks again, these will help a lot. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel