From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51E9CC25B10 for ; Mon, 13 May 2024 09:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z6vKMDOQF5Sydvf39L+iRJlcxvQMZe4GOSKkhIgTMfI=; b=jbYXqpRBAYu2EV 291P6mpe4jvAuieWr5j/qve6c4Z1frWoTdTO+a5r5TjTDki/4GyYty0l1iAs+Ps87xVbivR3rwAmr IE9CuuxTnGZ4uww//wugc7jIfNFc8AwEY/zDYZPMtXwzHy/xvjXNP+8/y7qVCfevH2CG2e24yYeQA zjnKl75wV2f3f/Hsi/mXvwGcIL+LVPGiW0yBuJH0ngTzuSbJ3BQf+t3o5niCxF+q5Qw/AA4C++QWh icZpPo7lSqyuIBUWvEr29QC1DkmiXe3CVJQPgbZuvpq9175cui9BBxUdbBisHQ83vRBk8ZK+cqnB2 DeJlN9kD42CZ1RPOOfdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Rp7-0000000CMaO-2FMb; Mon, 13 May 2024 09:18:21 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Rp4-0000000CMFo-1Mzi for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 09:18:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PUYErwj+94JicaDRBG3wqgYE+Hc9r7mIzXQtcNrbMCk=; b=CYf4VGzaIUFblQfi1rNVH5lkPM kmUtCRxw92E90JzKrSoFedlAwkWPr9mPpMMWSRXYWkT0UzER+/4J+sD1DIWQ2s4H7P/c2jmCEPeWp 5qxg41I9MV06dwJvtWotFw3POcPeX0bkPJnh81A7L4OdgtB4zx2R0jr9wjPx8+qZg/fpcElEa9CNL E26YnMVp9eNqGj6pdO9cKLwjgakwhsrVSxYOqB0lhfk2QluIesqOq1kbd8Sjz3y/iPpGjTwVeeRKA 0CtqUV26IqSiCpMoDjLMzcSehNJLpIg8Q0gtxRuv09XIS54+J07qsaD3akROnawFtwAmvNVXG7Wg0 tcUxm+dA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53832) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s6Rmj-0001b0-39; Mon, 13 May 2024 10:15:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s6Rme-00061E-GO; Mon, 13 May 2024 10:15:48 +0100 Date: Mon, 13 May 2024 10:15:48 +0100 From: "Russell King (Oracle)" To: Nathan Chancellor , davem@davemloft.net, Jakub Kicinski , Paolo Abeni Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Jesse Brandeburg , Marek =?iso-8859-1?Q?Beh=FAn?= , Piergiorgio Beruto , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart Subject: Re: [PATCH net-next 0/2] Fix phy_link_topology initialization Message-ID: References: <20240507102822.2023826-1-maxime.chevallier@bootlin.com> <20240513063636.GA652533@thelio-3990X> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240513063636.GA652533@thelio-3990X> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_021818_521202_5933AC3E X-CRM114-Status: GOOD ( 23.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 12, 2024 at 11:36:36PM -0700, Nathan Chancellor wrote: > Hi Maxime, > > On Tue, May 07, 2024 at 12:28:19PM +0200, Maxime Chevallier wrote: > > Nathan and Heiner reported issues that occur when phylib and phy drivers > > built as modules expect the phy_link_topology to be initialized, due to > > wrong use of IS_REACHABLE. > > > > This small fixup series addresses that by moving the initialization code > > into net/core/dev.c, but at the same time implementing lazy > > initialization to only allocate the topology upon the first PHY > > insertion. > > > > This needed some refactoring, namely pass the netdevice itself as a > > parameter for phy_link_topology helpers. > > > > Thanks Heiner for the help on untangling this, and Nathan for the > > report. > > Are you able to prioritize getting this series merged? This has been a > problem in -next for over a month now and the merge window is now open. > I would hate to see this regress in mainline, as my main system may be > affected by it (not sure, I got a new test machine that got bit by it in > addition to the other two I noticed it on). ... and Maxime has been working on trying to get an acceptable fix for it over that time, with to-and-fro discussions. Maxime still hasn't got an ack from Heiner for the fixes, and changes are still being requested. I think, sadly, the only way forward at this point would be to revert the original commit. I've just tried reverting 6916e461e793 in my net-next tree and it's possible, although a little noisy: $ git revert 6916e461e793 Performing inexact rename detection: 100% (8904/8904), done. Auto-merging net/core/dev.c Auto-merging include/uapi/linux/ethtool.h Removing include/linux/phy_link_topology_core.h Removing include/linux/phy_link_topology.h Auto-merging include/linux/phy.h Auto-merging include/linux/netdevice.h Removing drivers/net/phy/phy_link_topology.c Auto-merging drivers/net/phy/phy_device.c Auto-merging MAINTAINERS hint: Waiting for your editor to close the file... I haven't checked whether that ends up with something that's buildable. Any views Jakub/Dave/Paolo? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel