From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B46FC25B75 for ; Mon, 13 May 2024 09:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ups7jlhRZo0KTLaY3aJg+eHej8OM18+vP3MTwcgjfx0=; b=k5RgX7IBNL0xLj G/CItXuQrsEArZIf3NyhNXegPoBsWH/GhpdiGAN4nrcYRCGRAz1G2fOqI/BCXNxPX+J1oAWiC5RWO 9nNMSUhTs2wQzywr0bGy1Itbz880hbS+YQ1Cedx9feMuZY1MaH/qPydL9o6BOiEr33qLfJ+CwE7LE mm1Jo+HPPJEWNAzta7hNEkpt3/dncv9OJen1d4W67AXVAZmHxzQJGvpTSzeTOJxg1WWeO73DfzRQL c/Brxv7YD0P1Q7opJE3U4DYAVfe4AOV0HT+4i6MiEVOBPuySR00vqGphJMZIWELUGrRBEWMGHy229 G5HkHkrL8qW6ZJhhqfrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6RtA-0000000CNFh-0mhW; Mon, 13 May 2024 09:22:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s6Rt7-0000000CNEg-2HEK for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2024 09:22:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B36B1007; Mon, 13 May 2024 02:22:50 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D7353F762; Mon, 13 May 2024 02:22:24 -0700 (PDT) Date: Mon, 13 May 2024 10:22:21 +0100 From: Sudeep Holla To: Dominique Martinet Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Cristian Marussi Subject: Re: [PATCH 5.4 / 5.10] firmware: arm_scmi: Harden accesses to the reset domains Message-ID: References: <20240513003837.810709-1-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240513003837.810709-1-dominique.martinet@atmark-techno.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240513_022229_724937_B6DE3CFF X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 13, 2024 at 09:38:37AM +0900, Dominique Martinet wrote: > From: Cristian Marussi > > [ Upstream commit e9076ffbcaed5da6c182b144ef9f6e24554af268 ] > > Accessing reset domains descriptors by the index upon the SCMI drivers > requests through the SCMI reset operations interface can potentially > lead to out-of-bound violations if the SCMI driver misbehave. > > Add an internal consistency check before any such domains descriptors > accesses. > > Link: https://lore.kernel.org/r/20220817172731.1185305-5-cristian.marussi@arm.com > Signed-off-by: Cristian Marussi > Signed-off-by: Sudeep Holla > Signed-off-by: Dominique Martinet > --- > This is the backport I promised for CVE-2022-48655[1] > [1] https://lkml.kernel.org/r/Zj4t4q_w6gqzdvhz@codewreck.org > The backport looks good and thanks for doing that. Sometimes since we know all the users are in the kernel, we tend to ignore the facts that they need to be backport as this was considered as theoretical issue when we pushed the fix. We try to keep that in mind and add fixes tag more carefully in the future. Thanks for your effort and bring this to our attention. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel