From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E31ADC25B75 for ; Wed, 15 May 2024 11:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UzDjJeZ8dEp9sk1F2k0oDlidcBUxpUNO3pk6jDZdIkc=; b=EUtZl9kjZNCBEF YSm6MVnR8psSIUGlPYMz/yeDZC1LwnErPjbRTxDtU49LbHcfT3fbbvRZB1aDJT7XGWO+f48gOTdi4 K0+LLbn3HR5xnVIKnVwFI/gXXh8fCjiTijTrW+RpZPzZA2qIYhgh1hUOQ1asnIS5OmbGv3Nd9Y1wh R3KehuQZ+TNPyG3scFi+J8CxZ3dcXIQZ3ETkbdBGYT9Sl9D14zQrmB6T71uGPxf9iF/yvhYCktmQe l5o2hKU2vBvyW+ZguS7y4hVGSCzOoMLzgHTe2oBVzCXjs40g9tv2JIie/N6bPs/BKuVvegIuHz5ly a1Nw3M7NiNxFGgpVi2yg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7CWT-00000001Jn6-43MT; Wed, 15 May 2024 11:10:13 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7CWR-00000001JmU-2JzZ for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2024 11:10:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1BC40CE147A; Wed, 15 May 2024 11:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E049C116B1; Wed, 15 May 2024 11:10:03 +0000 (UTC) Date: Wed, 15 May 2024 12:10:01 +0100 From: Catalin Marinas To: Steven Price Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, Sami Mujawar , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni Subject: Re: [PATCH v2 13/14] arm64: rsi: Interfaces to query attestation token Message-ID: References: <20240412084213.1733764-1-steven.price@arm.com> <20240412084213.1733764-14-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240412084213.1733764-14-steven.price@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240515_041011_980568_D9BEE797 X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 12, 2024 at 09:42:12AM +0100, Steven Price wrote: > diff --git a/arch/arm64/include/asm/rsi_cmds.h b/arch/arm64/include/asm/rsi_cmds.h > index b4cbeafa2f41..c1850aefe54e 100644 > --- a/arch/arm64/include/asm/rsi_cmds.h > +++ b/arch/arm64/include/asm/rsi_cmds.h > @@ -10,6 +10,9 @@ > > #include > > +#define GRANULE_SHIFT 12 > +#define GRANULE_SIZE (_AC(1, UL) << GRANULE_SHIFT) The name is too generic and it goes into a header file. Also maybe move it to rsi.h, and use it for other definitions like rsi_config struct size and alignment. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel