From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E371C25B7B for ; Thu, 16 May 2024 10:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UCJd5p5YEyoiYDmCqcEtUHHhUJZHY1jluWaHDvvS8zU=; b=CCFF4Uw/p9IT17 4tAcYqLp3yWswpQbQugpfWaIxRMFxwnXrvCv72Zha4afN3w7dYh2Kego0o1jtZvrL6owaWMMxCYRQ lAhAxfAhds2QgQFU9opFmtCJBCe/KNbkyLP1LtFdsiHIoiVyIket6617denQ0txbuAoOfSjglfAW5 9tQRYhn2avi9iG4jP4QrB4rKATzGB31WlugpLJs/wYLaA0GL0J2KzPeIPMKPoyqjSnRDVtRmbRqAj 17G773blEiTj/DxOaKNJBj9JJA0mErrVO7mpv2FBUry6vumHhY3F+uX0w2a/z2vrpiPDEjxgBb4He ik1CX5pDJUYcRSpR/Okg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7YPB-00000004UJb-0XjA; Thu, 16 May 2024 10:32:09 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7YP6-00000004UI9-0tmH for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2024 10:32:06 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-574ea5184abso3461347a12.3 for ; Thu, 16 May 2024 03:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1715855521; x=1716460321; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=jFfEH0nLFM+O/JJvf5HTtYGZMvNxTcGxwhqubZ4Dp1o=; b=B7pxvjwPU80R1SXxy9FQSMqGiMsjtnwcREGwcaC55NfSV4/CZ0y+5UECI+5haBNGUG eY4EoEnLwspHWZlE0SUEU5WkWeof0CJb+FtVuR7vDeSkTvAs2z5Nf7M33ms2u/QG1OH6 WFduDFrvzOYYNZ2F1t5h4OzqG4ip+1/3dy4IDq9NLrqaeUC0Qqib+4jQ4FQsPc6TsjxY 5WhpoLI4qF5g22Q8vB9zKDzgSDi7XzzwsvzmKdW1axmAH84bLfrxZv1bJl2p7RUYJ/Ql yNiLkiPwr4ep6L5H+TcLzo7fcOaebi7FQwtv2nDxqBkhXZN0Hj77XuOutaRQn/bs9dXa hLKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715855521; x=1716460321; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jFfEH0nLFM+O/JJvf5HTtYGZMvNxTcGxwhqubZ4Dp1o=; b=XV3o4E4fbq/aLoQzRIZXIctC2M8auFeOpuMUEH4kAz7hrH7frrD5AoAHBbHbtXh1am //pxsaEm6YDWT1pczF6QD3gZkt2VrM9AcxcB61Ty7MazLXX2EcSWxfSNYWwn7+vkCzDT JfqBOTMhU/RqaFWNo1QfgvMeq6nl6fjqMTKSh4Ws/WK36Mq8nU1nybEyOds97pHkoQcu WKyexi5O/WI0hbgW4D1CenWUu4AmzqSSTeeFEH0P2ecRDXTGn8+FTLtxsftPYWKUb3Km VwRBwQzXE4mw2gItrctTrZx7sc2A2sdaThKMx3uM6fV7wA/F9qA0AyrMM8HRLbWl37Ms Rz5Q== X-Forwarded-Encrypted: i=1; AJvYcCVByIdtJn8duclpbC7t9e+HLSe4c6mqJlpGpS2ERSpDkf5mU9sEB687WR6Lb1iptXQ8bjVZsFkujsPuYh53FNzjLPQJb1TcDa/cwHK832ZmhFCtsZ4= X-Gm-Message-State: AOJu0YxmubL3pD3CUI/SqCsr2i7gbjUKLqPDgU7NiHsvQINM7rTUByqF ghpSsQ93tJTeW4Mgpk4squsKbHuj6fmcEpg/iQyBRcyhZlkV51W9d1Pi0zolEis= X-Google-Smtp-Source: AGHT+IHSBsoYuE4woB/zAs3ODpON7rgmUZR2UwQV7pcu6xvLv6oTld2p+F7Pt7tXuJlHbtXbGlL+pQ== X-Received: by 2002:a17:906:394e:b0:a59:cb29:3fac with SMTP id a640c23a62f3a-a5a2d68aad7mr1284605566b.65.1715855521454; Thu, 16 May 2024 03:32:01 -0700 (PDT) Received: from localhost (host-79-19-230-33.retail.telecomitalia.it. [79.19.230.33]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a7a944664sm377064866b.37.2024.05.16.03.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 03:32:01 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Thu, 16 May 2024 12:32:10 +0200 To: "Rob Herring (Arm)" Cc: Andrea della Porta , Conor Dooley , Kamal Dasu , Eric Anholt , Scott Branden , linux-mmc@vger.kernel.org, Krzysztof Kozlowski , Al Cooper , Ray Jui , Ulf Hansson , Stefan Wahren , devicetree@vger.kernel.org, Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , linux-kernel@vger.kernel.org, Adrian Hunter , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/4] Add minimal boot support for Raspberry Pi 5 Message-ID: Mail-Followup-To: "Rob Herring (Arm)" , Andrea della Porta , Conor Dooley , Kamal Dasu , Eric Anholt , Scott Branden , linux-mmc@vger.kernel.org, Krzysztof Kozlowski , Al Cooper , Ray Jui , Ulf Hansson , Stefan Wahren , devicetree@vger.kernel.org, Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , linux-kernel@vger.kernel.org, Adrian Hunter , linux-arm-kernel@lists.infradead.org References: <171560671443.2464066.440073842827214763.robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <171560671443.2464066.440073842827214763.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_033204_287666_78DB41F4 X-CRM114-Status: GOOD ( 38.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08:27 Mon 13 May , Rob Herring (Arm) wrote: > > On Fri, 10 May 2024 16:35:26 +0200, Andrea della Porta wrote: > > Hi, > > > > This patchset adds minimal support for the Broadcom BCM2712 SoC and for > > the on-board SDHCI controller on Broadcom BCM2712 in order to make it > > possible to boot (particularly) a Raspberry Pi 5 from SD card and get a > > console through uart. > > Changes to arm64/defconfig are not needed since the actual options work > > as they are. > > This work is heavily based on downstream contributions. > > > > Tested on Tumbleweed substituting the stock kernel with upstream one, > > either chainloading uboot+grub+kernel or directly booting the kernel > > from 1st stage bootloader. Steps to reproduce: > > - prepare an SD card from a Raspberry enabled raw image, mount the first > > FAT partition. > > - make sure the FAT partition is big enough to contain the kernel, > > anything bigger than 64Mb is usually enough, depending on your kernel > > config options. > > - build the kernel and dtbs making sure that the support for your root > > fs type is compiled as builtin. > > - copy the kernel image in your FAT partition overwriting the older one > > (e.g. kernel*.img for Raspberry Pi OS or u-boot.bin for Tumbleweed). > > - copy arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb on FAT partition. > > - make sure you have a cmdline.txt file in FAT partition with the > > following content: > > # cat /boot/efi/cmdline.txt > > root=/dev/mmcblk0p3 rootwait rw console=tty ignore_loglevel earlycon > > console=ttyAMA10,115200 > > - if you experience random SD issues during boot, try to set > > initial_turbo=0 in config.txt. > > > > Changes in V2: > > > > - the patchshet has been considerably simplified, both in terms of dts and > > driver code. Notably, the pinctrl/pinmux driver (and associated binding) > > was not strictly needed to use the SD card so it has been dropped. > > - dropped the optional SD express support patch > > - the patches order has been revisited > > - pass all checks (binding, dtb, checkpatch) > > > > Many thanks, > > Andrea > > > > References: > > - Link to V1: https://lore.kernel.org/all/cover.1713036964.git.andrea.porta@suse.com/ > > > > Andrea della Porta (4): > > dt-bindings: arm: bcm: Add BCM2712 SoC support > > dt-bindings: mmc: Add support for BCM2712 SD host controller > > mmc: sdhci-brcmstb: Add BCM2712 support > > arm64: dts: broadcom: Add support for BCM2712 > > > > .../devicetree/bindings/arm/bcm/bcm2835.yaml | 6 + > > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 ++ > > arch/arm64/boot/dts/broadcom/Makefile | 1 + > > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 62 ++++ > > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 302 ++++++++++++++++++ > > drivers/mmc/host/sdhci-brcmstb.c | 81 +++++ > > 6 files changed, 475 insertions(+) > > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712.dtsi > > > > -- > > 2.35.3 > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y broadcom/bcm2712-rpi-5-b.dtb' for cover.1715332922.git.andrea.porta@suse.com: > > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/timer@7c003000: failed to match any schema with compatible: ['brcm,bcm2835-system-timer'] > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/local-intc@7cd00000: failed to match any schema with compatible: ['brcm,bcm2836-l1-intc'] Those two property come respectively from: - Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt - Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt that are old style txt bindings. So unfortunally they will output that kind of warnings: converting txt to yaml schema wouldbe great, but I think a little outside the scope of this patchset. I would say it is a good cancidate for a separate patch. Many thanks, Andrea _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel