From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9BA9C25B74 for ; Thu, 16 May 2024 11:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z+BsTul3Brg0lwVoIfAROkq1wWI6t7YdiIlSUl0gW0A=; b=4qWCWMShxhXRn0bSb+vy13kTQx GCHW7InnYRAw27P21AJt4sF/l++gsSEyIA75vCz8hFZBsDYVd6jkw+7je928Cv9l9LqqdHx6C/yBx 4LxNm5BuDTUcGbuKF8AEeCcrGoiHaNnRp5tDg1y7uWqXBGk/JE2PhuGhr2YZy8Xy/+4MFvtjY0qL5 KOb58Pd+MOP+yFoWx2x/OtY/BsyLbQ8ffR5l2HtU0VhUhaSLfMzWgmWNO+NohXvLGqLLnZmfq6x1z J7YOl9DWstlfb2UQsjAKO6X7fQX//hr4sRvXIhyF44H9ofeOT7CVimH7ZLUtWnB5lwvN34A5NvWCG 8i9KOHbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7ZBq-00000004b2k-3dFq; Thu, 16 May 2024 11:22:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7ZBn-00000004b20-47NV for linux-arm-kernel@lists.infradead.org; Thu, 16 May 2024 11:22:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AE234CE184C; Thu, 16 May 2024 11:22:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DA6DC113CC; Thu, 16 May 2024 11:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715858540; bh=gkue31XZB7soLiC173LtvdoK5m2Qi3X/p+NB90MIVPI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HCtlEfTl6j2d0A1k5vyrf0BKB+9HE+wrFN9Z0GmCGQiafs9bFV4ireltLBVZravjY 6/GB+oQKmcLf+N8PoNtWKhxqWOPUku3cJtnPbb7y0WCng+zg4yMo4AogjdvOk7S/RD Mb56XiuLcOQrCpeB/4L9VM0efH7u+0o8f816ojKEZLrqvCWdYPTJhfyS5QgPRQSHwp ONnH8Tnk+4gn1nvVMTT85cZ/O0bOpatWYAm2Tsw3nvD+LTLdbNHTFJOys/f633dyE9 z+R5j0F9uVNs6zeuxieWK5KupYQHS8kRv1nc1hNjPJpVhQW2ds3EfnLVr9gERF0Rnc EhhPAxfCe260w== Date: Thu, 16 May 2024 13:22:16 +0200 From: Lorenzo Bianconi To: AngeloGioacchino Del Regno Cc: linux-clk@vger.kernel.org, p.zabel@pengutronix.de, mturquette@baylibre.com, sboyd@kernel.org, lorenzo.bianconi83@gmail.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org, dd@embedd.com, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com Subject: Re: [PATCH 4/5] clk: en7523: Add reset-controller support for EN7581 SoC Message-ID: References: <0f7b04c2101db1a974dc45017bee285ffb25d80f.1715777643.git.lorenzo@kernel.org> <97b1fbfc-e059-46c7-9bb1-75cdaa2d2159@collabora.com> MIME-Version: 1.0 In-Reply-To: <97b1fbfc-e059-46c7-9bb1-75cdaa2d2159@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_042224_560623_1B69A9FF X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2814657680201619323==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2814657680201619323== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1IzpTw6hbx1Q6+He" Content-Disposition: inline --1IzpTw6hbx1Q6+He Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Il 15/05/24 14:58, Lorenzo Bianconi ha scritto: > > Introduce reset API support to EN7581 clock driver. > >=20 > > Tested-by: Zhengping Zhang > > Signed-off-by: Lorenzo Bianconi >=20 > Heh, that's exactly the usual MediaTek reset controller :-D >=20 > > --- > > drivers/clk/clk-en7523.c | 96 +++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 94 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c > > index 381605be333f..18798b692b68 100644 > > --- a/drivers/clk/clk-en7523.c > > +++ b/drivers/clk/clk-en7523.c > > @@ -6,6 +6,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #define REG_PCI_CONTROL 0x88 > > @@ -65,8 +66,18 @@ struct en_clk_gate { > > struct clk_hw hw; > > }; > > +#define RST_NR_PER_BANK 32 >=20 > Please move this definition at the beginning of this file, grouping that = with > the others. ack, I will fix it. >=20 > ..snip... >=20 > > @@ -456,12 +542,14 @@ static int en7523_clk_probe(struct platform_devic= e *pdev) > > en7523_register_clocks(&pdev->dev, clk_data, base, np_base); > > r =3D of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); > > - if (r) > > + if (r) { > > dev_err(&pdev->dev, > > "could not register clock provider: %s: %d\n", > > pdev->name, r); > > + return r; > > + } > > - return r; > > + return en7523_reset_register(&pdev->dev, np_base, soc_data); >=20 > If en7523_reset_register fails, you want to call of_clk_del_provider(), so > you can't just return like this... ack, I will fix it. Regards, Lorenzo >=20 > Cheers, > Angelo >=20 > > } > > static const struct en_clk_soc_data en7523_data =3D { > > @@ -480,6 +568,10 @@ static const struct en_clk_soc_data en7581_data = =3D { > > .unprepare =3D en7581_pci_unprepare, > > .disable =3D en7581_pci_disable, > > }, > > + .reset_data =3D { > > + .base_addr =3D REG_RESET_CONTROL2, > > + .n_banks =3D 2, > > + }, > > .hw_init =3D en7581_clk_hw_init, > > }; >=20 >=20 >=20 --1IzpTw6hbx1Q6+He Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZkXsaAAKCRA6cBh0uS2t rGMtAP42ShUJqdRmjCR450t85MAH7GQu7725+THcJN3P1i9EYQD+MV2tuolsxmA3 QmzsQdg94EMSnDH6veNPqwaLnoUdGwE= =eOOs -----END PGP SIGNATURE----- --1IzpTw6hbx1Q6+He-- --===============2814657680201619323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2814657680201619323==--