From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4177C04FFE for ; Fri, 17 May 2024 11:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1xbUj6EfUOHzkg1NvJg71WPJnCwdoWjno/eJvyOujOE=; b=HRsyNPYe0yZirI 1MWZVhKHiYTxPhH0gMOFZNTwTgvOtg/yxlRnXuT8NafOH2407M7f+ZHokmFdAkgCg+jZnp8qpqgmc D0i9FMR4I0+DcJJIRem/uHaCKemf0JCJkGYvhwvb9TNYDMA2+9uZDCnuRSR7NSBVScIdFEt/B+Ock caObpdf98RNYCGeXwfJK+5VJ0++oCncPPyFKXtSN3KwpaUTLc9OA64b5C7nqh1JWqb5QvcoXIZVUV sSQ6tHNrJRU7KXX38H0GTl8TroUVrC+LqiiSnFHgg0mMtPA1//OuYOcfnIHBACQuDmfNEAGs+PGJ2 ezTE0RembDcFwChqIqOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7wDe-00000007kGE-2TNL; Fri, 17 May 2024 11:57:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7wDb-00000007kEW-1wAz for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2024 11:57:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDC761424; Fri, 17 May 2024 04:58:07 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74CE83F7A6; Fri, 17 May 2024 04:57:42 -0700 (PDT) Date: Fri, 17 May 2024 13:57:36 +0200 From: Mark Rutland To: Ard Biesheuvel Cc: Marc Zyngier , Catalin Marinas , Will Deacon , Johannes Nixdorf , Mark Brown , linux-arm-kernel@lists.infradead.org Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_045747_582888_22E2EAB7 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 16, 2024 at 07:17:00PM +0200, Ard Biesheuvel wrote: > On Thu, 16 May 2024 at 18:25, Marc Zyngier wrote: > > > > + Ard, Broonie > > > > Ugh. > > This is going to be tricky to track down if it takes 10G of data to reproduce. > > For the time being, maybe we should just revert and take the time to > really dig into this? > > It appears to revert cleanly, and the performance gain of the > optimization was never quantified in the first place, so perhaps we > should get some numbers too when we bring it back. I agree that reverting is the right thing to do. The main functional reason we wanted this was in preparation for PREEMPT_AUTO, and that's still a way off. Mark. > > > > > On 2024-05-16 17:22, Johannes Nixdorf wrote: > > > I noticed frequent FS corruption on my M1 MacBook running Linux after > > > the Asahi Linux Kernel was updated to 6.9.x (from 6.6.x). > > > > > > A git bisect pointed me to 2632e2521769 ("arm64: fpsimd: Implement lazy > > > restore for kernel mode FPSIMD"). > > > > > > This was reproduced with fio's examples/basic-verify.fio (1GB of > > > writing > > > was not reliably, 10GB triggered it reliably) on vanilla kernels and > > > happens on any storage backend behind dm-crypt. > > > > > > I was advised to report it here on IRC. > > > > > > This was independently described in [1]. > > > > > > Regards, > > > Johannes Nixdorf > > > > > > [1]: https://github.com/tpwrules/nixos-apple-silicon/issues/200 > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > > Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel