From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: sunxi: sram: Remove unused list 'claimed_sram'
Date: Sat, 18 May 2024 00:15:16 +0000 [thread overview]
Message-ID: <ZkfzFBpZVaMLH7_f@gallifrey> (raw)
In-Reply-To: <20240504204401.198913-1-linux@treblig.org>
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The list 'claimed_sram' seems unused, as far as I can tell it always
> has been.
> I think the 'list' member of sunxi_sram_data was intended to be
> used when it was on that list.
> Remove them.
>
> Build tested only.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Ping
> ---
> drivers/soc/sunxi/sunxi_sram.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
> index 6eb6cf06278e6..71cc377b5e243 100644
> --- a/drivers/soc/sunxi/sunxi_sram.c
> +++ b/drivers/soc/sunxi/sunxi_sram.c
> @@ -33,7 +33,6 @@ struct sunxi_sram_data {
> u8 offset;
> u8 width;
> struct sunxi_sram_func *func;
> - struct list_head list;
> };
>
> struct sunxi_sram_desc {
> @@ -103,7 +102,6 @@ static const struct of_device_id sunxi_sram_dt_ids[] = {
> };
>
> static struct device *sram_dev;
> -static LIST_HEAD(claimed_sram);
> static DEFINE_SPINLOCK(sram_lock);
> static void __iomem *base;
>
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-18 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 20:44 [PATCH] soc: sunxi: sram: Remove unused list 'claimed_sram' linux
2024-05-18 0:15 ` Dr. David Alan Gilbert [this message]
2024-05-28 14:15 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkfzFBpZVaMLH7_f@gallifrey \
--to=linux@treblig.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).