From: Mark Rutland <mark.rutland@arm.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: Jiangfeng Xiao <xiaojiangfeng@huawei.com>,
catalin.marinas@arm.com, will@kernel.org, Dave.Martin@arm.com,
xieyuanbin1@huawei.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, nixiaoming@huawei.com,
wangbing6@huawei.com, douzhaolei@huawei.com, liaohua4@huawei.com,
lijiahuan5@huawei.com, wangfangpeng1@huawei.com,
"zhangjianhua (E)" <chris.zjh@huawei.com>
Subject: Re: [PATCH] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY
Date: Mon, 20 May 2024 14:01:50 +0100 [thread overview]
Message-ID: <ZktJtlIThiLpK0Na@J2N7QTR9R3.cambridge.arm.com> (raw)
In-Reply-To: <20d70835-9411-9a08-c567-56d7040e01dd@huawei.com>
On Mon, May 20, 2024 at 08:05:25PM +0800, Li Zetao wrote:
> On 2024/5/20 18:33, Mark Rutland wrote:
> > On Fri, May 17, 2024 at 10:13:28PM +0800, Jiangfeng Xiao wrote:
> > > diff --git a/arch/arm64/include/asm/asm-bug.h b/arch/arm64/include/asm/asm-bug.h
> > > index c762038..6e73809 100644
> > > --- a/arch/arm64/include/asm/asm-bug.h
> > > +++ b/arch/arm64/include/asm/asm-bug.h
> > > @@ -28,6 +28,7 @@
> > > 14470: .long 14471f - .; \
> > > _BUGVERBOSE_LOCATION(__FILE__, __LINE__) \
> > > .short flags; \
> > > + .align 2; \
> The use of .align 2 here is based on the assumption that struct bug_entry is
> 4-byte aligned. Currently, there is no problem with this assumption, but for
> compatibility reasons, refer to the riscv architecture and refactor the
> implementation of __BUG_FLAGS:
>
> #define __BUG_FLAGS(flags) \
> do { \
> __asm__ __volatile__ ( \
> "1:\n\t" \
> "ebreak\n" \
> ".pushsection __bug_table,\"aw\"\n\t" \
> "2:\n\t" \
> __BUG_ENTRY "\n\t" \
> ".org 2b + %3\n\t" \
> ".popsection" \
> : \
> : "i" (__FILE__), "i" (__LINE__), \
> "i" (flags), \
> "i" (sizeof(struct bug_entry))); \
> } while (0)
>
> Align the real size of struct bug_entry through .org. What do you think?
I can see why that appears nice, but we can't do that in asm-bug.h
without something in asm-offets.h, and I suspect that's going to lead to
pain with circular header dependencies.
Regardless, if things change we'll need to make other changes here, so I
don't think we gain much.
I think it's preferable to have the explicit .align for now.
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-20 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:13 [PATCH] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY Jiangfeng Xiao
2024-05-20 10:33 ` Mark Rutland
2024-05-20 12:05 ` Li Zetao
2024-05-20 13:01 ` Mark Rutland [this message]
2024-05-20 13:21 ` Jiangfeng Xiao
2024-05-20 13:30 ` Jiangfeng Xiao
2024-05-20 13:34 ` [PATCH v2] " Jiangfeng Xiao
2024-05-21 18:39 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZktJtlIThiLpK0Na@J2N7QTR9R3.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=chris.zjh@huawei.com \
--cc=douzhaolei@huawei.com \
--cc=liaohua4@huawei.com \
--cc=lijiahuan5@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=nixiaoming@huawei.com \
--cc=wangbing6@huawei.com \
--cc=wangfangpeng1@huawei.com \
--cc=will@kernel.org \
--cc=xiaojiangfeng@huawei.com \
--cc=xieyuanbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox