From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53381C04FFE for ; Mon, 20 May 2024 17:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gn+bIXLkE5N4ubIJkm8Nd8y7yOZngqYyMJE0zFr+R2s=; b=w5qKxgy0teB3/P eaXLzzi8VFJ6uzcrrlnz+D6Jf+r87zHERUG7SyUpRUgjHpmTnqWDsWjMEoHW7fSADn8FC13vx0Vju apcoNJ0bhajAjQST3AU19VyznV9xTjWRSV1E/GT7TETs4iNvgYvjyfbSCpVFe+/3tZvYRQqZus0Qn B3vGxmUwB8ouREI2mLYuEREgw37RS6cxwOemr9j/rX0E51+3TeRYnPyXUxehiy93G3GxNd7h9vBOF 0chd7Mo0xSVz5AjfXGoN2j5Vr3ipjAWUj/jRK8cEXdOBCZQ1iBdK54I5f0z18Qia/yyquvrLCPCS7 nYE0Djymna5bMsIYjYOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s978N-0000000FAgP-0SiU; Mon, 20 May 2024 17:49:15 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s978F-0000000FAc6-313E; Mon, 20 May 2024 17:49:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XfldnoFCtlXjDUGIkjCxDruNAojvgZwZWzyNtsiBzQI=; b=HOEcB3m6VMMOMDPp2cPBpKomlO FekL9B6kRdA3i7PGuGVL6jOAl8+l8w4sUza98ZBCYB/she/YBJ87BuBH/uYaxdE0EVgc3NuHmKYlW G1Ufav1ydalYq60mo06uVnnWf/kBK2CQ8r2vQNHzg4CLAw1v9RiQvAk9/zNTZjnT/kfcomuOfzkX6 5T7DUyMXFY3xpexzATBep97nyKXYp78EbdrCUPVIVzmv5gisGMe3TS8KECo+DwihcrSHB0zDyCcvH 4nTUFM0bejLOuEE2KQzySqDJv7nHOjAlIOYeDIK/HOKE000QjQLooBC1E7cXoNEvMFVCsonX1lTb3 +UnysHNg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52632) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s977m-0007BC-2Y; Mon, 20 May 2024 18:48:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s977k-0004Tz-AX; Mon, 20 May 2024 18:48:36 +0100 Date: Mon, 20 May 2024 18:48:36 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "kuba@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "dqfext@gmail.com" , Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= , "matthias.bgg@gmail.com" , "davem@davemloft.net" , "hkallweit1@gmail.com" , "daniel@makrotopia.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH net-next v2 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20240517102908.12079-1-SkyLake.Huang@mediatek.com> <20240517102908.12079-6-SkyLake.Huang@mediatek.com> <283c893aa17837e7189a852af4f88662cda5536f.camel@mediatek.com> <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a5f14f4-4cd9-48b5-a62c-711800cee942@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_104909_652301_53B730F0 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 20, 2024 at 03:02:21PM +0200, Andrew Lunn wrote: > > Actually this phy is strictly binded to (XFI)MAC on this platform. > > So I directly disable HDX feature of PHY. > > Sorry, i don't follow your answer: > > Can the PHY do half duplex? > Can the MAC do half duplex? > > The part which cannot do half-duplex should be the part which disables > half-duplex. Note that if the PHY is doing rate adaption (preferably in a form that it can control the MAC transmission rate), then even if the MAC can't do half-duplex, the PHY can still do half-duplex. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel