linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Nixdorf <mixi@shadowice.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>, Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Janne Grunau <j@jannau.net>
Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD")
Date: Tue, 21 May 2024 08:22:08 +0200	[thread overview]
Message-ID: <Zkw9kK0sXIgfqd01@shadowice> (raw)
In-Reply-To: <cb8822182231850108fa43e0446a4c7f@kernel.org>

Bad news: I hit the bug again with 2632e2521769 ("arm64: fpsimd: Implement
lazy restore for kernel mode FPSIMD") reverted during prolonged interactive
usage with the downstream Asahi Linux kernel.

This prompted me to adjust the reproducer to be closer to the desktop use
case, which then also found aefbab8e77eb ("arm64: fpsimd: Preserve/restore
kernel mode NEON at context switch"). With the vanilla kernel before the
commit or that commit reverted on the Asahi Linux kernel the new reproducer
also sees no bug, and interactive usage seems fine.

The old reproducer used a loop device backed by the initramfs' tmpfs. The
new reproducer now uses the actual hardware nvme device as backend:

init:
 dev=/dev/nvme0n1p7
 dm_name=test
 dm_dev=/dev/mapper/${dm_name}
 echo test | cryptsetup luksFormat -q ${dev}
 echo test | cryptsetup open ${dev} test
 mkfs.ext4 ${dm_dev}
 mount ${dm_dev} /target
 cd /target
 fio /verify.fio

verify.fio:
 [write-and-verify]
 loops=10
 rw=randwrite
 bs=4k
 direct=1
 ioengine=libaio
 iodepth=16
 verify=crc32c
 size=1G

CC: +jannau, as I previously told him aefbab8e77eb was safe after reverting it
for the wrong reasons, and then finding out is was not needed after retesting
with my old reproducer.

Kind Regards,
Johannes Nixdorf

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-05-21  6:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 16:22 [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Johannes Nixdorf
2024-05-16 16:25 ` Marc Zyngier
2024-05-16 17:16   ` Dave Martin
2024-05-16 17:17   ` Ard Biesheuvel
2024-05-17 11:37     ` Will Deacon
2024-05-17 11:40     ` Mark Brown
2024-05-17 11:57     ` Mark Rutland
2024-05-16 17:34   ` Johannes Nixdorf
2024-05-21  6:22   ` Johannes Nixdorf [this message]
2024-05-21  8:55     ` Ard Biesheuvel
2024-05-21 12:56       ` Mark Brown
2024-05-21 18:34     ` Will Deacon
2024-05-21 18:44       ` Mark Brown
2024-05-21 18:57         ` Ard Biesheuvel
2024-05-21 20:06       ` Janne Grunau
2024-05-21 20:21         ` Mark Brown
2024-05-21 21:23           ` Janne Grunau
2024-05-22 11:14             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zkw9kK0sXIgfqd01@shadowice \
    --to=mixi@shadowice.org \
    --cc=ardb@kernel.org \
    --cc=broonie@kernel.org \
    --cc=j@jannau.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).