From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 742CFC25B75 for ; Tue, 21 May 2024 06:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9J5quwzu1u6V9LnYAqdZoUk6tVjDMzycbHqB5s3XhhI=; b=RxoeKeSHS9pOt+ 1LYzvPSpR6taybQJCiziQIquQqIxwfoKRZVlQUJjSgHn+UcYGV9Gm3eIDyFaCIoSWANGW/fmbyVUn B65LTkRrtFBsiAWB3i7oXCMBxwNgDB65imBQn25ksJF75zfrbx/gn2PUGBxH3nkTupJgF/NPKmKRB x+zcB+maUqOmBP+jqcSp8xQoCZGzBANJ5p1K7zi8yl735xdxRYN/A/KLlx2afZXSBZYOXma4LVVjt MTpDfIAhCNqmvq35btozjVSe5biKnx2PAxJvak8DIykgcMJHVItNtP/zKkJrtO9ZkZgMokUYq9wBZ W0nOfJxjM3rtehoYlDBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9ItH-0000000GT6k-0qaR; Tue, 21 May 2024 06:22:27 +0000 Received: from shadowice.org ([2a01:4f9:2a:869::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9ItD-0000000GT4P-0sn7 for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 06:22:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=vzMDEzQbRN7M ut2qx84cujvuiyFqRhoIicNYpzrNbR0=; h=in-reply-to:references:subject:cc: to:from:date; d=shadowice.org; b=fi+jfC3MX4QToYxqqlPjP83Q1oTfwhVmyNUqu 8FAamUKO6RVMvUEOm0WqiIYqmVzVgPLALqR744iNw7FvpR1uzynvgYuO+ZVJtI22uB4yOX CJrQpB+MdjjOHoYPCPClpQ0P4+LkNysqPxL82eL6uCPn3ykjSVtfYV6QTyMWzw7Y= Received: from localhost (localhost [::1]) by shadowice.org (OpenSMTPD) with ESMTPSA id 16f78221 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 21 May 2024 08:22:08 +0200 (CEST) Date: Tue, 21 May 2024 08:22:08 +0200 From: Johannes Nixdorf To: Marc Zyngier Cc: Ard Biesheuvel , Mark Brown , linux-arm-kernel@lists.infradead.org, Janne Grunau Subject: Re: [BUG] dm-crypt broken after 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_232223_879769_E41A5F51 X-CRM114-Status: UNSURE ( 9.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Bad news: I hit the bug again with 2632e2521769 ("arm64: fpsimd: Implement lazy restore for kernel mode FPSIMD") reverted during prolonged interactive usage with the downstream Asahi Linux kernel. This prompted me to adjust the reproducer to be closer to the desktop use case, which then also found aefbab8e77eb ("arm64: fpsimd: Preserve/restore kernel mode NEON at context switch"). With the vanilla kernel before the commit or that commit reverted on the Asahi Linux kernel the new reproducer also sees no bug, and interactive usage seems fine. The old reproducer used a loop device backed by the initramfs' tmpfs. The new reproducer now uses the actual hardware nvme device as backend: init: dev=/dev/nvme0n1p7 dm_name=test dm_dev=/dev/mapper/${dm_name} echo test | cryptsetup luksFormat -q ${dev} echo test | cryptsetup open ${dev} test mkfs.ext4 ${dm_dev} mount ${dm_dev} /target cd /target fio /verify.fio verify.fio: [write-and-verify] loops=10 rw=randwrite bs=4k direct=1 ioengine=libaio iodepth=16 verify=crc32c size=1G CC: +jannau, as I previously told him aefbab8e77eb was safe after reverting it for the wrong reasons, and then finding out is was not needed after retesting with my old reproducer. Kind Regards, Johannes Nixdorf _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel