From: Andrea della Porta <andrea.porta@suse.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Andrea della Porta <andrea.porta@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Marc Zyngier <maz@kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kamal Dasu <kamal.dasu@broadcom.com>,
Al Cooper <alcooperx@gmail.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v3 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller
Date: Tue, 21 May 2024 14:52:20 +0200 [thread overview]
Message-ID: <ZkyZBJw_RJ8SMYK_@apocalypse> (raw)
In-Reply-To: <bc1eb98c-9d49-4424-ab89-16be6c67c3f5@gmx.net>
On 13:56 Tue 21 May , Stefan Wahren wrote:
> Hi Andrea,
>
> Am 21.05.24 um 10:35 schrieb Andrea della Porta:
> > The BCM2712 has an SDHCI capable host interface similar to the one found
> > in other STB chipsets. Add the relevant compatible string.
> >
> > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > ---
> > Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > index cbd3d6c6c77f..d584a7ea707a 100644
> > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> > @@ -13,6 +13,10 @@ maintainers:
> > properties:
> > compatible:
> > oneOf:
> > + - items:
> > + - enum:
> > + - brcm,bcm2712-sdhci
> > + - const: brcm,sdhci-brcmstb
> sorry i didn't noticed in V2, but why can't we just extend the second
> items list?
Hi Stefan,
I initially thought that the two different item lists represent two
different controller families, but now that you point that out, I'm more
and more convinced that probably we can shorten the representation as
you are suggesting, adding 'brcm,bcm2712-sdhci' to the second item list
enum. Will be so in V4.
Many thanks,
Andrea
> > - items:
> > - enum:
> > - brcm,bcm7216-sdhci
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-21 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 8:35 [PATCH v3 0/4] Add minimal boot support for Raspberry Pi 5 Andrea della Porta
2024-05-21 8:35 ` [PATCH v3 1/4] dt-bindings: arm: bcm: Add BCM2712 SoC support Andrea della Porta
2024-05-21 8:35 ` [PATCH v3 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Andrea della Porta
2024-05-21 11:56 ` Stefan Wahren
2024-05-21 12:52 ` Andrea della Porta [this message]
2024-05-21 8:35 ` [PATCH v3 3/4] mmc: sdhci-brcmstb: Add BCM2712 support Andrea della Porta
2024-05-21 12:26 ` Stefan Wahren
2024-05-21 13:00 ` Andrea della Porta
2024-05-25 5:39 ` Andrea della Porta
2024-05-25 6:59 ` Stefan Wahren
2024-05-27 7:27 ` Andrea della Porta
2024-05-21 8:35 ` [PATCH v3 4/4] arm64: dts: broadcom: Add support for BCM2712 Andrea della Porta
2024-05-21 12:53 ` [PATCH v3 0/4] Add minimal boot support for Raspberry Pi 5 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkyZBJw_RJ8SMYK_@apocalypse \
--to=andrea.porta@suse.com \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=kamal.dasu@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).