From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98425C25B74 for ; Tue, 21 May 2024 12:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7eFewfn4TsJZVKUjJq3hE+oiNi0zk4l+f3yOmNDGq/Y=; b=M1f8reBSCnMBIo p8BpUq7py1Ydn6N+gJXySO6UWe2PykyWgbLwQ8MChkbFIuqAfH3PZkef2/3ReWjXfHPDOMeVnV4Iw mFpGkri48u2048q/o/z9/Vn/RiiZ9/y4UK3aziZ9gtU40V4auhtNJ0uTlBg7C+GSsevWv9M7LqAOp pU1vm62qmAeCJ5vDnWoFa56tkIaGjMr+Y3c0BMmcII8jYNl20ZMELrIZQhXIBKtSlnq0RoOmUNhWm ksp4yEMV3KuwxQRSjkx17FUnH0Elq+9bmLBBZFIzrr5azn7ug3Q7iO7GxgzxJpln9NqWt60gXOMsf AI639tRTrHruDAw5wdLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9OyV-0000000HUk8-3nIS; Tue, 21 May 2024 12:52:15 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9OyT-0000000HUiP-2NMU for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 12:52:15 +0000 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2e27277d2c1so68751131fa.2 for ; Tue, 21 May 2024 05:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716295931; x=1716900731; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=1u5xJDOD57W6YVCnN4RepdIN+phyLa7DjVqYRoxfZgU=; b=gvHwQBT3vxbyxrWvgWvwm5CM1eWUtOowFIQDWkcf9hFdcHpfDk3A5bqDxL/dsV+q8+ +awpKR2mAf+v6cy9dJffQZNAMVBjqZ9vJS73FNt+4MrQ5SdRRS+BH6Hr40+JoxtGaRhd nPsfjMEP2fHQVfbvK/9Yc/C+PMbQipQtqKQLAFE2fl/d9neQudJDj2MP6qtR1aeu2k0n 56G75w/A05H1we/83RedbEQgxtiVDIkDaX2zHWG1TDHZb9ljIg32yVgzhpTnrkS0hkgY waWWL02V8LLoQRO4ORI/dMDutJGngFP4+p30VvogeBi4TYtJz7xcabZ8NUQJDHl2w9Dm XpSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716295931; x=1716900731; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1u5xJDOD57W6YVCnN4RepdIN+phyLa7DjVqYRoxfZgU=; b=bt8s5iOU7lP6lR6qCgoPak0BHOoQGYfXgIICitoZSuAsJgCfwu9g5whEVNljkdZGeu VY2BG0SlVy18SpWFk3ojshfXQnMQ/OkykQdN6H1UAGRIjvgIshZcFCVoQknuPC0k3gl0 LOys/gth3QzqgohD5LLN54Bsj8UK3qswr5Vi8CO2b0YhGG0i6RVYyHEybeA4vVahwclK 8yCPb+UAf+1wh+knazoxsuvoDP7EcQpTfDFZvAfGh6IQYRwZHcotFlDk+X7YL+YLIeJS Y8q8Lm3Chtov3kvWwtE9DHm2Q8VyzJqKpRMNwBJB2zeuQhOitu0DAM3QejyiWMi96dn8 sxCw== X-Forwarded-Encrypted: i=1; AJvYcCU6UmpcDZcXIwAl4AAqRwME8WB3D8FWaI/1FJ9lFbEXvTcF1kA1PruDAY47Qc1eStE4TsUvapmPxXDdRq2aPiXKodghnaSfKbYysSzIjR35PscuGAk= X-Gm-Message-State: AOJu0YzL4W3720FQSChOOGXRrMJadgDCNThES28fNulJd7kx8E7OS9I+ 24vqax40ber7Xy3KuR9qU3Pkil3zwNz1zej3rK/JS+dIbHZ8oLp/KF1SMrVYcSY= X-Google-Smtp-Source: AGHT+IGWqjR12HPSB0jzPyPqMM3bUylbm55ZAq4klh7qS446LYCfduZoAUBb6DBdgrKY9LqhUuIk0w== X-Received: by 2002:a2e:958f:0:b0:2e2:9d0:9295 with SMTP id 38308e7fff4ca-2e51fd41f7emr207167051fa.8.1716295930722; Tue, 21 May 2024 05:52:10 -0700 (PDT) Received: from localhost (host-87-18-209-253.retail.telecomitalia.it. [87.18.209.253]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-574f6b8b9d7sm8750595a12.82.2024.05.21.05.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 05:52:10 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 21 May 2024 14:52:20 +0200 To: Stefan Wahren Cc: Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Marc Zyngier , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH v3 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller Message-ID: Mail-Followup-To: Stefan Wahren , Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Marc Zyngier , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240521_055213_636782_B63401D2 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13:56 Tue 21 May , Stefan Wahren wrote: > Hi Andrea, > > Am 21.05.24 um 10:35 schrieb Andrea della Porta: > > The BCM2712 has an SDHCI capable host interface similar to the one found > > in other STB chipsets. Add the relevant compatible string. > > > > Signed-off-by: Andrea della Porta > > --- > > Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > index cbd3d6c6c77f..d584a7ea707a 100644 > > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > > @@ -13,6 +13,10 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - items: > > + - enum: > > + - brcm,bcm2712-sdhci > > + - const: brcm,sdhci-brcmstb > sorry i didn't noticed in V2, but why can't we just extend the second > items list? Hi Stefan, I initially thought that the two different item lists represent two different controller families, but now that you point that out, I'm more and more convinced that probably we can shorten the representation as you are suggesting, adding 'brcm,bcm2712-sdhci' to the second item list enum. Will be so in V4. Many thanks, Andrea > > - items: > > - enum: > > - brcm,bcm7216-sdhci > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel