From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 556DBC25B74 for ; Tue, 21 May 2024 13:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S1SBRZlBtrk2zeg6VcXe0u7PPrRccu6kmJNxkY2CzUE=; b=qfHs2555qT19E7 Piv4HFXNUYxAzTQ+09xw2/6PueEu+VL6UQXHljanB8alf1HITFXqRNG0d/5blt5G0FgNnHY0vS7Y7 cZSHISRxZu3MILaws1VaypWSo3rdZsKaIJF+L8XfkSfwaezvyN1QhXZEzUbDlWLXdAdDvjlcsdfRB Xba6Yr7IH4siwPP0wA3KZDVTenWzQwFiq+oaa1R3PCTu9TQbbVP7sPjDhHDiOjNRAdvOVEnEdEf8F jjcIb7HiSu8iAAszzRm+a6VsSEMxQJBTLqT89YZbxGoGeNjzYoOy60VHvEvB02ip5hdblYNay9MD0 8yUH2aDwnfgWhLMoXiJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9PU2-0000000HakF-00AS; Tue, 21 May 2024 13:24:50 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9PU0-0000000HajR-497t for linux-arm-kernel@bombadil.infradead.org; Tue, 21 May 2024 13:24:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3wEfHPk6pL6kwU/yy2abkEEY8hfNtGzo5P0xl407URY=; b=kKdriJ1B6kKTlsa37f3fEVs1Gc Xz1Qi726Q46u1ZDCQ0TP3zUrB7vved+c4VuIKt7/PTfc4I78K6la5vIKcLk5NQmSQ9iCaBb0UONmQ YAuS4NrN5wxoNT9S/20oQUI5YAR2lhbDAN8NFceRODthZi0ilbBETQKPdKTSmCq9sBerTkItvsK2s ENIzWn0JvKXeey6klLtVMCD/+DqsRzNHG8eVwz6sHQkNNob+Ahzqdqg0w2gijSlTPFI6FFcXw2sCa rJe77w+GONZYgWsN1K2lNbpFj1imB6BHb40uf9d5Hc4yaqymCnk7MyiF2Lj4bBn/IQovA3W/gz86G XD5F+e0g==; Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9PTv-00000006iXf-1SGj for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2024 13:24:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CE7BDA7; Tue, 21 May 2024 06:25:05 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F39373F641; Tue, 21 May 2024 06:24:38 -0700 (PDT) Date: Tue, 21 May 2024 14:24:34 +0100 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, Mark Brown , James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org Subject: Re: [PATCH V17 1/9] arm64/sysreg: Add BRBE registers and fields Message-ID: References: <20240405024639.1179064-1-anshuman.khandual@arm.com> <20240405024639.1179064-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240405024639.1179064-2-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240521_142443_786565_3E50A821 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 05, 2024 at 08:16:31AM +0530, Anshuman Khandual wrote: > This adds BRBE related register definitions and various other related field > macros there in. These will be used subsequently in a BRBE driver, which is > being added later on. While here, this drops redundant register definitions > from the header i.e (arch/arm64/include/asm/sysreg.h). > > BRBINFx_EL1_TYPE_IMPDEF_TRAP_EL3 register field value has been derived from > latest ARM DDI 0601 ID121123, AKA 2023-12 instead of latest ARM ARM i.e ARM > DDI 0487J.a. Please find the definition here. > > https://developer.arm.com/documentation/ddi0601/2023-12/ The K.a release of the ARM ARM has now been published, and that includes the "0b110000 IMPLEMENTATION DEFINED exception to EL3" value, so we can point to that now. With that in mind, for the commit message we can say: | This patch adds definitions related to the Branch Record Buffer | Extension (BRBE) as per ARM DDI 0487K.a. These will be used by KVM and | a BRBE driver in subsequent patches. | | Some existing BRBE definitions in asm/sysreg.h are replaced with | equivalent generated definitions. Aside from a couple of minor issues below, this looks good to me. With those fixed up (and the commit message above): Reviewed-by: Mark Rutland [...] > +Sysreg BRBIDR0_EL1 2 1 9 2 0 > +Res0 63:16 > +Enum 15:12 CC > + 0b101 20_BIT > +EndEnum Please pad this to the width of the field, i.e. 0b0101 20_bit > +Enum 11:8 FORMAT > + 0b0 0 > +EndEnum Likewise, this should be padded to the width of the field. As with the BRBFCR_EL1.BANK definitions, I reckon it's worth givin the enum value a prefix, so please make this: 0b0000 FORMAT_0 Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel