Re: [PATCH v8 00/14] Update SMMUv3 to the modern iommu API (part 2b/3)

From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: <iommu@lists.linux.dev>, Joerg Roedel <joro@8bytes.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>, Eric Auger <eric.auger@redhat.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Moritz Fischer <mdf@kernel.org>,
	Michael Shavit <mshavit@google.com>, <patches@lists.linux.dev>,
	Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Subject: Re: [PATCH v8 00/14] Update SMMUv3 to the modern iommu API (part 2b/3)
Date: Tue, 4 Jun 2024 01:45:01 -0700	[thread overview]
Message-ID: <Zl7UDSdN5VXo/hRH@Asurada-Nvidia> (raw)
In-Reply-To: <0-v8-6f85cdc10ce7+563e-smmuv3_newapi_p2b_jgg@nvidia.com>

On Mon, Jun 03, 2024 at 09:15:45PM -0300, Jason Gunthorpe wrote:

> This is on github:
> https://github.com/jgunthorpe/linux/commits/smmuv3_newapi
> 
> v8:
>  - Rebase on v6.10-rc2

It seems that the branch above isn't updated yet from 6.9-rc7 :)

FWIW, it's missing a patch from Robin fixing a regression:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.10-rc2&id=8b80549f1bc6

>  - Make arm_smmu_sva_domain_alloc NULL when SVA is disabled so the core
>    code sees a NULL function pointer
>  - Update comments around arm_smmu_attach_prepare()
>  - Rename struct attach_state -> arm_smmu_attach_state and document
>    better, include more common function paramters in state
>  - Consistently use ats_enabled everywhere, replacing disable_ats in state
>  - Move the note about ATS bypass/abort to arm_smmu_attach_prepare()
>  - Remove temporary cd_table.in_ste check in arm_smmu_sva_set_dev_pasid()
>  - Improve comments and clarity of logic in arm_smmu_attach_commit()
>  - Shorten arm_smmu_mmu_notifier_free()
>  - Fix domain -> sid_domain typo in arm_smmu_remove_dev_pasid()

> Cc: Nicolin Chen <nicolinc@nvidia.com>

With that, I retested with SVA sanity running on S1DSS.SSID0 and
S1DSS.BYPASS modes. Both work well. The kunit test passes also.

So, my previous Tested-by still stands.

Thanks
Nicolin

> Cc: Michael Shavit <mshavit@google.com>
> Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Moritz Fischer <mdf@kernel.org>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel