From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25378C25B7C for ; Wed, 29 May 2024 20:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tgTxzY40aiXX7EdX3HO9ZNddkItRJne4rptMsVTsIQo=; b=U88CIi/tzKwfp0 l0cbQwcXRkc5lMjLIkKh3ujGEt/xg+TY93aMRTpONsd2p9DOgXVnayxef7QUa5d1S8d12LREgo+Q/ /I4m3zVhOD9jDQj2J4IQ0RsRiASSq5Y5kctMW/ozyhxZClQtkdSbwkdzhost1IAs/G+a7EberXHym zyO0h4QeIdEqQuOiYKh+5YGwW9+8ART0naQq2v2pKmrqkQ5lugJrsUu/5hRoHi3j3XaJz8wyCuZIx QjafnXKhV0hWFBCFx7hFuVlapcsNi8R0z99UymTkFI8M8S6VAjbOQZXpS4LczFhRVSTON0kZnUGyP G5VsLdHz3mC7TwNphbsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCPcO-00000005PqW-39et; Wed, 29 May 2024 20:09:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCPcL-00000005Pq1-0kLp for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 20:09:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EfQ/Q2iVyXpG7SyzUHxYwMhwGinL//RTWhWN7EORZ8U=; b=UuJc4lM5bz5/HnE+yz/N6peyBE RbGvl89sUErh0CP4XxfiqiUCcQTU3gZ9Kx3efB73d+UdhiBVnqizINl+sOftuzZGuOf+uOrA3fvLA GsoOVe49GXYJCj1VpEQm0yAxpqpEbICHtMOpSRsUGU0fVTh87ZE/MN5KFg3va92gNQY9uiFyjezLS Gx6ENPcFw09Qdba9l68BL06+GT5eK2k3DiCGAmzUSUBwJ8psekOelpcLEYpF30JGQlgOsCvB6njKi CpZ6jqpElpgZ0pWVl6m9wDH6V39bA9Hnidhg0Qa5AlsPSQMkRHoaJ0jlIRym7sQduqx2zXyk9+05B vU1gGLLA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56960) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sCPbu-0006cJ-1q; Wed, 29 May 2024 21:09:22 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sCPbr-0004UG-KU; Wed, 29 May 2024 21:09:19 +0100 Date: Wed, 29 May 2024 21:09:19 +0100 From: "Russell King (Oracle)" To: Sneh Shah Cc: Andrew Halaney , Vinod Koul , Bhupesh Sharma , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@quicinc.com Subject: Re: [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Add support for 2.5G SGMII Message-ID: References: <20231218071118.21879-1-quic_snehshah@quicinc.com> <4zbf5fmijxnajk7kygcjrcusf6tdnuzsqqboh23nr6f3rb3c4g@qkfofhq7jmv6> <8b80ab09-8444-4c3d-83b0-c7dbf5e58658@quicinc.com> <8f94489d-5f0e-4166-a14e-4959098a5c80@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_130949_320724_E779CBBD X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024 at 07:43:15PM +0530, Sneh Shah wrote: > In this version of qualcomm ethernet, PCS is not an independent HW > block. It is integrated to MAC block itself. It has very limited > configuration.Here PCS doesn't have it's own link speed/duplex > capabities. Hence we are bypassing all this PCS related functionalities. I want to concentrate on this part first - we'll address the 2.5G issues separately once I've got a picture of this hardware (and thus can work out what needs to change in my phylink_pcs implementation to support the standard Cisco SGMII speeds. >From what I understand you're saying, your integrated PCS is different from the DesignWare integrated PCS? Which core does it use? dwmac4_core.c or dwmac1000_core.c, or some other? Not knowing which core makes asking the following questions harder, since I'm having to double them up to cover both cores with their different definitions. Does it only present its status via the GMAC_PHYIF_CONTROL_STATUS or GMAC_RGSMIIIS register? >From what you're saying: - if using the dwmac1000 core, then for the registers at GMAC_PCS_BASE (0xc0 offset)... - if using the dwmac4 core, then for registers at GMAC_PCS_BASE (0xe0 offset)... ... is it true that only the GMAC_AN_CTRL() register is implemented and none of the other registers listed in stmmac_pcs.h? In terms of interrupts when the link status changes, how do they present? Are they through the GMAC_INT_RGSMIIS interrupt only? What about GMAC_INT_PCS_LINK or GMAC_INT_PCS_ANE? Or in the case of the other core, is it through the PCS_RGSMIIIS_IRQ interrupt only? Similarly, what about PCS_LINK_IRQ or PCS_ANE_IRQ? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel