From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C18BC27C44 for ; Wed, 29 May 2024 21:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KUrIjM55/yzKX5slJLaA7eM7aaHmSrd4VAlaAhDWDuc=; b=ie8qoTt6F6cmXRQlJXPmQSwZc0 XQZQVOEpodwEuPifNePfnKZT0VopmlS9Vftu2erwRh7/fJ5Efm+XuE/mKg/y8T2+NvqQ/N149GoiL A78UA3Ha61qXostOBwVKFlIW5s74HiSzZXEooYAjMrYzAhwSNU8E/RPbrHpDfsiLAFOnq4sqieAjo QlYRcqhBxYDBVvVaQ1b44+Zh06R/4Zy7z1hOtaocfGZMOBBwUPQHhi/oijnpZS3JN6h4THZKfm2I6 E8q2F60ainP5BPD2zbXMlzF1WdIgaQeWlgMmhqvBBk2rUZqIHZvWiLCwVj4VVh47DyA3kXW240jpK btQ22TDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCRCn-00000005dSm-4AID; Wed, 29 May 2024 21:51:33 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCRCj-00000005dQS-3jAw for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 21:51:31 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-df771bdee6bso294908276.3 for ; Wed, 29 May 2024 14:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717019486; x=1717624286; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HZEwQSuDxXsJBbCguZar5+VKzM/izfp4n/7bUq7QabM=; b=MT+n20QzoWgxDnd+uOHaUFRbQL+MgiWC+HTEhePOXV4RC1mYTmwhRanGjzY4BoQl9N b+f3X3kJerWIaGfd64B1ndhqYswCyvrrxyLNKJTaG9ra2sPRWWLC/6yhYEl/C5kntOpT B/2tB0aJy5NksuILcBR+slnjbNxAI8WFdQ16/gr2N3D6rYnUEGNel3SE44p+zWfkT070 jKB01GXvYmQZ/VcBRJhNtwE7EmydRhx6woOKEqeOvMKZjYCffACCZR4Nz52wJeJEYhBt ODbEKO7nFcw4FnB062Hf7ZJfAVGqWbj5irq658lksrYF0MpcyTfBlP7sMGQbkMLdU2Qj dt0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717019486; x=1717624286; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZEwQSuDxXsJBbCguZar5+VKzM/izfp4n/7bUq7QabM=; b=To58cxzh0YQ8fZI3VYAwjBvrgEaxbXyBXW+J+mTHc1QXLJRoV//62RRlXeYUVePGtC NTxsCeegSXoGmfijd0zYjc/lbn/f/QJtvKjqeuiShODqOJ9fnLXEVRFym1N2l4bP8H7D tg1QbC7J9MKBw1Pmc6kuFwo/by+EBP1pZMzTaX3v5TbybUXdPBZ/MHA1Oz90PQyeC8nW YsDQCFR/JJUAudbpoUhxlxRfQtaHRIB+VEVu4J5++mlXhgPiujPYzl6c2fFxJRxF0OZ3 tiBQjBjzBgnm6T+KqJU9Yn2H/Ri7JpGYhv5wAm/CA6W8p6TlEAE4lcuTrZPPL0D6LY7w 2MrA== X-Forwarded-Encrypted: i=1; AJvYcCXKG2/ceDJvJdOAwKUx68Qx7V/FoVfcK43MO6XnzShXI6Rls8/MsgiJuP6hvS11i2dCDEjYehYu6FcMDfggK6KBHJ79OhwYEJN3aSRPj1RybyeDBpg= X-Gm-Message-State: AOJu0YwZSY6NQpxIXpvxXXalutLhTwDxx4oKBGKw8WFzBEXv75jVit8P bXPkFC4edlltFEnMDuqbDj6SFi2B1WHtHsaPWknKAH1zpClHdGdeF+Y1+eldYwMIz1iCYbtXWHK SVw== X-Google-Smtp-Source: AGHT+IGqNZ2BbD8cAo2AnWXa3Pi0tfvxVmoPgtWnywK5+NXQgcmpZ6RBn86fT+8nIYtd+ZPLip7+OZUjHdQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:188e:b0:df7:8889:4795 with SMTP id 3f1490d57ef6-dfa5a407dc6mr54800276.0.1717019486318; Wed, 29 May 2024 14:51:26 -0700 (PDT) Date: Wed, 29 May 2024 14:51:24 -0700 In-Reply-To: <20240529180510.2295118-4-jthoughton@google.com> Mime-Version: 1.0 References: <20240529180510.2295118-1-jthoughton@google.com> <20240529180510.2295118-4-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 3/7] KVM: Add lockless memslot walk to KVM From: Sean Christopherson To: James Houghton Cc: Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Yu Zhao , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_145129_963915_7EBF6733 X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024, James Houghton wrote: > @@ -686,10 +694,12 @@ static __always_inline int kvm_handle_hva_range(struct mmu_notifier *mn, > return __kvm_handle_hva_range(kvm, &range).ret; > } > > -static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notifier *mn, > - unsigned long start, > - unsigned long end, > - gfn_handler_t handler) > +static __always_inline int kvm_handle_hva_range_no_flush( > + struct mmu_notifier *mn, > + unsigned long start, > + unsigned long end, > + gfn_handler_t handler, > + bool lockless) Unnecessary and unwanted style change. > { > struct kvm *kvm = mmu_notifier_to_kvm(mn); > const struct kvm_mmu_notifier_range range = { > @@ -699,6 +709,7 @@ static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notifier *mn > .on_lock = (void *)kvm_null_fn, > .flush_on_ret = false, > .may_block = false, > + .lockless = lockless, Why add @lockess to kvm_handle_hva_range_no_flush()? Both callers immediately pass %false, and conceptually, locking is always optional for a "no flush" variant. > }; > > return __kvm_handle_hva_range(kvm, &range).ret; > @@ -889,7 +900,8 @@ static int kvm_mmu_notifier_clear_young(struct mmu_notifier *mn, > * cadence. If we find this inaccurate, we might come up with a > * more sophisticated heuristic later. > */ > - return kvm_handle_hva_range_no_flush(mn, start, end, kvm_age_gfn); > + return kvm_handle_hva_range_no_flush(mn, start, end, > + kvm_age_gfn, false); > } > > static int kvm_mmu_notifier_test_young(struct mmu_notifier *mn, > @@ -899,7 +911,7 @@ static int kvm_mmu_notifier_test_young(struct mmu_notifier *mn, > trace_kvm_test_age_hva(address); > > return kvm_handle_hva_range_no_flush(mn, address, address + 1, > - kvm_test_age_gfn); > + kvm_test_age_gfn, false); > } > > static void kvm_mmu_notifier_release(struct mmu_notifier *mn, > -- > 2.45.1.288.g0e0cd299f1-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel