From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2721BC25B74 for ; Thu, 30 May 2024 18:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q3+NbyR448tnIPjSnGUv2i4ix/hRreQgP9k7v+W8v60=; b=GrCoRz4dc3HF7g 94ukB22ct8OLTfColGupfTCPnk0PSXd/pOyP4nP+n2gxkj59U/R253MOCo8lBaeTce2Unc0qLLiMW it4Cy49BuxR7OvOn0m5764OGl36Se74/Pmbbpw2NzZw8X/o5wP+1CrlhXflwqbK0HF9Xoek5b7mmO 19EXU4gkMniXYbXEqRLlvo1cB2IlpdMcp6K7gxpgL/3QAB90nC5J2jvE0nZbTOOsQiveuI5or9ArN yqolNSInmkic8ppNwvXrAgbqkCh8ZbuHx3DO5103/VsRwDehfkpR14IGzegivxT7AUiXZJgX84zpw ph+/GgGDcZgG5mY7+Bhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCkQU-000000085kQ-34Ct; Thu, 30 May 2024 18:22:58 +0000 Received: from out-181.mta1.migadu.com ([2001:41d0:203:375::b5]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCkQR-000000085jl-1vt6 for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 18:22:57 +0000 X-Envelope-To: tabba@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717093371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QSPX1FdincyYLkPXPIkPhXLJz2aAmMImLOXrXB0/Whs=; b=pOsEI3uVmMjv3KIHQGeT3EUqH00Rfdb/uHiw5lqDnWajvJNv5dxOfC0q7WxEvHdFuxQzGs xyDLEntOC9tirHdoSItkCb5ngxYmg691fd4+35WYpi8dUFcM5+ZC8KpnoL+XoucFUOPkle yjMOxVXKg7sEwN5M/mIO5JaaC+EP0QI= X-Envelope-To: kvmarm@lists.linux.dev X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: maz@kernel.org X-Envelope-To: will@kernel.org X-Envelope-To: qperret@google.com X-Envelope-To: seanjc@google.com X-Envelope-To: alexandru.elisei@arm.com X-Envelope-To: catalin.marinas@arm.com X-Envelope-To: philmd@linaro.org X-Envelope-To: james.morse@arm.com X-Envelope-To: suzuki.poulose@arm.com X-Envelope-To: mark.rutland@arm.com X-Envelope-To: broonie@kernel.org X-Envelope-To: joey.gouly@arm.com X-Envelope-To: rananta@google.com X-Envelope-To: yuzenghui@huawei.com Date: Thu, 30 May 2024 11:22:42 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, broonie@kernel.org, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 11/11] KVM: arm64: Drop sve_cond_update_zcr_vq_* Message-ID: References: <20240528125914.277057-1-tabba@google.com> <20240528125914.277057-12-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240528125914.277057-12-tabba@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240530_112256_034159_4595B9C2 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, May 28, 2024 at 01:59:14PM +0100, Fuad Tabba wrote: > The conditional update likely doesn't help performance, but makes > the code a bit more difficult to read. Remove these macros and > just write directly to ZCR. > > Signed-off-by: Fuad Tabba > --- > This patch is meant as an RFC, and undoes the previous patch. > Please feel free to accept/drop whichever patches you think make > sense. The motivation behind this helper is to avoid unnecessary synchronizing behavior, since as you note the architecture does not require explicit synchronization for the value to become visible to subsequent instructions. Now, that doesn't _necessarily_ imply full blown context synchronization, but it isn't too far fetched to think a conservative implementation does exactly that upon ZCR write. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel