From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE8D1C25B74 for ; Sun, 2 Jun 2024 18:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R221LUg28ruTlV0Z6UTXIV93EfVh8Mj3FhuX0YZTZnE=; b=YRoYzNeJVpKxqliepB6IUtfS3g cEqdMeaSB7DvS5VHv5I8kkYyTB2XHE77m/+zsPZyoTMOiClyT7aJBxUpsx8QSF3rmrlw+T5BABtBu 3+wIFDFPdeQRC5ZfdidcZpLGkwS/h3123nxmQU+lhPMJT7B6PLoMiq05TOLiSo6n0tkfR8lV6mwbg /+wl2S0c2ViqURaRWgbWwj33GVRLhjWOmSJS+gXGISJAZlBXfUZrzS7/Ob7vtoIbb5mKTBdX02vdc u0TgZdhVgOIAK0XTXGOrCgsAMmDw6r+7dmhcce6W3ESGXDcWoo2oCK0XaxcYpxGgzQBhceDskc3KR 1gCGQPSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDpeq-0000000Ei6y-1MrA; Sun, 02 Jun 2024 18:10:16 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sDpen-0000000Ei6L-3C9Y for linux-arm-kernel@lists.infradead.org; Sun, 02 Jun 2024 18:10:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B09E9CE069A; Sun, 2 Jun 2024 18:10:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54FD1C2BBFC; Sun, 2 Jun 2024 18:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717351810; bh=+2MHK2yMT+QKsyqaCKdYfGSKtVMLtPAzggfxfAy/6mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DMXRB2nPmoDXEmw78Xp2j8KvSgFsayRwfNGzYQHtr3rVYV8XL9yyY0i5oLVuEjs/4 cY8X7VLaWfJ+MTMikL0+t/l8EpqULi2xC8cGf0mumpKOEypU0uc3QdnEJCN9QHMsGZ TtXEoanspd5DhWx2ud7/3wQKJ08BMz3t96GuH6b8JrdcYg0wyMYH4CuW/17o7D3W5/ d30Yg32xUJ9bFMS8eOcOI3igakZ+1E9kpGDDGqvcPfjwAF3FIBJuZYLf6kx83ELvtw 5kWgBRsx1uE5jaNuPv5fegJ0Jf8sktv/gGbc2VRuqTCoQuVq9p91VSE8prGhTCfDCR QLcBaqXvjKztQ== Date: Sun, 2 Jun 2024 20:10:06 +0200 From: Lorenzo Bianconi To: Andrew Lunn Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu Subject: Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: References: <4d63e7706ef7ae12aade49e41bb6d0bb6b429706.1717150593.git.lorenzo@kernel.org> <9efb0c64-d3b2-478b-953e-94ef8be3ddec@lunn.ch> MIME-Version: 1.0 In-Reply-To: <9efb0c64-d3b2-478b-953e-94ef8be3ddec@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240602_111014_008193_1C14F650 X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6797514249611400589==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6797514249611400589== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rMKqNu+NNvg9Cdc8" Content-Disposition: inline --rMKqNu+NNvg9Cdc8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > +static void airoha_remove(struct platform_device *pdev) > > +{ > > + struct airoha_eth *eth =3D platform_get_drvdata(pdev); > > + int i; > > + > > + debugfs_remove(eth->debugfs_dir); > > + > > + airoha_qdma_for_each_q_rx(eth, i) { > > + struct airoha_queue *q =3D ð->q_rx[i]; > > + > > + netif_napi_del(&q->napi); > > + airoha_qdma_clenaup_rx_queue(q); > > + page_pool_destroy(q->page_pool); > > + } > > + > > + for (i =3D 0; i < ARRAY_SIZE(eth->q_tx_irq); i++) > > + netif_napi_del(ð->q_tx_irq[i].napi); > > + for (i =3D 0; i < ARRAY_SIZE(eth->q_tx); i++) > > + airoha_qdma_clenaup_tx_queue(ð->q_tx[i]); > > +} >=20 > You don't appear to unregister the netdev. remove() should basically > be the reverse of probe(). >=20 > Andrew ack, I will fix it in v2. Regards, Lorenzo --rMKqNu+NNvg9Cdc8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZly1fgAKCRA6cBh0uS2t rGnRAQDL+Z25OzOQ0PBS7Q4U+fs6OlcTqibJhISHTyD7t+RhwgD9F7EUM814UEW/ +o/GVe1SP1g9LG4cu0E1pVX9uw2XRgI= =aNJq -----END PGP SIGNATURE----- --rMKqNu+NNvg9Cdc8-- --===============6797514249611400589== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6797514249611400589==--