From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11BA1C27C53 for ; Mon, 17 Jun 2024 01:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I+p47SL6dimu9f+zi9duzMmWriyBTBtbi5NfLRZ8KGA=; b=afqMjMyeksTT4hEy7FU2g+BWWB 1sRx2GwBRHsOdjyKD6e+wRODT/NsYbSVQJrRW33THYtUlqiolLJgAcB6xeJdMGS6ZyK74LVDNs1J+ eGYO0kqJIs3sINegr0vqz8tGDw4oPtybNsE8dZJic+ABnfJ8e5Q7/J4Z9aNu4kGGIhmyvrYF5QIkK j2G7yTP7LIdqC5ChRn/Ja7UVSPwAGome7zFC1rlk3mYvx/1C/vA944MhAolxVI88ziANtRz0j7xoY XBAnqWbkmrpLUTlIXOEvuHxxf4/MBwNXKjVhS7j1unTBSv1iWgV4ppZT1K0Slof5iaY/py9DlLj8p WlnjCb0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ1MC-00000008j7Q-18OY; Mon, 17 Jun 2024 01:40:28 +0000 Received: from mail-177131.yeah.net ([123.58.177.131]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ1M9-00000008j5X-1Mq2 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 01:40:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=I+p47SL6dimu9f+zi9duzMmWriyBTBtbi5NfLRZ8KGA=; b=E3PcAbLY8b8ZmRtbnWsycS2VEqnn4zWApJc4ZFgz0IBl3rI7U4YG8wVW1JbQMv dJ+BU/v0crlUWJH5/A94Q6IK4KmT+7WORoBT3dDQ6j2vnorDiByCPCZNE8HoU7Gw zIF0q+JqbYb2NQsLkZGrFIHxj5QTRZ+dKQgI5dBQtIr2c= Received: from dragon (unknown [114.216.76.201]) by smtp1 (Coremail) with SMTP id ClUQrACH7voClG9mgKELCA--.41844S3; Mon, 17 Jun 2024 09:40:19 +0800 (CST) Date: Mon, 17 Jun 2024 09:40:18 +0800 From: Shawn Guo To: Michael Walle Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Li Yang , Pengutronix Kernel Team , Fabio Estevam , Priit Laes , Michael Grzeschik , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marco Felsch , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 08/13] ARM: dts: imx6qdl-kontron-samx6i: add SDIO_PWR_EN support Message-ID: References: <20240606090206.2021237-1-mwalle@kernel.org> <20240606090206.2021237-9-mwalle@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606090206.2021237-9-mwalle@kernel.org> X-CM-TRANSID: ClUQrACH7voClG9mgKELCA--.41844S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7trWDCr4kXw45ur4UCr4xXrb_yoW8tr48pF s3GrZagrykWry3tay3Ga42kr4rCw4kC3s7uw12gFy8AFy7Z3WUur97Krn8A3Z5XFs8Zw4a kry3Zr9rA3Z2v37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jz1v3UUUUU= X-Originating-IP: [114.216.76.201] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiFQMBZV6NnP+BgAAAsD X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240616_184025_733445_B46B33F6 X-CRM114-Status: GOOD ( 16.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 06, 2024 at 11:02:01AM +0200, Michael Walle wrote: > The module can enable/disable the SD card power supply and has > it's dedicated pin SDIO_PWR_EN for that reason. This is esp. > useful to be able to reset the SD card if it was in an UHS mode. > > Signed-off-by: Michael Walle > --- > .../dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi > index 4d3cd338a707..d36743e47552 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi > @@ -61,6 +61,18 @@ reg_3p3v_s5: regulator-3p3v-s5 { > vin-supply = <®_smarc_suppy>; > }; > > + reg_sdio: regulator-sdio { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_sdio>; > + regulator-name = "V_3V3_SD"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>; > + off-on-delay-us = <20000>; > + enable-active-high; enable-active-high right after line of GPIO_ACTIVE_HIGH. Shawn > + }; > + > reg_smarc_lcdbklt: regulator-smarc-lcdbklt { > compatible = "regulator-fixed"; > pinctrl-names = "default"; > @@ -640,6 +652,12 @@ MX6QDL_PAD_SD1_CMD__PWM4_OUT 0x1b0b1 > >; > }; > > + pinctrl_reg_sdio: reg-sdiogrp { > + fsl,pins = < > + MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0 /* SDIO_PWR_EN */ > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA 0x1b0b1 > @@ -692,7 +710,6 @@ MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17059 > > MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x1b0b0 /* CD */ > MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b0 /* WP */ > - MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x1b0b0 /* PWR_EN */ > >; > }; > > @@ -795,6 +812,7 @@ &usdhc3 { > pinctrl-0 = <&pinctrl_usdhc3>; > cd-gpios = <&gpio6 14 GPIO_ACTIVE_LOW>; > wp-gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>; > + vmmc-supply = <®_sdio>; > no-1-8-v; > }; > > -- > 2.39.2 >