From: William Breathitt Gray <wbg@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Lee Jones <lee@kernel.org>,
linux-iio@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mfd: stm32-timers: Drop TIM_DIER_CC_IE(x) in favour of TIM_DIER_CCxIE(x)
Date: Sun, 16 Jun 2024 17:46:45 +0900 [thread overview]
Message-ID: <Zm6mdYBhP1dAMthI@ishi> (raw)
In-Reply-To: <0735860960b1b38570bffa5b0de81a97f6e3230e.1718352022.git.u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Fri, Jun 14, 2024 at 10:10:13AM +0200, Uwe Kleine-König wrote:
> These two defines have the same purpose and this change doesn't
> introduce any differences in drivers/counter/stm32-timer-cnt.o.
>
> The only difference between the two is that
>
> TIM_DIER_CC_IE(1) == TIM_DIER_CC2IE
>
> while
>
> TIM_DIER_CCxIE(1) == TIM_DIER_CC1IE
>
> . That makes it necessary to have an explicit "+ 1" in the user code,
> but IMHO this is a good thing as this is the code locatation that
> "knows" that for software channel 1 you have to use TIM_DIER_CC2IE
> (because software guys start counting at 0, while the relevant hardware
> designer started at 1).
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
I concur with Lee Jones that the subject should be renamed. Regardless,
here's my ack for the code changes.
Acked-by: William Breathitt Gray <wbg@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-06-16 8:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 8:10 [PATCH 0/4] mfd: stm32-timers: Make register definition more flexible Uwe Kleine-König
2024-06-14 8:10 ` [PATCH 1/4] mfd: stm32-timers: Unify alignment of register definition Uwe Kleine-König
2024-06-18 17:46 ` Thorsten Scherer
2024-06-14 8:10 ` [PATCH 2/4] mfd: stm32-timers: Add some register definitions with a parameter Uwe Kleine-König
2024-06-14 8:10 ` [PATCH 3/4] mfd: stm32-timers: Drop TIM_DIER_CC_IE(x) in favour of TIM_DIER_CCxIE(x) Uwe Kleine-König
2024-06-14 9:31 ` Lee Jones
2024-06-16 13:52 ` Uwe Kleine-König
2024-06-16 8:46 ` William Breathitt Gray [this message]
2024-06-14 8:10 ` [PATCH 4/4] pwm-stm32: Make use of parametrised register definitions Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zm6mdYBhP1dAMthI@ishi \
--to=wbg@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).