From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A585AC27C6E for ; Sun, 16 Jun 2024 08:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CX71xbp8zBdJb9FFGr78worqTH2WkzIl8c3mAtM9+CM=; b=toYQcwkcMe+FJVpO3JtMlFghKO P2fB46BM6IYXAW7kCubI6fwyFEMncJXZDvDV4G0IrPpd8YYHnibx2CEd/urkedC2KJCuOFCCJntRD rJCBx7B7fCb3/i6olG/+Rg58pNTCEWKmSGWSFLH0F6actBWMUvlYc4JYpO5V/iHy053FgbS/z+PdH T3yvbbkAzyq7qIli+QhNppch+RmggbhCasIcMz+yEl5q9hEGE0ukObFhtT4g7SZlaVgzixohsrdSg 0jTgTEK5tVXtna+AVf7GHK2Kt5oGwcO4PXINo3mOqDJo/RClLSGhVPZqRekLEB+zkYnYGAGDatPjQ tkwUAJiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIlXO-00000007BIV-2F0W; Sun, 16 Jun 2024 08:46:58 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIlXK-00000007BHh-3XNf for linux-arm-kernel@lists.infradead.org; Sun, 16 Jun 2024 08:46:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5B1E1CE097C; Sun, 16 Jun 2024 08:46:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18B01C2BBFC; Sun, 16 Jun 2024 08:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718527611; bh=nQ/vCqxQ64G/dU866VmZFNtnjndHdvzguYFblH2UCDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N2OHdvVKgDV+k8tBQb+6fbyD7clBj1Ae+BaJCTTdzJQNSHTbIIYCAmvRZnVnpuMUQ 0S04uOl50zNEJJV8ztTxdj1bG/H9Z2GJDy4jm71ycJ7t2pwMCiXtH6MlepC8uFGxhI y1+hq6cpVQ4Xs/SONuFzbQRyx9v7P4nHz+F2+BR92quaY1ANm+vlOBMZBjdqcj4rvN B9MAsRbOoevugcbQlQ3NRrg/S1BbLm29qkIOdxzXKMW3gSolOFTsYK7BkiTW/iadfp L1mAbgaHwc/LdwyEjUw+ojql6oqoXtzAWCAV66s1MbPjE3dn4GGeYq50Fz7kHFL4+j OIWYMuetZQcVQ== Date: Sun, 16 Jun 2024 17:46:45 +0900 From: William Breathitt Gray To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Lee Jones , linux-iio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mfd: stm32-timers: Drop TIM_DIER_CC_IE(x) in favour of TIM_DIER_CCxIE(x) Message-ID: References: <0735860960b1b38570bffa5b0de81a97f6e3230e.1718352022.git.u.kleine-koenig@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dCl7/OXUWXzDpqmf" Content-Disposition: inline In-Reply-To: <0735860960b1b38570bffa5b0de81a97f6e3230e.1718352022.git.u.kleine-koenig@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240616_014655_090939_20ECF41F X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --dCl7/OXUWXzDpqmf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 14, 2024 at 10:10:13AM +0200, Uwe Kleine-K=F6nig wrote: > These two defines have the same purpose and this change doesn't > introduce any differences in drivers/counter/stm32-timer-cnt.o. >=20 > The only difference between the two is that >=20 > TIM_DIER_CC_IE(1) =3D=3D TIM_DIER_CC2IE >=20 > while >=20 > TIM_DIER_CCxIE(1) =3D=3D TIM_DIER_CC1IE >=20 > . That makes it necessary to have an explicit "+ 1" in the user code, > but IMHO this is a good thing as this is the code locatation that > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE > (because software guys start counting at 0, while the relevant hardware > designer started at 1). >=20 > Signed-off-by: Uwe Kleine-K=F6nig I concur with Lee Jones that the subject should be renamed. Regardless, here's my ack for the code changes. Acked-by: William Breathitt Gray --dCl7/OXUWXzDpqmf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZm6mdQAKCRC1SFbKvhIj K30lAQDsaSV5Lc4QTe+SNucCUL6Fa1IDxYIgK4zoGmqxb9xPwwD9F2jDmowZBtn1 G4nggdLs3gGlZTYbXuMu9YnjuVjaTgk= =v9Mi -----END PGP SIGNATURE----- --dCl7/OXUWXzDpqmf--