From: Nicolin Chen <nicolinc@nvidia.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: <iommu@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
<robin.murphy@arm.com>, <will@kernel.org>, <joro@8bytes.org>,
<jgg@nvidia.com>, <ryan.roberts@arm.com>, <kevin.tian@intel.com>,
<mshavit@google.com>, <eric.auger@redhat.com>,
<joao.m.martins@oracle.com>, <jiangkunkun@huawei.com>,
<zhukeqian1@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH v5 6/6] iommu/arm-smmu-v3: Enable HTTU for stage1 with io-pgtable mapping
Date: Thu, 6 Jun 2024 16:47:57 -0700 [thread overview]
Message-ID: <ZmJKrcPeVdcf3xyR@Asurada-Nvidia> (raw)
In-Reply-To: <20240606133302.17540-7-shameerali.kolothum.thodi@huawei.com>
On Thu, Jun 06, 2024 at 02:33:02PM +0100, Shameer Kolothum wrote:
> From: Kunkun Jiang <jiangkunkun@huawei.com>
>
> If io-pgtable quirk flag indicates support for hardware update of
> dirty state, enable HA/HD bits in the SMMU CD and also set the DBM
> bit in the page descriptor.
>
> Now report the dirty page tracking capability of SMMUv3 and
> select IOMMUFD_DRIVER for ARM_SMMU_V3 if IOMMUFD is enabled.
>
> Co-developed-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
With a nit:
> +static bool arm_smmu_dbm_capable(struct arm_smmu_device *smmu)
> +{
> + u32 features = (ARM_SMMU_FEAT_HD | ARM_SMMU_FEAT_COHERENCY);
> +
> + return (smmu->features & features) == features;
Following the existing coding style in the driver:
return (smmu->features & ARM_SMMU_FEAT_HD) &&
(smmu->features & ARM_SMMU_FEAT_COHERENCY);
And inline?
Thanks
Nicolin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-07 0:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 13:32 [PATCH v5 0/6] Add IOMMUFD dirty tracking support for SMMUv3 Shameer Kolothum
2024-06-06 13:32 ` [PATCH v5 1/6] iommu/arm-smmu-v3: Factor out a common domain alloc Shameer Kolothum
2024-06-06 18:08 ` Jason Gunthorpe
2024-06-06 22:12 ` Nicolin Chen
2024-06-06 13:32 ` [PATCH v5 2/6] iommu/arm-smmu-v3: Add support for domain_alloc_user fn Shameer Kolothum
2024-06-06 22:13 ` Nicolin Chen
2024-06-06 13:32 ` [PATCH v5 3/6] iommu/arm-smmu-v3: Add feature detection for HTTU Shameer Kolothum
2024-06-06 23:10 ` Nicolin Chen
2024-06-07 8:04 ` Shameerali Kolothum Thodi
2024-06-07 21:21 ` Nicolin Chen
2024-06-06 13:33 ` [PATCH v5 4/6] iommu/io-pgtable-arm: Add read_and_clear_dirty() support Shameer Kolothum
2024-06-06 13:33 ` [PATCH v5 5/6] iommu/arm-smmu-v3: Add support for dirty tracking in domain alloc Shameer Kolothum
2024-06-06 23:39 ` Nicolin Chen
2024-06-06 13:33 ` [PATCH v5 6/6] iommu/arm-smmu-v3: Enable HTTU for stage1 with io-pgtable mapping Shameer Kolothum
2024-06-06 23:47 ` Nicolin Chen [this message]
2024-06-07 9:49 ` [PATCH v5 0/6] Add IOMMUFD dirty tracking support for SMMUv3 Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmJKrcPeVdcf3xyR@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jiangkunkun@huawei.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=mshavit@google.com \
--cc=robin.murphy@arm.com \
--cc=ryan.roberts@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).