From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEB96C27C55 for ; Fri, 7 Jun 2024 07:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HRVB5nBhIUGg2gjaivZYNr2PjkvO9ZLY1DL0VjhB30k=; b=Brj+YVYXwKjuXY V/Said44pnydBslX8ka7Oans1ROoQcRy1YKbaXpYwzNQwH2jENK691Cqhl+EnY3ehkZGxPCsWtg75 UkpNUC1UkzW60lXTkB8Vzz1cDHH7pSFobh6UOPMiIRaT8TVCXF63tOUWk+P5n0b3pESm2ME8f6TnO JE4j02etcRbrRiUS35/ELGFwvWMUmtVJM0x+JxRyYEFgBj0uyVPSrDJRmvSqMjZAmlBQTm3mvqLDy G9qeS/zfMip/OEmsGI7mKzxYi5IsAYIyk3NdkUmt5hqqxkaLIqNzwNDriXYfBDemAUl6RnQAxhz/I mCwKSxDqH0Ic9PME/crw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUAI-0000000Cyu5-1XeP; Fri, 07 Jun 2024 07:37:34 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFUAE-0000000Cys5-2h0P for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 07:37:32 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3550134ef25so1774246f8f.1 for ; Fri, 07 Jun 2024 00:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717745848; x=1718350648; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=s7f9odkH4nqlNDkoBdG1RGbEfYe2W4UxGmJOppHwoQw=; b=YT2XiCQQez7lsfa1rspRhYA6vm4Nx2JxH4wpNcp58VSoC4sI5PNOQzlXTqkTJzlKL+ T0BGXsrrgjBhrSR4Sd0o9jG8Gju/YkT3Rizm742wWVizMM/meZr5IjNTlAX9+CMw8rf/ CwSFEB0AgwKQGNb2lP54IvbPFrXf5rwSpkFM9jHmuIWz4OQe+C9ytz22hXc7eCsjcvZL PWouLEy8Eg7+qIWhvK2kN6UVpsKtp3ctUmjBwRxaV7wCpmYrv3EKB8ou54PGbXjzSC8P EGN2Y45Wpne7Jx5sA/ut5OchfaiYMS57wi8A1FfSYyaeSN1zHTDfLjVuNmY71jF8h0zD GBMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717745848; x=1718350648; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s7f9odkH4nqlNDkoBdG1RGbEfYe2W4UxGmJOppHwoQw=; b=Y8NA+TotLsGxNc+Tnrr0rN+iyPyv4ApRE8vXD2b0Z9fedfRWi6Wt8iO5c87rSm1ERQ /QuKPsfmCyPfauAkm4mZ+aZiSnWy05RpGg+dQzztOcXwhRw4KPtnGbOaYDtzLc1d3k/5 yPhJKTBUw2LDe3ncdSXz/CZQA0ECfUNdFhg4RdNKwiA/TZHRabcIS+GCD9uP0sdbpKvS oueyGktL8HLsF5L9y7UMC+LU1qEPgiIHkk1flgFrvk30OIqZqq/N8dCxY5v16ejDQFDK ATA0OZxP96BDz4vYjm1dh0g17tln9QRaeUjDi0isF1jnBmqf8OfjWDUy/lIMpC0XrU8+ GWMA== X-Forwarded-Encrypted: i=1; AJvYcCU/W5pBFPMC6osNe6v4IE2SK8KZy5+HfxMCumeuPgvmWGfcpBPFoMRHX6M62ps9IoL+IdUpd4ixdb+YMnoap9tB1omPdXBJnQUWE6Y9f11NW96ORP4= X-Gm-Message-State: AOJu0Yze4OyOnj+c4QzhSqzgKken4VEytY/HbmJeGPl2E767EHOzv/OC 6tZsbLipuo28dL6rR6rJLeJ5J+uS2GM3RaYG/zbBdbB8pqwXfMAiTCkuJvSNiVg= X-Google-Smtp-Source: AGHT+IE/YF8k48fFIRZefOBJiz3W4OR8sqVrlZY1CGl7xAyeQ466Z8xIR8jJKkF83TAF/kYrZbzKQQ== X-Received: by 2002:adf:f607:0:b0:352:f27d:525e with SMTP id ffacd0b85a97d-35efee0affcmr1108043f8f.47.1717745848349; Fri, 07 Jun 2024 00:37:28 -0700 (PDT) Received: from localhost.localdomain (62.83.84.125.dyn.user.ono.com. [62.83.84.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5fc1c77sm3346521f8f.95.2024.06.07.00.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 00:37:28 -0700 (PDT) From: Oscar Salvador X-Google-Original-From: Oscar Salvador Date: Fri, 7 Jun 2024 09:37:26 +0200 To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Jonathan Cameron , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.org Subject: Re: [PATCH] mm/memory_hotplug: Drop memblock_phys_free() call in try_remove_memory() Message-ID: References: <20240605082049.973242-1-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240605082049.973242-1-rppt@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_003730_768040_4A0E54F3 X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2024 at 11:20:49AM +0300, Mike Rapoport wrote: > From: Jonathan Cameron > > The call for memblock_phys_free() in try_remove_memory() does not balance > any call to memblock_alloc() (or memblock_reserve() for that matter). > > There are no memblock_reserve() calls in mm/memory_hotplug.c, no memblock > allocations possible after mm_core_init(), and even if memblock_add_node() > called from add_memory_resource() would need to allocate memory, that > memory would ba allocated from slab. > > The patch f9126ab9241f ("memory-hotplug: fix wrong edge when hot add a new > node") that introduced that call to memblock_free() does not provide > adequate description why that was required and tinkering with memblock in > the context of memory hotplug on x86 seems bogus because x86 never kept > memblock after boot anyway. > > Drop memblock_phys_free() call in try_remove_memory(). > > Signed-off-by: Jonathan Cameron > [rppt: rewrite the commit message] > Signed-off-by: Mike Rapoport (IBM) Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel