From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE3FFC27C53 for ; Fri, 7 Jun 2024 17:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5paf+zf42eNeTYstzHfsPtZw9elR3GlO1N5Rq/IXVWc=; b=WDiGeUL1IZC2jK Y5QKSt4/gxrXeDsTJhTHlMdfBjNkKfVwjgdWtxq9ftW5aibjVU4ySBwbhrUxty99qplJyp3nUv//x PQZpRgxFLVQVG6vTKgPqDZmGh6ad5FyOEVd7fTDamBhFJt9fxRkxXvnl0MAkimZma0mMSVpsBohqI 0rBTDYZrZrNrc/I6VdXbvNEuqvrrFaGW84JqyrfKeRifQli4vRuIeTaw2abE87K1VuxwPeTFpbIOs MkWc5K9hsBWHtvvBE0nv+AsKbQYf6X1rQEiym5Uqej93dyKJErbv3rhTkJwcmR/2hAQuLzlNwsgyz 7uMyEEHvjo0pcnKNfl5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFdC2-0000000F3XG-0DT1; Fri, 07 Jun 2024 17:15:58 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFdBy-0000000F3WD-3z38 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2024 17:15:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D988A616F8; Fri, 7 Jun 2024 17:15:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C70CDC2BBFC; Fri, 7 Jun 2024 17:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717780553; bh=3XYeD6IP8Z0vF8HLIMKW0yAmSge/3jtKexVmbtdSwsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L0xc0I85TuSJ95cq4edqPXW9BPSXEG4M6aY7VreDWcRbE5R0JL/EtVBL8WlLwdj8Y DrzI/soOlN/jYH8CS7R/6giJ5yc6TKvMAEehrhflTHJ3zol2D0QNVfqXjYd0+Q859i 17m74fg1luA9t/OtIyOJPOUerI+ugiF6aP6fEdLCKOJu0rbuhnSn9C1WIlBJu8npf0 umUwoqbGdnLOazgSyUGeeIhOsA7zYAiQ5q1xxIxHrLRrHlRFwqe73j1bFxBr/IMVZN RpocuNtWHywOGCFwR8nkxbvkE3jC83RepqAM1SV7wKa0mERe8rEAlU/4hv5jATp6Gg iitwqYuJ39Bcw== Date: Fri, 7 Jun 2024 22:45:49 +0530 From: Vinod Koul To: Dan Carpenter Cc: Peter Ujfalusi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , MD Danish Anwar , Roger Quadros , Grygorii Strashko , Julien Panis , Chintan Vankar , Diogo Ivo , Simon Horman , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq() Message-ID: References: <2f28f769-6929-4fc2-b875-00bf1d8bf3c4@kili.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2f28f769-6929-4fc2-b875-00bf1d8bf3c4@kili.mountain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240607_101555_066324_7175E994 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06-06-24, 17:23, Dan Carpenter wrote: > Currently the k3_udma_glue_rx_get_irq() function returns either negative > error codes or zero on error. Generally, in the kernel, zero means > success so this be confusing and has caused bugs in the past. Also the > "tx" version of this function only returns negative error codes. Let's > clean this "rx" function so both functions match. > > This patch has no effect on runtime. Acked-by: Vinod Koul -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel